[PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[shohei.maruyama]

If using qemu-system-aarch64 or qemu-system-arm with the options, an error
occured as follows:

  qemu-system-aarch64: Virtio VGA not available

this commit fixes the error to use -device virtio-gpu-pci instead of
-vga virtio.
---
 scripts/runqemu | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 19fd521cd9..28ecee97a7 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -398,11 +398,11 @@ class BaseConfig(object):
             elif arg == 'sdl':
                 self.qemu_opt_script += ' -display sdl'
             elif arg == 'gtk-gl':
-                self.qemu_opt_script += ' -vga virtio -display gtk,gl=on'
+                self.qemu_opt_script += ' -device virtio-gpu-pci,virgl=on -display gtk,gl=on'
             elif arg == 'gtk-gl-es':
-                self.qemu_opt_script += ' -vga virtio -display gtk,gl=es'
+                self.qemu_opt_script += ' -device virtio-gpu-pci,virgl=on -display gtk,gl=es'
             elif arg == 'egl-headless':
-                self.qemu_opt_script += ' -vga virtio -display egl-headless'
+                self.qemu_opt_script += ' -device virtio-gpu-pci,virgl=on -display egl-headless'
                 # As runqemu can be run within bitbake (when using testimage, for example),
                 # we need to ensure that we run host pkg-config, and that it does not
                 # get mis-directed to native build paths set by bitbake.
-- 
2.23.0

✗ patchtest: failure for runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[Patchwork]

== Series Details ==

Series: runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio
Revision: 1
URL   : https://patchwork.openembedded.org/series/19516/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

On Wed, 28 Aug 2019 at 06:36, <shohei.maruyama@cybertrust.co.jp> wrote:

> If using qemu-system-aarch64 or qemu-system-arm with the options, an error
> occured as follows:
>
>   qemu-system-aarch64: Virtio VGA not available
>
> this commit fixes the error to use -device virtio-gpu-pci instead of
> -vga virtio.
>

Can you please look into why that error happens on arm, but not on x86?
-vga virtio is the officially documented option, so I would rather use that
everywhere.

Alex

[-- Attachment #2: Type: text/html, Size: 824 bytes --]

Re: [PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[shohei.maruyama]

> Can you please look into why that error happens on arm, but not on
> x86? -vga virtio is the officially documented option, so I would
> rather use that everywhere.

Accoding to 
https://wiki.qemu.org/Documentation/Platforms/ARM#virt_machine_graphics
, we should use '-device virtio-gpu-pci' if given '-M virt' to qemu-
system-aarch64 or qemu-system-arm.

On Wed, 2019-08-28 at 08:54 +0200, Alexander Kanavin wrote:
> On Wed, 28 Aug 2019 at 06:36, <shohei.maruyama@cybertrust.co.jp>
> wrote:
> > If using qemu-system-aarch64 or qemu-system-arm with the options,
> > an error
> > occured as follows:
> > 
> >   qemu-system-aarch64: Virtio VGA not available
> > 
> > this commit fixes the error to use -device virtio-gpu-pci instead
> > of
> > -vga virtio.
> 
> Can you please look into why that error happens on arm, but not on
> x86? -vga virtio is the officially documented option, so I would
> rather use that everywhere.
> 
> Alex

Re: [PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Fri, 30 Aug 2019 at 02:09, <shohei.maruyama@cybertrust.co.jp> wrote:

> > Can you please look into why that error happens on arm, but not on
> > x86? -vga virtio is the officially documented option, so I would
> > rather use that everywhere.
>
> Accoding to
> https://wiki.qemu.org/Documentation/Platforms/ARM#virt_machine_graphics
> , we should use '-device virtio-gpu-pci' if given '-M virt' to qemu-
> system-aarch64 or qemu-system-arm.
>

Thanks, I didn't know that the lists of supported graphical hardware differ
between various machines.

The patch makes sense then, I will test that it doesn't cause regressions
on x86 with virgl and add it to my patchset.

Alex

[-- Attachment #2: Type: text/html, Size: 1195 bytes --]

Re: [PATCH] runqemu: Change to use -device virtio-gpu-pci instead of -vga virtio

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Fri, 30 Aug 2019 at 13:38, Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> On Fri, 30 Aug 2019 at 02:09, <shohei.maruyama@cybertrust.co.jp> wrote:
>
>> > Can you please look into why that error happens on arm, but not on
>> > x86? -vga virtio is the officially documented option, so I would
>> > rather use that everywhere.
>>
>> Accoding to
>> https://wiki.qemu.org/Documentation/Platforms/ARM#virt_machine_graphics
>> , we should use '-device virtio-gpu-pci' if given '-M virt' to qemu-
>> system-aarch64 or qemu-system-arm.
>>
>
> Thanks, I didn't know that the lists of supported graphical hardware
> differ between various machines.
>
> The patch makes sense then, I will test that it doesn't cause regressions
> on x86 with virgl and add it to my patchset.\
>

Unfortunately it does regress. The system crashes on boot. So this needs to
be addressed first.

You can reproduce via 'oe-selftest -r
runtime_test.TestImage.test_testimage_virgl_gtk'.

You probably should create an arm-specific qemuboot config file that suits
your usecase rather than try to tweak runqemu script to change settings
after the fact.

Alex

[-- Attachment #2: Type: text/html, Size: 2002 bytes --]