All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michal Suchánek" <msuchanek@suse.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: David Hildenbrand <david@redhat.com>,
	"Dmitry V. Levin" <ldv@altlinux.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Breno Leitao <leitao@debian.org>,
	Michael Neuling <mikey@neuling.org>,
	Firoz Khan <firoz.khan@linaro.org>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Joel Stanley <joel@jms.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Allison Randal <allison@lohutok.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org,
	Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 0/4] Disable compat cruft on ppc64le v2
Date: Wed, 28 Aug 2019 16:37:57 +0200	[thread overview]
Message-ID: <20190828163757.123e0eba@naga> (raw)
In-Reply-To: <dbc5abde-ea15-be43-1fdb-d16052c19e03@c-s.fr>

On Wed, 28 Aug 2019 13:08:48 +0000
Christophe Leroy <christophe.leroy@c-s.fr> wrote:

> On 08/28/2019 10:30 AM, Michal Suchanek wrote:
> > With endian switch disabled by default the ppc64le compat supports
> > ppc32le only which is something next to nobody has binaries for.
> > 
> > Less code means less bugs so drop the compat stuff.
> > 
> > I am not particularly sure about the best way to resolve the llseek
> > situation. I don't see anything in the syscal tables making it
> > 32bit-only so I suppose it should be available on 64bit as well.
> > 
> > This is tested on ppc64le top of  
> 
> Really ?

Really. It boots with the unused variable. It might depend on some
config options or gcc features if unused variables are fatal.

Thanks

Michal

WARNING: multiple messages have this Message-ID (diff)
From: "Michal Suchánek" <msuchanek@suse.de>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	"Dmitry V. Levin" <ldv@altlinux.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Firoz Khan <firoz.khan@linaro.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Hari Bathini <hbathini@linux.ibm.com>,
	Joel Stanley <joel@jms.id.au>,
	Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	Breno Leitao <leitao@debian.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Allison Randal <allison@lohutok.net>,
	Michael Neuling <mikey@neuling.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] Disable compat cruft on ppc64le v2
Date: Wed, 28 Aug 2019 16:37:57 +0200	[thread overview]
Message-ID: <20190828163757.123e0eba@naga> (raw)
In-Reply-To: <dbc5abde-ea15-be43-1fdb-d16052c19e03@c-s.fr>

On Wed, 28 Aug 2019 13:08:48 +0000
Christophe Leroy <christophe.leroy@c-s.fr> wrote:

> On 08/28/2019 10:30 AM, Michal Suchanek wrote:
> > With endian switch disabled by default the ppc64le compat supports
> > ppc32le only which is something next to nobody has binaries for.
> > 
> > Less code means less bugs so drop the compat stuff.
> > 
> > I am not particularly sure about the best way to resolve the llseek
> > situation. I don't see anything in the syscal tables making it
> > 32bit-only so I suppose it should be available on 64bit as well.
> > 
> > This is tested on ppc64le top of  
> 
> Really ?

Really. It boots with the unused variable. It might depend on some
config options or gcc features if unused variables are fatal.

Thanks

Michal

  reply	other threads:[~2019-08-28 14:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28 10:30 [PATCH v2 0/4] Disable compat cruft on ppc64le v2 Michal Suchanek
2019-08-28 10:30 ` Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 1/4] fs: always build llseek Michal Suchanek
2019-08-28 10:30   ` Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 2/4] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-08-28 10:30   ` Michal Suchanek
2019-08-28 10:30 ` [PATCH v2 3/4] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-08-28 10:30   ` Michal Suchanek
2019-08-28 12:49   ` Christophe Leroy
2019-08-28 12:49     ` Christophe Leroy
2019-08-28 14:29     ` Michal Suchánek
2019-08-28 14:29       ` Michal Suchánek
2019-08-28 10:30 ` [PATCH v2 4/4] powerpc/64: Disable COMPAT if littleendian Michal Suchanek
2019-08-28 10:30   ` Michal Suchanek
2019-08-28 10:57 ` [PATCH v2 0/4] Disable compat cruft on ppc64le v2 Nicholas Piggin
2019-08-28 10:57   ` Nicholas Piggin
2019-08-28 14:40   ` Michal Suchánek
2019-08-28 14:40     ` Michal Suchánek
2019-08-28 13:08 ` Christophe Leroy
2019-08-28 13:08   ` Christophe Leroy
2019-08-28 14:37   ` Michal Suchánek [this message]
2019-08-28 14:37     ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828163757.123e0eba@naga \
    --to=msuchanek@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=allison@lohutok.net \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=david@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=firoz.khan@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hbathini@linux.ibm.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=joel@jms.id.au \
    --cc=ldv@altlinux.org \
    --cc=leitao@debian.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.