From: Christoph Hellwig <hch@infradead.org>
To: Michal Suchanek <msuchanek@suse.de>
Cc: Michael Neuling <mikey@neuling.org>,
Arnd Bergmann <arnd@arndb.de>, Nicolai Stange <nstange@suse.de>,
David Hildenbrand <david@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
David Howells <dhowells@redhat.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Paul Mackerras <paulus@samba.org>, Joel Stanley <joel@jms.id.au>,
Christian Brauner <christian@brauner.io>,
Firoz Khan <firoz.khan@linaro.org>,
Breno Leitao <leitao@debian.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org,
Allison Randal <allison@lohutok.net>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT
Date: Wed, 28 Aug 2019 23:46:24 -0700 [thread overview]
Message-ID: <20190829064624.GA28508@infradead.org> (raw)
In-Reply-To: <0ad51b41aebf65b3f3fcb9922f0f00b47932725d.1567007242.git.msuchanek@suse.de>
On Wed, Aug 28, 2019 at 06:43:50PM +0200, Michal Suchanek wrote:
> +ifdef CONFIG_COMPAT
> +obj-y += sys_ppc32.o ptrace32.o signal_32.o
> +endif
This should be:
obj-$(CONFIG_COMPAT) += sys_ppc32.o ptrace32.o signal_32.o
> /* This value is used to mark exception frames on the stack. */
> exception_marker:
> diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c
> index 60436432399f..73d0f53ffc1a 100644
> --- a/arch/powerpc/kernel/signal.c
> +++ b/arch/powerpc/kernel/signal.c
> @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk)
>
> rseq_signal_deliver(&ksig, tsk->thread.regs);
>
> - if (is32) {
> + if ((IS_ENABLED(CONFIG_PPC32) || IS_ENABLED(CONFIG_COMPAT)) && is32) {
I think we should fix the is_32bit_task definitions instead so that
callers don't need this mess. I'd suggest something like:
#ifdef CONFIG_COMPAT
#define is_32bit_task() test_thread_flag(TIF_32BIT)
#else
#define is_32bit_task() IS_ENABLED(CONFIG_PPC32)
#endif
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linuxppc-dev@lists.ozlabs.org,
David Hildenbrand <david@redhat.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Breno Leitao <leitao@debian.org>,
Michael Neuling <mikey@neuling.org>,
Nicolai Stange <nstange@suse.de>,
Allison Randal <allison@lohutok.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Joel Stanley <joel@jms.id.au>, Firoz Khan <firoz.khan@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Nicholas Piggin <npiggin@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Christian Brauner <christian@brauner.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Hari Bathini <hbathini@linux.ibm.com>
Subject: Re: [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT
Date: Wed, 28 Aug 2019 23:46:24 -0700 [thread overview]
Message-ID: <20190829064624.GA28508@infradead.org> (raw)
In-Reply-To: <0ad51b41aebf65b3f3fcb9922f0f00b47932725d.1567007242.git.msuchanek@suse.de>
On Wed, Aug 28, 2019 at 06:43:50PM +0200, Michal Suchanek wrote:
> +ifdef CONFIG_COMPAT
> +obj-y += sys_ppc32.o ptrace32.o signal_32.o
> +endif
This should be:
obj-$(CONFIG_COMPAT) += sys_ppc32.o ptrace32.o signal_32.o
> /* This value is used to mark exception frames on the stack. */
> exception_marker:
> diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c
> index 60436432399f..73d0f53ffc1a 100644
> --- a/arch/powerpc/kernel/signal.c
> +++ b/arch/powerpc/kernel/signal.c
> @@ -277,7 +277,7 @@ static void do_signal(struct task_struct *tsk)
>
> rseq_signal_deliver(&ksig, tsk->thread.regs);
>
> - if (is32) {
> + if ((IS_ENABLED(CONFIG_PPC32) || IS_ENABLED(CONFIG_COMPAT)) && is32) {
I think we should fix the is_32bit_task definitions instead so that
callers don't need this mess. I'd suggest something like:
#ifdef CONFIG_COMPAT
#define is_32bit_task() test_thread_flag(TIF_32BIT)
#else
#define is_32bit_task() IS_ENABLED(CONFIG_PPC32)
#endif
next prev parent reply other threads:[~2019-08-29 6:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 16:43 [PATCH v3 0/4] Disable compat cruft on ppc64le v3 Michal Suchanek
2019-08-28 16:43 ` Michal Suchanek
2019-08-28 16:43 ` [PATCH v3 1/4] powerpc: make llseek 32bit-only Michal Suchanek
2019-08-28 16:43 ` Michal Suchanek
2019-08-28 16:43 ` [PATCH v3 2/4] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-08-28 16:43 ` Michal Suchanek
2019-08-28 16:43 ` [PATCH v3 3/4] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-08-28 16:43 ` Michal Suchanek
2019-08-29 6:46 ` Christoph Hellwig [this message]
2019-08-29 6:46 ` Christoph Hellwig
2019-08-29 8:01 ` Arnd Bergmann
2019-08-29 8:01 ` Arnd Bergmann
2019-08-29 8:38 ` Christophe Leroy
2019-08-29 8:38 ` Christophe Leroy
2019-08-29 8:49 ` Arnd Bergmann
2019-08-29 8:49 ` Arnd Bergmann
2019-08-29 10:01 ` Michal Suchánek
2019-08-29 10:01 ` Michal Suchánek
2019-08-28 16:43 ` [PATCH v3 4/4] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default Michal Suchanek
2019-08-28 16:43 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829064624.GA28508@infradead.org \
--to=hch@infradead.org \
--cc=allison@lohutok.net \
--cc=andrew.donnellan@au1.ibm.com \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=firoz.khan@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hbathini@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=joel@jms.id.au \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=nstange@suse.de \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.