[PATCH] python-script: update license md5sum

[PATCH] python-script: update license md5sum

[Christophe PRIOUZEAU]

Update md5sum of license file.

Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
---
 meta-python/recipes-devtools/python/python-scrypt.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-python/recipes-devtools/python/python-scrypt.inc b/meta-python/recipes-devtools/python/python-scrypt.inc
index 783d05b7e..fef6ec976 100644
--- a/meta-python/recipes-devtools/python/python-scrypt.inc
+++ b/meta-python/recipes-devtools/python/python-scrypt.inc
@@ -1,6 +1,6 @@
 DESCRIPTION = "Bindings for the scrypt key derivation function library"
 LICENSE = "BSD-2-Clause"
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=8bef8e6712b1be5aa76af1ebde9d6378"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=cb641bc04cda31daea161b1bc15da69f"
 HOMEPAGE="https://bitbucket.org/mhallin/py-scrypt/overview"
 
 FILESEXTRAPATHS_prepend := "${THISDIR}/python-scrypt:"
-- 
2.17.1

Re: [PATCH] python-script: update license md5sum

[Adrian Bunk]

On Thu, Aug 29, 2019 at 02:35:07PM +0000, Christophe PRIOUZEAU wrote:
> Update md5sum of license file.
>...
> --- a/meta-python/recipes-devtools/python/python-scrypt.inc
> +++ b/meta-python/recipes-devtools/python/python-scrypt.inc
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Bindings for the scrypt key derivation function library"
>  LICENSE = "BSD-2-Clause"
> -LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=8bef8e6712b1be5aa76af1ebde9d6378"
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=cb641bc04cda31daea161b1bc15da69f"
>...

The actual problem is that this does not do what LIC_FILES_CHKSUM is 
supposed to do.

LIC_FILES_CHKSUM should verify that the license information in the 
software hasn't changed when upgrading it.

These recipes check the copy of the license text in OE instead,
which wouldn't change if the license of python-scrypt would change.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH] python-script: update license md5sum

[Khem Raj]

On Thu, Aug 29, 2019 at 8:51 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, Aug 29, 2019 at 02:35:07PM +0000, Christophe PRIOUZEAU wrote:
> > Update md5sum of license file.
> >...
> > --- a/meta-python/recipes-devtools/python/python-scrypt.inc
> > +++ b/meta-python/recipes-devtools/python/python-scrypt.inc
> > @@ -1,6 +1,6 @@
> >  DESCRIPTION = "Bindings for the scrypt key derivation function library"
> >  LICENSE = "BSD-2-Clause"
> > -LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=8bef8e6712b1be5aa76af1ebde9d6378"
> > +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=cb641bc04cda31daea161b1bc15da69f"
> >...
>
> The actual problem is that this does not do what LIC_FILES_CHKSUM is
> supposed to do.
>
> LIC_FILES_CHKSUM should verify that the license information in the
> software hasn't changed when upgrading it.
>

thats right and in most cases thats what it does too.

> These recipes check the copy of the license text in OE instead,
> which wouldn't change if the license of python-scrypt would change.
>

some packages just use license and do not include a license file in
which case the recipe
stubs it in. Not ideal but it is a band aid for such recipes.

> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH] python-script: update license md5sum

[Adrian Bunk]

On Thu, Aug 29, 2019 at 11:44:16AM -0700, Khem Raj wrote:
> On Thu, Aug 29, 2019 at 8:51 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Thu, Aug 29, 2019 at 02:35:07PM +0000, Christophe PRIOUZEAU wrote:
> > > Update md5sum of license file.
> > >...
> > > --- a/meta-python/recipes-devtools/python/python-scrypt.inc
> > > +++ b/meta-python/recipes-devtools/python/python-scrypt.inc
> > > @@ -1,6 +1,6 @@
> > >  DESCRIPTION = "Bindings for the scrypt key derivation function library"
> > >  LICENSE = "BSD-2-Clause"
> > > -LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=8bef8e6712b1be5aa76af1ebde9d6378"
> > > +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-2-Clause;md5=cb641bc04cda31daea161b1bc15da69f"
> > >...
> >
> > The actual problem is that this does not do what LIC_FILES_CHKSUM is
> > supposed to do.
> >
> > LIC_FILES_CHKSUM should verify that the license information in the
> > software hasn't changed when upgrading it.
> >
> 
> thats right and in most cases thats what it does too.
> 
> > These recipes check the copy of the license text in OE instead,
> > which wouldn't change if the license of python-scrypt would change.
> >
> 
> some packages just use license and do not include a license file
> in which case the recipe stubs it in.
> Not ideal but it is a band aid for such recipes.

You need some license information somewhere, legal default is that it is 
illegal to use or to distribute.


In reality this is just bad practice copied from one recipe to another.

For scrypt, see scrypt-0.8.6/LICENSE

python-intervals is even more funny:
LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/BSD-3-Clause;md5=550794465ba0ec5312d6919e203a55f9"

$ grep ^License: python-intervals-1.5.4/PKG-INFO 
License: LGPL3


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed