From: Christoph Hellwig <hch@lst.de>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: alan.cox@intel.com, Christoph Hellwig <hch@lst.de>,
Stefano Stabellini <sstabellini@kernel.org>,
ashok.raj@intel.com, Jonathan Corbet <corbet@lwn.net>,
pengfei.xu@intel.com, Ingo Molnar <mingo@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
kevin.tian@intel.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
mika.westerberg@linux.intel.com, Juergen Gross <jgross@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
jacob.jun.pan@intel.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v8 3/7] swiotlb: Zero out bounce buffer for untrusted device
Date: Fri, 30 Aug 2019 09:31:30 +0200 [thread overview]
Message-ID: <20190830073130.GA10471@lst.de> (raw)
In-Reply-To: <20190830071718.16613-4-baolu.lu@linux.intel.com>
On Fri, Aug 30, 2019 at 03:17:14PM +0800, Lu Baolu wrote:
> +#include <linux/pci.h>
> + if (dev_is_untrusted(hwdev) && zero_size)
> + memset(zero_addr, 0, zero_size);
As said before swiotlb must not grow pci dependencies like this.
Please move the untrusted flag to struct device.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Christoph Hellwig <hch@lst.de>,
ashok.raj@intel.com, jacob.jun.pan@intel.com, alan.cox@intel.com,
kevin.tian@intel.com, mika.westerberg@linux.intel.com,
Ingo Molnar <mingo@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
pengfei.xu@intel.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 3/7] swiotlb: Zero out bounce buffer for untrusted device
Date: Fri, 30 Aug 2019 09:31:30 +0200 [thread overview]
Message-ID: <20190830073130.GA10471@lst.de> (raw)
In-Reply-To: <20190830071718.16613-4-baolu.lu@linux.intel.com>
On Fri, Aug 30, 2019 at 03:17:14PM +0800, Lu Baolu wrote:
> +#include <linux/pci.h>
> + if (dev_is_untrusted(hwdev) && zero_size)
> + memset(zero_addr, 0, zero_size);
As said before swiotlb must not grow pci dependencies like this.
Please move the untrusted flag to struct device.
next prev parent reply other threads:[~2019-08-30 7:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 7:17 [PATCH v8 0/7] iommu: Bounce page for untrusted devices Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 1/7] PCI: Add dev_is_untrusted helper Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 2/7] swiotlb: Split size parameter to map/unmap APIs Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 3/7] swiotlb: Zero out bounce buffer for untrusted device Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:31 ` Christoph Hellwig [this message]
2019-08-30 7:31 ` Christoph Hellwig
2019-09-02 1:58 ` Lu Baolu
2019-09-02 1:58 ` Lu Baolu
2019-09-02 7:26 ` Christoph Hellwig
2019-09-02 7:26 ` Christoph Hellwig
2019-08-30 7:17 ` [PATCH v8 4/7] iommu/vt-d: Check whether device requires bounce buffer Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 5/7] iommu/vt-d: Don't switch off swiotlb if bounce page is used Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 6/7] iommu/vt-d: Add trace events for device dma map/unmap Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 13:53 ` Steven Rostedt
2019-08-30 13:53 ` Steven Rostedt
2019-09-02 2:13 ` Lu Baolu
2019-09-02 2:13 ` Lu Baolu
2019-08-30 7:17 ` [PATCH v8 7/7] iommu/vt-d: Use bounce buffer for untrusted devices Lu Baolu
2019-08-30 7:17 ` Lu Baolu
2019-08-30 13:39 ` David Laight
2019-08-30 13:39 ` David Laight
2019-08-30 14:27 ` Robin Murphy
2019-08-30 14:27 ` Robin Murphy
2019-09-02 7:15 ` Lu Baolu
2019-09-02 7:15 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830073130.GA10471@lst.de \
--to=hch@lst.de \
--cc=alan.cox@intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@intel.com \
--cc=jgross@suse.com \
--cc=kevin.tian@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=pengfei.xu@intel.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.