[Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Sander Eikelenboom]

L.S.,

While testing xen-unstable, my AMD system crashes during early boot while loading microcode with an "Early fatal page fault".
Reverting commit de45e3ff37bb1602796054afabfa626ea5661c45 "microcode/amd: fix memory leak" fixes the boot issue.

At present I don't have my serial console stuff at hand, but if needed I can send the stacktrace tomorrow.

--
Sander

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Chao Gao]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Fri, Aug 30, 2019 at 01:04:54AM +0200, Sander Eikelenboom wrote:
>L.S.,
>
>While testing xen-unstable, my AMD system crashes during early boot while loading microcode with an "Early fatal page fault".
>Reverting commit de45e3ff37bb1602796054afabfa626ea5661c45 "microcode/amd: fix memory leak" fixes the boot issue.

Sorry for this inconvenience.

Could you apply the patch attached and try it again?

>
>At present I don't have my serial console stuff at hand, but if needed I can send the stacktrace tomorrow.
>

Yes. That would be helpful.

Thanks
Chao

[-- Attachment #2: check_mc_old.patch --]
[-- Type: text/x-diff, Size: 532 bytes --]

diff --git a/xen/arch/x86/microcode_amd.c b/xen/arch/x86/microcode_amd.c
index 3069784..9b74330 100644
--- a/xen/arch/x86/microcode_amd.c
+++ b/xen/arch/x86/microcode_amd.c
@@ -552,9 +552,12 @@ static int cpu_request_microcode(unsigned int cpu, const void *buf,
         mc_old = mc_amd;
     }
 
-    xfree(mc_old->mpb);
-    xfree(mc_old->equiv_cpu_table);
-    xfree(mc_old);
+    if ( mc_old )
+    {
+        xfree(mc_old->mpb);
+        xfree(mc_old->equiv_cpu_table);
+        xfree(mc_old);
+    }
 
   out:
 #if CONFIG_HVM

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Jan Beulich]

On 30.08.2019 04:09, Chao Gao wrote:
> On Fri, Aug 30, 2019 at 01:04:54AM +0200, Sander Eikelenboom wrote:
>> L.S.,
>>
>> While testing xen-unstable, my AMD system crashes during early boot while loading microcode with an "Early fatal page fault".
>> Reverting commit de45e3ff37bb1602796054afabfa626ea5661c45 "microcode/amd: fix memory leak" fixes the boot issue.
> 
> Sorry for this inconvenience.
> 
> Could you apply the patch attached and try it again?

I'm inclined to take this fix even without waiting for Sander's
feedback (and simply implying your S-o-b). Andrew - what do you
think?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Chao Gao]

On Fri, Aug 30, 2019 at 09:49:04AM +0200, Jan Beulich wrote:
>On 30.08.2019 04:09, Chao Gao wrote:
>> On Fri, Aug 30, 2019 at 01:04:54AM +0200, Sander Eikelenboom wrote:
>>> L.S.,
>>>
>>> While testing xen-unstable, my AMD system crashes during early boot while loading microcode with an "Early fatal page fault".
>>> Reverting commit de45e3ff37bb1602796054afabfa626ea5661c45 "microcode/amd: fix memory leak" fixes the boot issue.
>> 
>> Sorry for this inconvenience.
>> 
>> Could you apply the patch attached and try it again?
>
>I'm inclined to take this fix even without waiting for Sander's
>feedback (and simply implying your S-o-b).

Ack.

Thanks
Chao

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [Xen-unstable] boot crash while loading AMD microcode due to commit "microcode/amd: fix memory leak"

[Sander Eikelenboom]

On 30/08/2019 09:49, Jan Beulich wrote:
> On 30.08.2019 04:09, Chao Gao wrote:
>> On Fri, Aug 30, 2019 at 01:04:54AM +0200, Sander Eikelenboom wrote:
>>> L.S.,
>>>
>>> While testing xen-unstable, my AMD system crashes during early boot while loading microcode with an "Early fatal page fault".
>>> Reverting commit de45e3ff37bb1602796054afabfa626ea5661c45 "microcode/amd: fix memory leak" fixes the boot issue.
>>
>> Sorry for this inconvenience.
>>
>> Could you apply the patch attached and try it again?
> 
> I'm inclined to take this fix even without waiting for Sander's
> feedback (and simply implying your S-o-b). Andrew - what do you
> think?
> 
> Jan
> 

Just tested and it works for me, thanks!

--
Sander

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel