All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	Florian Fainelli <f.fainelli@gmail.com>,
	Lori Hikichi <lori.hikichi@broadcom.com>,
	Icarus Chau <icarus.chau@broadcom.com>,
	Shivaraj Shetty <sshetty1@broadcom.com>
Subject: Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability
Date: Sat, 31 Aug 2019 11:49:41 +0200	[thread overview]
Message-ID: <20190831094940.GA1138@kunai> (raw)
In-Reply-To: <3e70fa7e-de13-4edd-2e17-b7c56e91d220@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

Hi Ray,

> > With all the limitations in place, I wonder if it might be easier to
> > implement an smbus_xfer callback instead? What is left that makes this
> > controller more than SMBus and real I2C?
> > 
> 
> Right. But what is the implication of using smbus_xfer instead of
> master_xfer in our driver?
> 
> Does it mean it will break existing functions of the i2c app that our
> customers developed based on i2cdev (e.g., I2C_RDWR)?

If the customers uses I2C_RDWR (and it cannot be mapped to i2c_smbus_*
calls) then this is an indication that there is some I2C functionality
left which the HW can provide. I'd be interested which one, though.

> 
> 1) Does

Maybe you wanted to describe it here and it got accidently cut off?

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Lori Hikichi <lori.hikichi@broadcom.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Shivaraj Shetty <sshetty1@broadcom.com>,
	Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
	linux-kernel@vger.kernel.org,
	Icarus Chau <icarus.chau@broadcom.com>,
	Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability
Date: Sat, 31 Aug 2019 11:49:41 +0200	[thread overview]
Message-ID: <20190831094940.GA1138@kunai> (raw)
In-Reply-To: <3e70fa7e-de13-4edd-2e17-b7c56e91d220@broadcom.com>


[-- Attachment #1.1: Type: text/plain, Size: 781 bytes --]

Hi Ray,

> > With all the limitations in place, I wonder if it might be easier to
> > implement an smbus_xfer callback instead? What is left that makes this
> > controller more than SMBus and real I2C?
> > 
> 
> Right. But what is the implication of using smbus_xfer instead of
> master_xfer in our driver?
> 
> Does it mean it will break existing functions of the i2c app that our
> customers developed based on i2cdev (e.g., I2C_RDWR)?

If the customers uses I2C_RDWR (and it cannot be mapped to i2c_smbus_*
calls) then this is an indication that there is some I2C functionality
left which the HW can provide. I'd be interested which one, though.

> 
> 1) Does

Maybe you wanted to describe it here and it got accidently cut off?

Regards,

   Wolfram


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-08-31  9:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  4:09 [PATCH v1 1/1] i2c: iproc: Add i2c repeated start capability Rayagonda Kokatanur
2019-08-07  4:09 ` Rayagonda Kokatanur
2019-08-07  4:09 ` Rayagonda Kokatanur
2019-08-12 17:33 ` Ray Jui
2019-08-12 17:33   ` Ray Jui
2019-08-29 20:41   ` Wolfram Sang
2019-08-29 20:41     ` Wolfram Sang
2019-08-30 12:56 ` Wolfram Sang
2019-08-30 12:56   ` Wolfram Sang
2019-08-30 18:35   ` Ray Jui
2019-08-30 18:35     ` Ray Jui
2019-08-31  9:49     ` Wolfram Sang [this message]
2019-08-31  9:49       ` Wolfram Sang
2019-09-03 23:11       ` Ray Jui
2019-09-03 23:11         ` Ray Jui
2019-09-04 21:37         ` Wolfram Sang
2019-09-04 21:37           ` Wolfram Sang
2019-09-24 17:23           ` Ray Jui
2019-09-24 17:23             ` Ray Jui
2019-09-24 18:57             ` Wolfram Sang
2019-09-24 18:57               ` Wolfram Sang
2019-09-24 22:23               ` Ray Jui
2019-09-24 22:23                 ` Ray Jui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190831094940.GA1138@kunai \
    --to=wsa@the-dreams.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=icarus.chau@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lori.hikichi@broadcom.com \
    --cc=mark.rutland@arm.com \
    --cc=ray.jui@broadcom.com \
    --cc=rayagonda.kokatanur@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sshetty1@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.