From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>,
Cosmin-Gabriel Samoila <gabrielcsmo@gmail.com>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode
Date: Mon, 2 Sep 2019 16:52:18 +0100 [thread overview]
Message-ID: <20190902155218.GC5819@sirena.co.uk> (raw)
In-Reply-To: <CAEnQRZDmVoSkpf47mTHeEKodX9_x4Y_9EVrkS=ta4sWU8tD3Zw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1067 bytes --]
On Mon, Sep 02, 2019 at 04:35:56PM +0300, Daniel Baluta wrote:
> On Mon, Sep 2, 2019 at 3:42 PM Mark Brown <broonie@kernel.org> wrote:
> > This patch seems to do this unconditionally. This is fine for
> > configurations where the SoC is the only thing driving the bus but will
> > mean that for TDM configurations where something else also drives some
> > of the slots we'll end up with both devices driving simultaneously. The
> > safest thing would be to set this only if TDM isn't configured.
> I thought that the SAI IP is the single owner of the audio data lines,
> so even in TDM
> mode SAI IP (which is inside SoC) is the only one adding data on the bus.
> Now, you say that there could be two devices driving some of he masked
> slots right?
Doing that is the major point of TDM modes. It could even be another
SAI on the same bus.
> I'm not sure how to really figure out that SAI is running in TDM mode.
As a first approximation you could just check if set_tdm_slots() has
been called, it might still be the only device but it's a good first
guess.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Baluta <daniel.baluta@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Timur Tabi <timur@kernel.org>,
Cosmin-Gabriel Samoila <gabrielcsmo@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Cosmin-Gabriel Samoila <cosmin.samoila@nxp.com>
Subject: Re: [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode
Date: Mon, 2 Sep 2019 16:52:18 +0100 [thread overview]
Message-ID: <20190902155218.GC5819@sirena.co.uk> (raw)
In-Reply-To: <CAEnQRZDmVoSkpf47mTHeEKodX9_x4Y_9EVrkS=ta4sWU8tD3Zw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Mon, Sep 02, 2019 at 04:35:56PM +0300, Daniel Baluta wrote:
> On Mon, Sep 2, 2019 at 3:42 PM Mark Brown <broonie@kernel.org> wrote:
> > This patch seems to do this unconditionally. This is fine for
> > configurations where the SoC is the only thing driving the bus but will
> > mean that for TDM configurations where something else also drives some
> > of the slots we'll end up with both devices driving simultaneously. The
> > safest thing would be to set this only if TDM isn't configured.
> I thought that the SAI IP is the single owner of the audio data lines,
> so even in TDM
> mode SAI IP (which is inside SoC) is the only one adding data on the bus.
> Now, you say that there could be two devices driving some of he masked
> slots right?
Doing that is the major point of TDM modes. It could even be another
SAI on the same bus.
> I'm not sure how to really figure out that SAI is running in TDM mode.
As a first approximation you could just check if set_tdm_slots() has
been called, it might still be the only device but it's a good first
guess.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-02 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 22:55 [PATCH] ASoC: fsl_sai: Set SAI Channel Mode to Output Mode Daniel Baluta
2019-08-30 22:55 ` Daniel Baluta
2019-08-30 22:55 ` [alsa-devel] " Daniel Baluta
2019-09-01 19:49 ` Cosmin-Gabriel Samoila
2019-09-01 19:49 ` [alsa-devel] " Cosmin-Gabriel Samoila
2019-09-02 12:39 ` Mark Brown
2019-09-02 12:39 ` Mark Brown
2019-09-02 13:35 ` [alsa-devel] " Daniel Baluta
2019-09-02 13:35 ` Daniel Baluta
2019-09-02 15:52 ` Mark Brown [this message]
2019-09-02 15:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902155218.GC5819@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=gabrielcsmo@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.