From: Nathan Chancellor <natechancellor@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: fix uninitialized variable ret
Date: Tue, 03 Sep 2019 05:31:49 +0000 [thread overview]
Message-ID: <20190903053149.GA56440@archlinux-threadripper> (raw)
In-Reply-To: <20190830184644.15590-1-colin.king@canonical.com>
On Fri, Aug 30, 2019 at 07:46:44PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there are error return paths in ffsReadFile that
> exit via lable err_out that return and uninitialized error
> return in variable ret. Fix this by initializing ret to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: c48c9f7ff32b ("staging: exfat: add exfat filesystem code to staging")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Clang also warns about this:
drivers/staging/exfat/exfat_super.c:885:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (p_fs->dev_ejected)
^~~~~~~~~~~~~~~~~
drivers/staging/exfat/exfat_super.c:892:9: note: uninitialized use occurs here
return ret;
^~~
drivers/staging/exfat/exfat_super.c:885:2: note: remove the 'if' if its condition is always true
if (p_fs->dev_ejected)
^~~~~~~~~~~~~~~~~~~~~~
drivers/staging/exfat/exfat_super.c:776:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: fix uninitialized variable ret
Date: Mon, 2 Sep 2019 22:31:49 -0700 [thread overview]
Message-ID: <20190903053149.GA56440@archlinux-threadripper> (raw)
In-Reply-To: <20190830184644.15590-1-colin.king@canonical.com>
On Fri, Aug 30, 2019 at 07:46:44PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there are error return paths in ffsReadFile that
> exit via lable err_out that return and uninitialized error
> return in variable ret. Fix this by initializing ret to zero.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: c48c9f7ff32b ("staging: exfat: add exfat filesystem code to staging")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Clang also warns about this:
drivers/staging/exfat/exfat_super.c:885:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (p_fs->dev_ejected)
^~~~~~~~~~~~~~~~~
drivers/staging/exfat/exfat_super.c:892:9: note: uninitialized use occurs here
return ret;
^~~
drivers/staging/exfat/exfat_super.c:885:2: note: remove the 'if' if its condition is always true
if (p_fs->dev_ejected)
^~~~~~~~~~~~~~~~~~~~~~
drivers/staging/exfat/exfat_super.c:776:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
next prev parent reply other threads:[~2019-09-03 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:46 [PATCH] staging: exfat: fix uninitialized variable ret Colin King
2019-08-30 18:46 ` Colin King
2019-09-03 5:31 ` Nathan Chancellor [this message]
2019-09-03 5:31 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903053149.GA56440@archlinux-threadripper \
--to=natechancellor@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.