From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>,
bridge@lists.linux-foundation.org,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
Leonardo Bras <leonardo@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH v4 1/2] netfilter: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled
Date: Tue, 3 Sep 2019 21:48:09 +0200 [thread overview]
Message-ID: <20190903194809.GD13660@breakpoint.cc> (raw)
In-Reply-To: <20190903193155.v74ws47zcn6zrwpr@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > I was expecting we could find a way to handle this from br_netfilter
> > > alone itself.
> >
> > We can't because we support ipv6 fib lookups from the netdev family
> > as well.
> >
> > Alternative is to auto-accept ipv6 packets from the nf_tables eval loop,
> > but I think its worse.
>
> Could we add a restriction for nf_tables + br_netfilter + !ipv6. I
> mean, if this is an IPv6 packet, nf_tables is on and IPv6 module if
> off, then drop this packet?
We could do that from nft_do_chain_netdev().
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
Leonardo Bras <leonardo@linux.ibm.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 1/2] netfilter: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled
Date: Tue, 3 Sep 2019 21:48:09 +0200 [thread overview]
Message-ID: <20190903194809.GD13660@breakpoint.cc> (raw)
In-Reply-To: <20190903193155.v74ws47zcn6zrwpr@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > I was expecting we could find a way to handle this from br_netfilter
> > > alone itself.
> >
> > We can't because we support ipv6 fib lookups from the netdev family
> > as well.
> >
> > Alternative is to auto-accept ipv6 packets from the nf_tables eval loop,
> > but I think its worse.
>
> Could we add a restriction for nf_tables + br_netfilter + !ipv6. I
> mean, if this is an IPv6 packet, nf_tables is on and IPv6 module if
> off, then drop this packet?
We could do that from nft_do_chain_netdev().
next prev parent reply other threads:[~2019-09-03 19:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:13 [Bridge] [PATCH v4 0/2] Drop IPV6 packets if IPv6 is disabled on boot Leonardo Bras
2019-08-30 18:13 ` Leonardo Bras
2019-08-30 18:13 ` [Bridge] [PATCH v4 1/2] netfilter: Terminate rule eval if protocol=IPv6 and ipv6 module is disabled Leonardo Bras
2019-08-30 18:13 ` Leonardo Bras
2019-08-30 20:58 ` [Bridge] " Florian Westphal
2019-08-30 20:58 ` Florian Westphal
2019-09-03 16:46 ` [Bridge] " Leonardo Bras
2019-09-03 16:46 ` Leonardo Bras
2019-09-03 16:49 ` [Bridge] " Pablo Neira Ayuso
2019-09-03 16:49 ` Pablo Neira Ayuso
2019-09-03 16:56 ` [Bridge] " Leonardo Bras
2019-09-03 16:56 ` Leonardo Bras
2019-09-03 17:05 ` [Bridge] " Florian Westphal
2019-09-03 17:05 ` Florian Westphal
2019-09-03 19:31 ` [Bridge] " Pablo Neira Ayuso
2019-09-03 19:31 ` Pablo Neira Ayuso
2019-09-03 19:48 ` Florian Westphal [this message]
2019-09-03 19:48 ` Florian Westphal
2019-09-03 20:19 ` [Bridge] " Pablo Neira Ayuso
2019-09-03 20:19 ` Pablo Neira Ayuso
2019-09-03 20:35 ` [Bridge] " Florian Westphal
2019-09-03 20:35 ` Florian Westphal
2019-09-03 20:55 ` [Bridge] " Pablo Neira Ayuso
2019-09-03 20:55 ` Pablo Neira Ayuso
2019-09-03 20:55 ` [Bridge] " Pablo Neira Ayuso
2019-09-03 20:55 ` Pablo Neira Ayuso
2019-08-30 18:13 ` [Bridge] [PATCH v4 2/2] net: br_netfiler_hooks: Drops IPv6 packets if IPv6 module is not loaded Leonardo Bras
2019-08-30 18:13 ` Leonardo Bras
2019-08-30 20:55 ` [Bridge] " Florian Westphal
2019-08-30 20:55 ` Florian Westphal
2019-08-31 4:42 ` [Bridge] " Leonardo Bras
2019-08-31 4:42 ` Leonardo Bras
2019-08-31 8:43 ` [Bridge] " Florian Westphal
2019-08-31 8:43 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903194809.GD13660@breakpoint.cc \
--to=fw@strlen.de \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@netfilter.org \
--cc=leonardo@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pablo@netfilter.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.