* [PATCH] mm/balloon_compaction: suppress allocation warnings @ 2019-08-20 9:16 Nadav Amit 2019-08-21 16:05 ` David Hildenbrand 2019-08-21 16:05 ` David Hildenbrand 0 siblings, 2 replies; 16+ messages in thread From: Nadav Amit @ 2019-08-20 9:16 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Jason Wang, virtualization, linux-mm, linux-kernel, Nadav Amit There is no reason to print warnings when balloon page allocation fails, as they are expected and can be handled gracefully. Since VMware balloon now uses balloon-compaction infrastructure, and suppressed these warnings before, it is also beneficial to suppress these warnings to keep the same behavior that the balloon had before. Cc: Jason Wang <jasowang@redhat.com> Signed-off-by: Nadav Amit <namit@vmware.com> --- mm/balloon_compaction.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 798275a51887..26de020aae7b 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -124,7 +124,8 @@ EXPORT_SYMBOL_GPL(balloon_page_list_dequeue); struct page *balloon_page_alloc(void) { struct page *page = alloc_page(balloon_mapping_gfp_mask() | - __GFP_NOMEMALLOC | __GFP_NORETRY); + __GFP_NOMEMALLOC | __GFP_NORETRY | + __GFP_NOWARN); return page; } EXPORT_SYMBOL_GPL(balloon_page_alloc); -- 2.19.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-20 9:16 [PATCH] mm/balloon_compaction: suppress allocation warnings Nadav Amit @ 2019-08-21 16:05 ` David Hildenbrand 2019-08-21 16:23 ` Nadav Amit 2019-08-21 16:05 ` David Hildenbrand 1 sibling, 1 reply; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 16:05 UTC (permalink / raw) To: Nadav Amit, Michael S. Tsirkin Cc: Jason Wang, virtualization, linux-mm, linux-kernel On 20.08.19 11:16, Nadav Amit wrote: > There is no reason to print warnings when balloon page allocation fails, > as they are expected and can be handled gracefully. Since VMware > balloon now uses balloon-compaction infrastructure, and suppressed these > warnings before, it is also beneficial to suppress these warnings to > keep the same behavior that the balloon had before. I am not sure if that's a good idea. The allocation warnings are usually the only trace of "the user/admin did something bad because he/she tried to inflate the balloon to an unsafe value". Believe me, I processed a couple of such bugreports related to virtio-balloon and the warning were very helpful for that. > > Cc: Jason Wang <jasowang@redhat.com> > Signed-off-by: Nadav Amit <namit@vmware.com> > --- > mm/balloon_compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 798275a51887..26de020aae7b 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -124,7 +124,8 @@ EXPORT_SYMBOL_GPL(balloon_page_list_dequeue); > struct page *balloon_page_alloc(void) > { > struct page *page = alloc_page(balloon_mapping_gfp_mask() | > - __GFP_NOMEMALLOC | __GFP_NORETRY); > + __GFP_NOMEMALLOC | __GFP_NORETRY | > + __GFP_NOWARN); > return page; > } > EXPORT_SYMBOL_GPL(balloon_page_alloc); > -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:05 ` David Hildenbrand @ 2019-08-21 16:23 ` Nadav Amit 0 siblings, 0 replies; 16+ messages in thread From: Nadav Amit via Virtualization @ 2019-08-21 16:23 UTC (permalink / raw) To: David Hildenbrand Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Michael S. Tsirkin > On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: > > On 20.08.19 11:16, Nadav Amit wrote: >> There is no reason to print warnings when balloon page allocation fails, >> as they are expected and can be handled gracefully. Since VMware >> balloon now uses balloon-compaction infrastructure, and suppressed these >> warnings before, it is also beneficial to suppress these warnings to >> keep the same behavior that the balloon had before. > > I am not sure if that's a good idea. The allocation warnings are usually > the only trace of "the user/admin did something bad because he/she tried > to inflate the balloon to an unsafe value". Believe me, I processed a > couple of such bugreports related to virtio-balloon and the warning were > very helpful for that. Ok, so a message is needed, but does it have to be a generic frightening warning? How about using __GFP_NOWARN, and if allocation do something like: pr_warn(“Balloon memory allocation failed”); Or even something more informative? This would surely be less intimidating for common users. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings @ 2019-08-21 16:23 ` Nadav Amit 0 siblings, 0 replies; 16+ messages in thread From: Nadav Amit @ 2019-08-21 16:23 UTC (permalink / raw) To: David Hildenbrand Cc: Michael S. Tsirkin, Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org > On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: > > On 20.08.19 11:16, Nadav Amit wrote: >> There is no reason to print warnings when balloon page allocation fails, >> as they are expected and can be handled gracefully. Since VMware >> balloon now uses balloon-compaction infrastructure, and suppressed these >> warnings before, it is also beneficial to suppress these warnings to >> keep the same behavior that the balloon had before. > > I am not sure if that's a good idea. The allocation warnings are usually > the only trace of "the user/admin did something bad because he/she tried > to inflate the balloon to an unsafe value". Believe me, I processed a > couple of such bugreports related to virtio-balloon and the warning were > very helpful for that. Ok, so a message is needed, but does it have to be a generic frightening warning? How about using __GFP_NOWARN, and if allocation do something like: pr_warn(“Balloon memory allocation failed”); Or even something more informative? This would surely be less intimidating for common users. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:23 ` Nadav Amit (?) @ 2019-08-21 16:29 ` David Hildenbrand -1 siblings, 0 replies; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 16:29 UTC (permalink / raw) To: Nadav Amit Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Michael S. Tsirkin On 21.08.19 18:23, Nadav Amit wrote: >> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >> >> On 20.08.19 11:16, Nadav Amit wrote: >>> There is no reason to print warnings when balloon page allocation fails, >>> as they are expected and can be handled gracefully. Since VMware >>> balloon now uses balloon-compaction infrastructure, and suppressed these >>> warnings before, it is also beneficial to suppress these warnings to >>> keep the same behavior that the balloon had before. >> >> I am not sure if that's a good idea. The allocation warnings are usually >> the only trace of "the user/admin did something bad because he/she tried >> to inflate the balloon to an unsafe value". Believe me, I processed a >> couple of such bugreports related to virtio-balloon and the warning were >> very helpful for that. > > Ok, so a message is needed, but does it have to be a generic frightening > warning? > > How about using __GFP_NOWARN, and if allocation do something like: > > pr_warn(“Balloon memory allocation failed”); > > Or even something more informative? This would surely be less intimidating > for common users. > ratelimit would make sense :) And yes, this would certainly be nicer. -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:23 ` Nadav Amit (?) (?) @ 2019-08-21 16:29 ` David Hildenbrand 2019-08-21 16:34 ` Nadav Amit 2019-08-21 16:34 ` Nadav Amit via Virtualization -1 siblings, 2 replies; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 16:29 UTC (permalink / raw) To: Nadav Amit Cc: Michael S. Tsirkin, Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On 21.08.19 18:23, Nadav Amit wrote: >> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >> >> On 20.08.19 11:16, Nadav Amit wrote: >>> There is no reason to print warnings when balloon page allocation fails, >>> as they are expected and can be handled gracefully. Since VMware >>> balloon now uses balloon-compaction infrastructure, and suppressed these >>> warnings before, it is also beneficial to suppress these warnings to >>> keep the same behavior that the balloon had before. >> >> I am not sure if that's a good idea. The allocation warnings are usually >> the only trace of "the user/admin did something bad because he/she tried >> to inflate the balloon to an unsafe value". Believe me, I processed a >> couple of such bugreports related to virtio-balloon and the warning were >> very helpful for that. > > Ok, so a message is needed, but does it have to be a generic frightening > warning? > > How about using __GFP_NOWARN, and if allocation do something like: > > pr_warn(“Balloon memory allocation failed”); > > Or even something more informative? This would surely be less intimidating > for common users. > ratelimit would make sense :) And yes, this would certainly be nicer. -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:29 ` David Hildenbrand @ 2019-08-21 16:34 ` Nadav Amit 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 16:34 ` Nadav Amit via Virtualization 1 sibling, 2 replies; 16+ messages in thread From: Nadav Amit @ 2019-08-21 16:34 UTC (permalink / raw) To: David Hildenbrand Cc: Michael S. Tsirkin, Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org > On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: > > On 21.08.19 18:23, Nadav Amit wrote: >>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>> >>> On 20.08.19 11:16, Nadav Amit wrote: >>>> There is no reason to print warnings when balloon page allocation fails, >>>> as they are expected and can be handled gracefully. Since VMware >>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>> warnings before, it is also beneficial to suppress these warnings to >>>> keep the same behavior that the balloon had before. >>> >>> I am not sure if that's a good idea. The allocation warnings are usually >>> the only trace of "the user/admin did something bad because he/she tried >>> to inflate the balloon to an unsafe value". Believe me, I processed a >>> couple of such bugreports related to virtio-balloon and the warning were >>> very helpful for that. >> >> Ok, so a message is needed, but does it have to be a generic frightening >> warning? >> >> How about using __GFP_NOWARN, and if allocation do something like: >> >> pr_warn(“Balloon memory allocation failed”); >> >> Or even something more informative? This would surely be less intimidating >> for common users. > > ratelimit would make sense :) > > And yes, this would certainly be nicer. Thanks. I will post v2 of the patch. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:34 ` Nadav Amit @ 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 19:13 ` David Hildenbrand 1 sibling, 0 replies; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 19:13 UTC (permalink / raw) To: Nadav Amit Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Michael S. Tsirkin On 21.08.19 18:34, Nadav Amit wrote: >> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: >> >> On 21.08.19 18:23, Nadav Amit wrote: >>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>>> >>>> On 20.08.19 11:16, Nadav Amit wrote: >>>>> There is no reason to print warnings when balloon page allocation fails, >>>>> as they are expected and can be handled gracefully. Since VMware >>>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>>> warnings before, it is also beneficial to suppress these warnings to >>>>> keep the same behavior that the balloon had before. >>>> >>>> I am not sure if that's a good idea. The allocation warnings are usually >>>> the only trace of "the user/admin did something bad because he/she tried >>>> to inflate the balloon to an unsafe value". Believe me, I processed a >>>> couple of such bugreports related to virtio-balloon and the warning were >>>> very helpful for that. >>> >>> Ok, so a message is needed, but does it have to be a generic frightening >>> warning? >>> >>> How about using __GFP_NOWARN, and if allocation do something like: >>> >>> pr_warn(“Balloon memory allocation failed”); >>> >>> Or even something more informative? This would surely be less intimidating >>> for common users. >> >> ratelimit would make sense :) >> >> And yes, this would certainly be nicer. > > Thanks. I will post v2 of the patch. > As discussed in v2, we already print a warning in virtio-balloon, so I am fine with this patch. Reviewed-by: David Hildenbrand <david@redhat.com> -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:34 ` Nadav Amit 2019-08-21 19:13 ` David Hildenbrand @ 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 19:44 ` Nadav Amit 1 sibling, 1 reply; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 19:13 UTC (permalink / raw) To: Nadav Amit Cc: Michael S. Tsirkin, Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On 21.08.19 18:34, Nadav Amit wrote: >> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: >> >> On 21.08.19 18:23, Nadav Amit wrote: >>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>>> >>>> On 20.08.19 11:16, Nadav Amit wrote: >>>>> There is no reason to print warnings when balloon page allocation fails, >>>>> as they are expected and can be handled gracefully. Since VMware >>>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>>> warnings before, it is also beneficial to suppress these warnings to >>>>> keep the same behavior that the balloon had before. >>>> >>>> I am not sure if that's a good idea. The allocation warnings are usually >>>> the only trace of "the user/admin did something bad because he/she tried >>>> to inflate the balloon to an unsafe value". Believe me, I processed a >>>> couple of such bugreports related to virtio-balloon and the warning were >>>> very helpful for that. >>> >>> Ok, so a message is needed, but does it have to be a generic frightening >>> warning? >>> >>> How about using __GFP_NOWARN, and if allocation do something like: >>> >>> pr_warn(“Balloon memory allocation failed”); >>> >>> Or even something more informative? This would surely be less intimidating >>> for common users. >> >> ratelimit would make sense :) >> >> And yes, this would certainly be nicer. > > Thanks. I will post v2 of the patch. > As discussed in v2, we already print a warning in virtio-balloon, so I am fine with this patch. Reviewed-by: David Hildenbrand <david@redhat.com> -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 19:13 ` David Hildenbrand @ 2019-08-21 19:44 ` Nadav Amit 0 siblings, 0 replies; 16+ messages in thread From: Nadav Amit via Virtualization @ 2019-08-21 19:44 UTC (permalink / raw) To: Michael S. Tsirkin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org > On Aug 21, 2019, at 12:13 PM, David Hildenbrand <david@redhat.com> wrote: > > On 21.08.19 18:34, Nadav Amit wrote: >>> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: >>> >>> On 21.08.19 18:23, Nadav Amit wrote: >>>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>>>> >>>>> On 20.08.19 11:16, Nadav Amit wrote: >>>>>> There is no reason to print warnings when balloon page allocation fails, >>>>>> as they are expected and can be handled gracefully. Since VMware >>>>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>>>> warnings before, it is also beneficial to suppress these warnings to >>>>>> keep the same behavior that the balloon had before. >>>>> >>>>> I am not sure if that's a good idea. The allocation warnings are usually >>>>> the only trace of "the user/admin did something bad because he/she tried >>>>> to inflate the balloon to an unsafe value". Believe me, I processed a >>>>> couple of such bugreports related to virtio-balloon and the warning were >>>>> very helpful for that. >>>> >>>> Ok, so a message is needed, but does it have to be a generic frightening >>>> warning? >>>> >>>> How about using __GFP_NOWARN, and if allocation do something like: >>>> >>>> pr_warn(“Balloon memory allocation failed”); >>>> >>>> Or even something more informative? This would surely be less intimidating >>>> for common users. >>> >>> ratelimit would make sense :) >>> >>> And yes, this would certainly be nicer. >> >> Thanks. I will post v2 of the patch. > > As discussed in v2, we already print a warning in virtio-balloon, so I > am fine with this patch. > > Reviewed-by: David Hildenbrand <david@redhat.com> Michael, If it is possible to get it to 5.3, to avoid behavioral change for VMware balloon users, it would be great. Thanks, Nadav _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings @ 2019-08-21 19:44 ` Nadav Amit 0 siblings, 0 replies; 16+ messages in thread From: Nadav Amit @ 2019-08-21 19:44 UTC (permalink / raw) To: Michael S. Tsirkin Cc: Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand > On Aug 21, 2019, at 12:13 PM, David Hildenbrand <david@redhat.com> wrote: > > On 21.08.19 18:34, Nadav Amit wrote: >>> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: >>> >>> On 21.08.19 18:23, Nadav Amit wrote: >>>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>>>> >>>>> On 20.08.19 11:16, Nadav Amit wrote: >>>>>> There is no reason to print warnings when balloon page allocation fails, >>>>>> as they are expected and can be handled gracefully. Since VMware >>>>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>>>> warnings before, it is also beneficial to suppress these warnings to >>>>>> keep the same behavior that the balloon had before. >>>>> >>>>> I am not sure if that's a good idea. The allocation warnings are usually >>>>> the only trace of "the user/admin did something bad because he/she tried >>>>> to inflate the balloon to an unsafe value". Believe me, I processed a >>>>> couple of such bugreports related to virtio-balloon and the warning were >>>>> very helpful for that. >>>> >>>> Ok, so a message is needed, but does it have to be a generic frightening >>>> warning? >>>> >>>> How about using __GFP_NOWARN, and if allocation do something like: >>>> >>>> pr_warn(“Balloon memory allocation failed”); >>>> >>>> Or even something more informative? This would surely be less intimidating >>>> for common users. >>> >>> ratelimit would make sense :) >>> >>> And yes, this would certainly be nicer. >> >> Thanks. I will post v2 of the patch. > > As discussed in v2, we already print a warning in virtio-balloon, so I > am fine with this patch. > > Reviewed-by: David Hildenbrand <david@redhat.com> Michael, If it is possible to get it to 5.3, to avoid behavioral change for VMware balloon users, it would be great. Thanks, Nadav ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 19:44 ` Nadav Amit (?) @ 2019-09-04 10:37 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2019-09-04 10:37 UTC (permalink / raw) To: Nadav Amit Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org On Wed, Aug 21, 2019 at 07:44:33PM +0000, Nadav Amit wrote: > > On Aug 21, 2019, at 12:13 PM, David Hildenbrand <david@redhat.com> wrote: > > > > On 21.08.19 18:34, Nadav Amit wrote: > >>> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: > >>> > >>> On 21.08.19 18:23, Nadav Amit wrote: > >>>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: > >>>>> > >>>>> On 20.08.19 11:16, Nadav Amit wrote: > >>>>>> There is no reason to print warnings when balloon page allocation fails, > >>>>>> as they are expected and can be handled gracefully. Since VMware > >>>>>> balloon now uses balloon-compaction infrastructure, and suppressed these > >>>>>> warnings before, it is also beneficial to suppress these warnings to > >>>>>> keep the same behavior that the balloon had before. > >>>>> > >>>>> I am not sure if that's a good idea. The allocation warnings are usually > >>>>> the only trace of "the user/admin did something bad because he/she tried > >>>>> to inflate the balloon to an unsafe value". Believe me, I processed a > >>>>> couple of such bugreports related to virtio-balloon and the warning were > >>>>> very helpful for that. > >>>> > >>>> Ok, so a message is needed, but does it have to be a generic frightening > >>>> warning? > >>>> > >>>> How about using __GFP_NOWARN, and if allocation do something like: > >>>> > >>>> pr_warn(“Balloon memory allocation failed”); > >>>> > >>>> Or even something more informative? This would surely be less intimidating > >>>> for common users. > >>> > >>> ratelimit would make sense :) > >>> > >>> And yes, this would certainly be nicer. > >> > >> Thanks. I will post v2 of the patch. > > > > As discussed in v2, we already print a warning in virtio-balloon, so I > > am fine with this patch. > > > > Reviewed-by: David Hildenbrand <david@redhat.com> > > Michael, > > If it is possible to get it to 5.3, to avoid behavioral change for VMware > balloon users, it would be great. > > Thanks, > Nadav Just back from vacation, I'll try. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 19:44 ` Nadav Amit (?) (?) @ 2019-09-04 10:37 ` Michael S. Tsirkin -1 siblings, 0 replies; 16+ messages in thread From: Michael S. Tsirkin @ 2019-09-04 10:37 UTC (permalink / raw) To: Nadav Amit Cc: Jason Wang, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand On Wed, Aug 21, 2019 at 07:44:33PM +0000, Nadav Amit wrote: > > On Aug 21, 2019, at 12:13 PM, David Hildenbrand <david@redhat.com> wrote: > > > > On 21.08.19 18:34, Nadav Amit wrote: > >>> On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: > >>> > >>> On 21.08.19 18:23, Nadav Amit wrote: > >>>>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: > >>>>> > >>>>> On 20.08.19 11:16, Nadav Amit wrote: > >>>>>> There is no reason to print warnings when balloon page allocation fails, > >>>>>> as they are expected and can be handled gracefully. Since VMware > >>>>>> balloon now uses balloon-compaction infrastructure, and suppressed these > >>>>>> warnings before, it is also beneficial to suppress these warnings to > >>>>>> keep the same behavior that the balloon had before. > >>>>> > >>>>> I am not sure if that's a good idea. The allocation warnings are usually > >>>>> the only trace of "the user/admin did something bad because he/she tried > >>>>> to inflate the balloon to an unsafe value". Believe me, I processed a > >>>>> couple of such bugreports related to virtio-balloon and the warning were > >>>>> very helpful for that. > >>>> > >>>> Ok, so a message is needed, but does it have to be a generic frightening > >>>> warning? > >>>> > >>>> How about using __GFP_NOWARN, and if allocation do something like: > >>>> > >>>> pr_warn(“Balloon memory allocation failed”); > >>>> > >>>> Or even something more informative? This would surely be less intimidating > >>>> for common users. > >>> > >>> ratelimit would make sense :) > >>> > >>> And yes, this would certainly be nicer. > >> > >> Thanks. I will post v2 of the patch. > > > > As discussed in v2, we already print a warning in virtio-balloon, so I > > am fine with this patch. > > > > Reviewed-by: David Hildenbrand <david@redhat.com> > > Michael, > > If it is possible to get it to 5.3, to avoid behavioral change for VMware > balloon users, it would be great. > > Thanks, > Nadav Just back from vacation, I'll try. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-21 16:29 ` David Hildenbrand 2019-08-21 16:34 ` Nadav Amit @ 2019-08-21 16:34 ` Nadav Amit via Virtualization 1 sibling, 0 replies; 16+ messages in thread From: Nadav Amit via Virtualization @ 2019-08-21 16:34 UTC (permalink / raw) To: David Hildenbrand Cc: linux-mm@kvack.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Michael S. Tsirkin > On Aug 21, 2019, at 9:29 AM, David Hildenbrand <david@redhat.com> wrote: > > On 21.08.19 18:23, Nadav Amit wrote: >>> On Aug 21, 2019, at 9:05 AM, David Hildenbrand <david@redhat.com> wrote: >>> >>> On 20.08.19 11:16, Nadav Amit wrote: >>>> There is no reason to print warnings when balloon page allocation fails, >>>> as they are expected and can be handled gracefully. Since VMware >>>> balloon now uses balloon-compaction infrastructure, and suppressed these >>>> warnings before, it is also beneficial to suppress these warnings to >>>> keep the same behavior that the balloon had before. >>> >>> I am not sure if that's a good idea. The allocation warnings are usually >>> the only trace of "the user/admin did something bad because he/she tried >>> to inflate the balloon to an unsafe value". Believe me, I processed a >>> couple of such bugreports related to virtio-balloon and the warning were >>> very helpful for that. >> >> Ok, so a message is needed, but does it have to be a generic frightening >> warning? >> >> How about using __GFP_NOWARN, and if allocation do something like: >> >> pr_warn(“Balloon memory allocation failed”); >> >> Or even something more informative? This would surely be less intimidating >> for common users. > > ratelimit would make sense :) > > And yes, this would certainly be nicer. Thanks. I will post v2 of the patch. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mm/balloon_compaction: suppress allocation warnings 2019-08-20 9:16 [PATCH] mm/balloon_compaction: suppress allocation warnings Nadav Amit 2019-08-21 16:05 ` David Hildenbrand @ 2019-08-21 16:05 ` David Hildenbrand 1 sibling, 0 replies; 16+ messages in thread From: David Hildenbrand @ 2019-08-21 16:05 UTC (permalink / raw) To: Nadav Amit, Michael S. Tsirkin; +Cc: linux-mm, linux-kernel, virtualization On 20.08.19 11:16, Nadav Amit wrote: > There is no reason to print warnings when balloon page allocation fails, > as they are expected and can be handled gracefully. Since VMware > balloon now uses balloon-compaction infrastructure, and suppressed these > warnings before, it is also beneficial to suppress these warnings to > keep the same behavior that the balloon had before. I am not sure if that's a good idea. The allocation warnings are usually the only trace of "the user/admin did something bad because he/she tried to inflate the balloon to an unsafe value". Believe me, I processed a couple of such bugreports related to virtio-balloon and the warning were very helpful for that. > > Cc: Jason Wang <jasowang@redhat.com> > Signed-off-by: Nadav Amit <namit@vmware.com> > --- > mm/balloon_compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c > index 798275a51887..26de020aae7b 100644 > --- a/mm/balloon_compaction.c > +++ b/mm/balloon_compaction.c > @@ -124,7 +124,8 @@ EXPORT_SYMBOL_GPL(balloon_page_list_dequeue); > struct page *balloon_page_alloc(void) > { > struct page *page = alloc_page(balloon_mapping_gfp_mask() | > - __GFP_NOMEMALLOC | __GFP_NORETRY); > + __GFP_NOMEMALLOC | __GFP_NORETRY | > + __GFP_NOWARN); > return page; > } > EXPORT_SYMBOL_GPL(balloon_page_alloc); > -- Thanks, David / dhildenb ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mm/balloon_compaction: suppress allocation warnings @ 2019-08-20 9:16 Nadav Amit via Virtualization 0 siblings, 0 replies; 16+ messages in thread From: Nadav Amit via Virtualization @ 2019-08-20 9:16 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-mm, Nadav Amit, linux-kernel, virtualization There is no reason to print warnings when balloon page allocation fails, as they are expected and can be handled gracefully. Since VMware balloon now uses balloon-compaction infrastructure, and suppressed these warnings before, it is also beneficial to suppress these warnings to keep the same behavior that the balloon had before. Cc: Jason Wang <jasowang@redhat.com> Signed-off-by: Nadav Amit <namit@vmware.com> --- mm/balloon_compaction.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 798275a51887..26de020aae7b 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -124,7 +124,8 @@ EXPORT_SYMBOL_GPL(balloon_page_list_dequeue); struct page *balloon_page_alloc(void) { struct page *page = alloc_page(balloon_mapping_gfp_mask() | - __GFP_NOMEMALLOC | __GFP_NORETRY); + __GFP_NOMEMALLOC | __GFP_NORETRY | + __GFP_NOWARN); return page; } EXPORT_SYMBOL_GPL(balloon_page_alloc); -- 2.19.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2019-09-04 10:37 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-20 9:16 [PATCH] mm/balloon_compaction: suppress allocation warnings Nadav Amit 2019-08-21 16:05 ` David Hildenbrand 2019-08-21 16:23 ` Nadav Amit via Virtualization 2019-08-21 16:23 ` Nadav Amit 2019-08-21 16:29 ` David Hildenbrand 2019-08-21 16:29 ` David Hildenbrand 2019-08-21 16:34 ` Nadav Amit 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 19:13 ` David Hildenbrand 2019-08-21 19:44 ` Nadav Amit via Virtualization 2019-08-21 19:44 ` Nadav Amit 2019-09-04 10:37 ` Michael S. Tsirkin 2019-09-04 10:37 ` Michael S. Tsirkin 2019-08-21 16:34 ` Nadav Amit via Virtualization 2019-08-21 16:05 ` David Hildenbrand -- strict thread matches above, loose matches on Subject: below -- 2019-08-20 9:16 Nadav Amit via Virtualization
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.