From: Dave Martin <Dave.Martin@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kselftest@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, shuah@kernel.org,
amit.kachhap@arm.com, andreyknvl@google.com
Subject: Re: [PATCH v5 00/11] Add arm64/signal initial kselftest support
Date: Wed, 4 Sep 2019 12:47:22 +0100 [thread overview]
Message-ID: <20190904114722.GQ27757@arm.com> (raw)
In-Reply-To: <20190902112932.36129-1-cristian.marussi@arm.com>
On Mon, Sep 02, 2019 at 12:29:21pm +0100, Cristian Marussi wrote:
> Hi
>
> this patchset aims to add the initial arch-specific arm64 support to
> kselftest starting with signals-related test-cases.
> A common internal test-case layout is proposed which then it is anyway
> wired-up to the toplevel kselftest Makefile, so that it should be possible
> at the end to run it on an arm64 target in the usual way with KSFT.
BTW, it's helpful to state the base branch / commit as clearly as
possible near the top of the cover letter, say,
--8<--
This series is based on arm64/for-next/core [1]
commit 9ce1263033cd ("selftests, arm64: add a selftest for passing tagged pointers to kernel")
[1] git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
-->8--
This is particularly important if you expect the maintainer to pick up
the patches.
You don't need to reference a specific commit unless there's a
significant chance of conflicts if the wrong commit is used, but it can
help provide a clue as to why you're basing on this alternate branch.
> ~/linux# make TARGETS=arm64 kselftest
>
> New KSFT arm64 testcases live inside tools/testing/selftests/arm64 grouped by
> family inside subdirectories: arm64/signal is the first family proposed with
> this series.
> This series converts also to this subdirectory scheme the pre-existing
> (already queued on arm64/for-next/core) KSFT arm64 tags tests, moving them
> into arm64/tags.
>
> Thanks
>
> Cristian
>
>
> Notes:
> -----
> - further details in the included READMEs
>
> - more tests still to be written (current strategy is going through the related
> Kernel signal-handling code and write a test for each possible and sensible code-path)
> A few ideas for more TODO testcases:
> - fake_sigreturn_unmapped_sp: SP into unmapped addrs
> - fake_sigreturn_kernelspace_sp: SP into kernel addrs
> - fake_sigreturn_sve_bad_extra_context: SVE extra context badly formed
> - mangle_sve_invalid_extra_context: SVE extra_context invalid
>
> - SVE signal testcases and special handling will be part of an additional patch
> still to be released
What's your approach to checking that the test failure paths work?
We could either hack the kernel or the tests to provoke "fake" failures,
and I don't think it's necessary to test everything in this way,
providing we have confidence that the test strategy and framework works
in general.
[...]
Cheers
---Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 00/11] Add arm64/signal initial kselftest support
Date: Wed, 4 Sep 2019 12:47:22 +0100 [thread overview]
Message-ID: <20190904114722.GQ27757@arm.com> (raw)
In-Reply-To: <20190902112932.36129-1-cristian.marussi@arm.com>
On Mon, Sep 02, 2019 at 12:29:21pm +0100, Cristian Marussi wrote:
> Hi
>
> this patchset aims to add the initial arch-specific arm64 support to
> kselftest starting with signals-related test-cases.
> A common internal test-case layout is proposed which then it is anyway
> wired-up to the toplevel kselftest Makefile, so that it should be possible
> at the end to run it on an arm64 target in the usual way with KSFT.
BTW, it's helpful to state the base branch / commit as clearly as
possible near the top of the cover letter, say,
--8<--
This series is based on arm64/for-next/core [1]
commit 9ce1263033cd ("selftests, arm64: add a selftest for passing tagged pointers to kernel")
[1] git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
-->8--
This is particularly important if you expect the maintainer to pick up
the patches.
You don't need to reference a specific commit unless there's a
significant chance of conflicts if the wrong commit is used, but it can
help provide a clue as to why you're basing on this alternate branch.
> ~/linux# make TARGETS=arm64 kselftest
>
> New KSFT arm64 testcases live inside tools/testing/selftests/arm64 grouped by
> family inside subdirectories: arm64/signal is the first family proposed with
> this series.
> This series converts also to this subdirectory scheme the pre-existing
> (already queued on arm64/for-next/core) KSFT arm64 tags tests, moving them
> into arm64/tags.
>
> Thanks
>
> Cristian
>
>
> Notes:
> -----
> - further details in the included READMEs
>
> - more tests still to be written (current strategy is going through the related
> Kernel signal-handling code and write a test for each possible and sensible code-path)
> A few ideas for more TODO testcases:
> - fake_sigreturn_unmapped_sp: SP into unmapped addrs
> - fake_sigreturn_kernelspace_sp: SP into kernel addrs
> - fake_sigreturn_sve_bad_extra_context: SVE extra context badly formed
> - mangle_sve_invalid_extra_context: SVE extra_context invalid
>
> - SVE signal testcases and special handling will be part of an additional patch
> still to be released
What's your approach to checking that the test failure paths work?
We could either hack the kernel or the tests to provoke "fake" failures,
and I don't think it's necessary to test everything in this way,
providing we have confidence that the test strategy and framework works
in general.
[...]
Cheers
---Dave
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-04 11:47 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:29 [PATCH v5 00/11] Add arm64/signal initial kselftest support Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 01/11] kselftest: arm64: add skeleton Makefile Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-03 9:26 ` Amit Kachhap
2019-09-03 9:26 ` Amit Kachhap
2019-09-03 9:45 ` Cristian Marussi
2019-09-03 9:45 ` Cristian Marussi
2019-09-05 17:57 ` Cristian Marussi
2019-09-05 17:57 ` Cristian Marussi
2019-09-09 12:42 ` Amit Kachhap
2019-09-09 12:42 ` Amit Kachhap
2019-09-16 11:41 ` Dave Martin
2019-09-16 11:41 ` Dave Martin
2019-09-04 11:47 ` Dave Martin
2019-09-04 11:47 ` Dave Martin
2019-09-05 13:45 ` Cristian Marussi
2019-09-05 13:45 ` Cristian Marussi
2019-09-05 14:18 ` Dave Martin
2019-09-05 14:18 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 02/11] kselftest: arm64: add common utils and one testcase Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:47 ` Dave Martin
2019-09-04 11:47 ` Dave Martin
2019-09-06 10:26 ` Cristian Marussi
2019-09-06 10:26 ` Cristian Marussi
2019-09-16 11:40 ` Dave Martin
2019-09-16 11:40 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 03/11] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-04 11:48 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 04/11] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-04 11:48 ` Dave Martin
2019-09-02 11:29 ` [PATCH v5 05/11] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-04 11:48 ` Dave Martin
2019-09-09 15:51 ` Cristian Marussi
2019-09-09 15:51 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 06/11] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:48 ` Dave Martin
2019-09-04 11:48 ` Dave Martin
2019-09-09 17:31 ` Cristian Marussi
2019-09-09 17:31 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 07/11] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-04 11:49 ` Dave Martin
2019-09-09 17:47 ` Cristian Marussi
2019-09-09 17:47 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 08/11] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-04 11:49 ` Dave Martin
2019-09-09 17:51 ` Cristian Marussi
2019-09-09 17:51 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-04 11:49 ` Dave Martin
2019-09-05 12:15 ` Cristian Marussi
2019-09-05 12:15 ` Cristian Marussi
2019-09-05 12:39 ` Dave Martin
2019-09-05 12:39 ` Dave Martin
2019-09-05 13:32 ` Cristian Marussi
2019-09-05 13:32 ` Cristian Marussi
2019-09-05 14:20 ` Dave Martin
2019-09-05 14:20 ` Dave Martin
2019-09-09 18:03 ` Cristian Marussi
2019-09-09 18:03 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 10/11] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-04 11:49 ` Dave Martin
2019-09-09 18:11 ` Cristian Marussi
2019-09-09 18:11 ` Cristian Marussi
2019-09-02 11:29 ` [PATCH v5 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi
2019-09-02 11:29 ` Cristian Marussi
2019-09-04 11:49 ` Dave Martin
2019-09-04 11:49 ` Dave Martin
2019-09-09 18:32 ` Cristian Marussi
2019-09-09 18:32 ` Cristian Marussi
2019-09-04 11:47 ` Dave Martin [this message]
2019-09-04 11:47 ` [PATCH v5 00/11] Add arm64/signal initial kselftest support Dave Martin
2019-09-10 12:25 ` Cristian Marussi
2019-09-10 12:25 ` Cristian Marussi
2019-09-16 12:14 ` Dave Martin
2019-09-16 12:14 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904114722.GQ27757@arm.com \
--to=dave.martin@arm.com \
--cc=amit.kachhap@arm.com \
--cc=andreyknvl@google.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.