From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net/mlx5: DR, Add Steering entry (STE) utilities
Date: Thu, 05 Sep 2019 09:57:54 +0000 [thread overview]
Message-ID: <20190905095754.GA26074@mwanda> (raw)
Hello Alex Vesker,
The patch 26d688e33f88: "net/mlx5: DR, Add Steering entry (STE)
utilities" from Aug 19, 2019, leads to the following static checker
warning:
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:271 mlx5dr_ste_get_miss_addr()
warn: potential shift truncation. '0xff (0-255) << 26'
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c
267 u64 mlx5dr_ste_get_miss_addr(u8 *hw_ste)
268 {
269 u64 index 270 (MLX5_GET(ste_rx_steering_mult, hw_ste, miss_address_31_6) |
271 MLX5_GET(ste_rx_steering_mult, hw_ste, miss_address_39_32) << 26);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Smatch thinks this needs to be cast to u64.
272
273 return index << 6;
274 }
regards,
dan carpenter
reply other threads:[~2019-09-05 9:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905095754.GA26074@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.