All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] net/mlx5: DR, Add Steering entry (STE) utilities
@ 2019-09-05  9:57 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2019-09-05  9:57 UTC (permalink / raw)
  To: kernel-janitors

Hello Alex Vesker,

The patch 26d688e33f88: "net/mlx5: DR, Add Steering entry (STE)
utilities" from Aug 19, 2019, leads to the following static checker
warning:

	drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c:271 mlx5dr_ste_get_miss_addr()
	warn: potential shift truncation.  '0xff (0-255) << 26'

drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.c
   267  u64 mlx5dr_ste_get_miss_addr(u8 *hw_ste)
   268  {
   269          u64 index    270                  (MLX5_GET(ste_rx_steering_mult, hw_ste, miss_address_31_6) |
   271                   MLX5_GET(ste_rx_steering_mult, hw_ste, miss_address_39_32) << 26);
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Smatch thinks this needs to be cast to u64.

   272  
   273          return index << 6;
   274  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-09-05  9:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-05  9:57 [bug report] net/mlx5: DR, Add Steering entry (STE) utilities Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.