From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [Qemu-devel] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>
Date: Thu, 5 Sep 2019 11:36:13 +0100 [thread overview]
Message-ID: <20190905103613.GK2700@work-vm> (raw)
In-Reply-To: <6e9ff4f7-2906-3c11-8191-05cff3e60f53@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Hi Stefan,
>
> On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> > option was given. In this case messages to stderr are likely to be lost and
> > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of <err.h>.
> >
> > Stefan Hajnoczi (2):
> > virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
> > virtiofsd: replace err(3) and errx(3) with fuse_err()
>
> Is this a straight RESEND or are there any changes in this series?
>
> I'm asking because IIRC your first series had:
> - Reviewed-by: Jun Piao <piaojun@huawei.com>
> - Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> If this isn't a RESEND then I'll review it again.
I'll pick those reviews up.
Dave
> Thanks,
>
> Phil.
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>
Date: Thu, 5 Sep 2019 11:36:13 +0100 [thread overview]
Message-ID: <20190905103613.GK2700@work-vm> (raw)
In-Reply-To: <6e9ff4f7-2906-3c11-8191-05cff3e60f53@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Hi Stefan,
>
> On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> > option was given. In this case messages to stderr are likely to be lost and
> > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of <err.h>.
> >
> > Stefan Hajnoczi (2):
> > virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
> > virtiofsd: replace err(3) and errx(3) with fuse_err()
>
> Is this a straight RESEND or are there any changes in this series?
>
> I'm asking because IIRC your first series had:
> - Reviewed-by: Jun Piao <piaojun@huawei.com>
> - Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> If this isn't a RESEND then I'll review it again.
I'll pick those reviews up.
Dave
> Thanks,
>
> Phil.
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-09-05 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 8:29 [Virtio-fs] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h> Stefan Hajnoczi
2019-09-05 8:29 ` [Qemu-devel] " Stefan Hajnoczi
2019-09-05 8:29 ` [Virtio-fs] [PATCH RESEND 1/2] virtiofsd: replace warn(3) and warnx(3) with fuse_warning() Stefan Hajnoczi
2019-09-05 8:29 ` [Qemu-devel] " Stefan Hajnoczi
2019-09-05 8:29 ` [Virtio-fs] [PATCH RESEND 2/2] virtiofsd: replace err(3) and errx(3) with fuse_err() Stefan Hajnoczi
2019-09-05 8:29 ` [Qemu-devel] " Stefan Hajnoczi
2019-09-05 9:17 ` [Virtio-fs] [Qemu-devel] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h> Philippe Mathieu-Daudé
2019-09-05 9:17 ` Philippe Mathieu-Daudé
2019-09-05 10:36 ` Dr. David Alan Gilbert [this message]
2019-09-05 10:36 ` [Qemu-devel] [Virtio-fs] " Dr. David Alan Gilbert
2019-09-05 10:23 ` Dr. David Alan Gilbert
2019-09-05 10:23 ` [Qemu-devel] " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905103613.GK2700@work-vm \
--to=dgilbert@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.