From: Wolfram Sang <wsa@the-dreams.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: alokc@codeaurora.org, agross@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, bjorn.andersson@linaro.org,
vkoul@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/1] i2c: qcom-geni: Provide an option to disable DMA processing
Date: Thu, 5 Sep 2019 15:49:41 +0200 [thread overview]
Message-ID: <20190905134941.GG1157@kunai> (raw)
In-Reply-To: <20190905102247.27583-1-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
Hi Lee,
I understand you are in a hurry, but please double check before
sending...
On Thu, Sep 05, 2019 at 11:22:47AM +0100, Lee Jones wrote:
> We have a production-level laptop (Lenovo Yoga C630) which is exhibiting
> a rather horrific bug. When I2C HID devices are being scanned for at
> boot-time the QCom Geni based I2C (Serial Engine) attempts to use DMA.
> When it does, the laptop reboots and the user never sees the OS.
>
> The beautiful thing about this approach is that, *if* the Geni SE DMA
> ever starts working, we can remove the C code and any old properties
> left in older DTs just become NOOP. Older kernels with newer DTs (less
> of a priority) *still* will not work - but they do not work now anyway.
... becasue this paragraph doesn't fit anymore. Needs to be reworded.
>
> Fixes: 8bc529b25354 ("soc: qcom: geni: Add support for ACPI")
As said in the other thread, I don't get it, but this is not a show
stopper for me.
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
I'd like Vinod to resend his review. Because IMO the change since v2 was
not trivial, so the old rev-by has to be dropped.
Other than that, the code looks good to me!
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, agross@kernel.org,
robh+dt@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org,
alokc@codeaurora.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/1] i2c: qcom-geni: Provide an option to disable DMA processing
Date: Thu, 5 Sep 2019 15:49:41 +0200 [thread overview]
Message-ID: <20190905134941.GG1157@kunai> (raw)
In-Reply-To: <20190905102247.27583-1-lee.jones@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]
Hi Lee,
I understand you are in a hurry, but please double check before
sending...
On Thu, Sep 05, 2019 at 11:22:47AM +0100, Lee Jones wrote:
> We have a production-level laptop (Lenovo Yoga C630) which is exhibiting
> a rather horrific bug. When I2C HID devices are being scanned for at
> boot-time the QCom Geni based I2C (Serial Engine) attempts to use DMA.
> When it does, the laptop reboots and the user never sees the OS.
>
> The beautiful thing about this approach is that, *if* the Geni SE DMA
> ever starts working, we can remove the C code and any old properties
> left in older DTs just become NOOP. Older kernels with newer DTs (less
> of a priority) *still* will not work - but they do not work now anyway.
... becasue this paragraph doesn't fit anymore. Needs to be reworded.
>
> Fixes: 8bc529b25354 ("soc: qcom: geni: Add support for ACPI")
As said in the other thread, I don't get it, but this is not a show
stopper for me.
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
I'd like Vinod to resend his review. Because IMO the change since v2 was
not trivial, so the old rev-by has to be dropped.
Other than that, the code looks good to me!
Regards,
Wolfram
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-05 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 10:22 [PATCH v3 1/1] i2c: qcom-geni: Provide an option to disable DMA processing Lee Jones
2019-09-05 10:22 ` Lee Jones
2019-09-05 13:49 ` Wolfram Sang [this message]
2019-09-05 13:49 ` Wolfram Sang
2019-09-05 13:58 ` Peter Rosin
2019-09-05 13:58 ` Peter Rosin
2019-09-05 14:33 ` Lee Jones
2019-09-05 14:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905134941.GG1157@kunai \
--to=wsa@the-dreams.de \
--cc=agross@kernel.org \
--cc=alokc@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.