From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
martin.petersen@oracle.com, linux-nvme@lists.infradead.org,
keith.busch@intel.com, hch@lst.de, sagi@grimberg.me,
shlomin@mellanox.com, israelr@mellanox.com
Subject: Re: [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem
Date: Thu, 5 Sep 2019 20:04:28 +0200 [thread overview]
Message-ID: <20190905180428.GD24146@lst.de> (raw)
In-Reply-To: <1567701836-29725-3-git-send-email-maxg@mellanox.com>
On Thu, Sep 05, 2019 at 07:43:56PM +0300, Max Gurtovoy wrote:
> Use block layer definition instead of re-defining it with the same
> values.
>
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: axboe@kernel.dk, keith.busch@intel.com, sagi@grimberg.me,
martin.petersen@oracle.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
shlomin@mellanox.com, hch@lst.de
Subject: Re: [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem
Date: Thu, 5 Sep 2019 20:04:28 +0200 [thread overview]
Message-ID: <20190905180428.GD24146@lst.de> (raw)
In-Reply-To: <1567701836-29725-3-git-send-email-maxg@mellanox.com>
On Thu, Sep 05, 2019 at 07:43:56PM +0300, Max Gurtovoy wrote:
> Use block layer definition instead of re-defining it with the same
> values.
>
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-05 18:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:43 [PATCH v3 1/3] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 16:43 ` [PATCH 2/3] block: don't remap ref tag for T10 PI type 0 Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 16:43 ` [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 18:04 ` Christoph Hellwig [this message]
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 20:52 ` Sagi Grimberg
2019-09-05 20:52 ` Sagi Grimberg
2019-09-05 22:25 ` Max Gurtovoy
2019-09-05 22:25 ` Max Gurtovoy
2019-09-06 5:23 ` Christoph Hellwig
2019-09-06 5:23 ` Christoph Hellwig
2019-09-06 18:24 ` Sagi Grimberg
2019-09-06 18:24 ` Sagi Grimberg
2019-09-05 18:02 ` [PATCH v3 1/3] block: centralize PI remapping logic to the block layer Christoph Hellwig
2019-09-05 18:02 ` Christoph Hellwig
2019-09-06 15:52 ` Minwoo Im
2019-09-06 15:52 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905180428.GD24146@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.