From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 02/10] clk: sunxi-ng: Mark AR100 clocks as critical
Date: Thu, 05 Sep 2019 11:56:03 -0700 [thread overview]
Message-ID: <20190905185605.9203A206BA@mail.kernel.org> (raw)
In-Reply-To: <20190821122436.k3s7srhraphfnvgp@flea>
Quoting Maxime Ripard (2019-08-21 05:24:36)
> On Tue, Aug 20, 2019 at 08:02:55AM -0500, Samuel Holland wrote:
> > On 8/20/19 2:11 AM, Maxime Ripard wrote:
> > > So I'm not really sure that we should do it statically this way, and
> > > that we should do it at all.
> >
> > Do you have a better way to model "firmware uses this clock behind the scenes,
> > so Linux please don't touch it"? It's unfortunate that we have Linux and
> > firmware fighting over the R_CCU, but since we didn't have firmware (e.g. SCPI
> > clocks) in the beginning, it's where we are today.
> >
> > The AR100 clock doesn't actually have a gate, and it generally has dependencies
> > like R_INTC in use. So as I mentioned in the commit message, the clock will
> > normally be on anyway. The goal was to model the fact that there are users of
> > this clock that Linux doesn't/can't know about.
>
> Like I said, if that's an option, I'd prefer to have protected-clocks
> work for everyone / for sunxi.
>
Yes. Use protected-clocks to indicate what shouldn't be touched by the
kernel. It's not super easy to make it "generic" right now, but I
suppose we can work the flag into the core framework more so that we
still register the clks but otherwise make the 'clk_get()' operation
fail on them somehow and the disable unused operation skip them. I just
took the easy way out for qcom for the time being and didn't register
them from the driver.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Samuel Holland <samuel@sholland.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
Michael Turquette <mturquette@baylibre.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 02/10] clk: sunxi-ng: Mark AR100 clocks as critical
Date: Thu, 05 Sep 2019 11:56:03 -0700 [thread overview]
Message-ID: <20190905185605.9203A206BA@mail.kernel.org> (raw)
In-Reply-To: <20190821122436.k3s7srhraphfnvgp@flea>
Quoting Maxime Ripard (2019-08-21 05:24:36)
> On Tue, Aug 20, 2019 at 08:02:55AM -0500, Samuel Holland wrote:
> > On 8/20/19 2:11 AM, Maxime Ripard wrote:
> > > So I'm not really sure that we should do it statically this way, and
> > > that we should do it at all.
> >
> > Do you have a better way to model "firmware uses this clock behind the scenes,
> > so Linux please don't touch it"? It's unfortunate that we have Linux and
> > firmware fighting over the R_CCU, but since we didn't have firmware (e.g. SCPI
> > clocks) in the beginning, it's where we are today.
> >
> > The AR100 clock doesn't actually have a gate, and it generally has dependencies
> > like R_INTC in use. So as I mentioned in the commit message, the clock will
> > normally be on anyway. The goal was to model the fact that there are users of
> > this clock that Linux doesn't/can't know about.
>
> Like I said, if that's an option, I'd prefer to have protected-clocks
> work for everyone / for sunxi.
>
Yes. Use protected-clocks to indicate what shouldn't be touched by the
kernel. It's not super easy to make it "generic" right now, but I
suppose we can work the flag into the core framework more so that we
still register the clks but otherwise make the 'clk_get()' operation
fail on them somehow and the disable unused operation skip them. I just
took the easy way out for qcom for the time being and didn't register
them from the driver.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-05 18:56 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 3:23 [PATCH v4 00/10] Allwinner sunxi message box support Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 01/10] clk: sunxi-ng: Mark msgbox clocks as critical Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 02/10] clk: sunxi-ng: Mark AR100 " Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 7:11 ` Maxime Ripard
2019-08-20 7:11 ` Maxime Ripard
2019-08-20 7:11 ` Maxime Ripard
2019-08-20 13:02 ` Samuel Holland
2019-08-20 13:02 ` Samuel Holland
2019-08-20 13:02 ` Samuel Holland
2019-08-21 12:24 ` Maxime Ripard
2019-08-21 12:24 ` Maxime Ripard
2019-08-21 12:24 ` Maxime Ripard
2019-09-05 18:56 ` Stephen Boyd [this message]
2019-09-05 18:56 ` Stephen Boyd
2019-08-20 3:23 ` [PATCH v4 03/10] dt-bindings: mailbox: Add a sunxi message box binding Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 7:14 ` Maxime Ripard
2019-08-20 7:14 ` Maxime Ripard
2019-08-20 7:14 ` Maxime Ripard
2019-08-20 13:04 ` Samuel Holland
2019-08-20 13:04 ` Samuel Holland
2019-08-21 12:07 ` Maxime Ripard
2019-08-21 12:07 ` Maxime Ripard
2019-08-21 12:07 ` Maxime Ripard
2019-08-20 3:23 ` [PATCH v4 04/10] mailbox: sunxi-msgbox: Add a new mailbox driver Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 8:27 ` Maxime Ripard
2019-08-20 8:27 ` Maxime Ripard
2019-08-20 8:27 ` Maxime Ripard
2019-08-20 11:18 ` Ondřej Jirman
2019-08-20 11:18 ` Ondřej Jirman
2019-08-20 11:18 ` Ondřej Jirman
2019-08-20 13:07 ` Samuel Holland
2019-08-20 13:07 ` Samuel Holland
2019-08-20 13:07 ` Samuel Holland
2019-08-20 13:34 ` Ondřej Jirman
2019-08-20 13:34 ` Ondřej Jirman
2019-08-20 13:34 ` Ondřej Jirman
2019-08-21 12:30 ` Maxime Ripard
2019-08-21 12:30 ` Maxime Ripard
2019-08-21 12:30 ` Maxime Ripard
2019-08-20 3:23 ` [PATCH v4 05/10] ARM: dts: sunxi: a80: Add msgbox node Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 8:15 ` Maxime Ripard
2019-08-20 8:15 ` Maxime Ripard
2019-08-20 8:15 ` Maxime Ripard
2019-08-20 13:17 ` Samuel Holland
2019-08-20 13:17 ` Samuel Holland
2019-08-23 14:56 ` Maxime Ripard
2019-08-23 14:56 ` Maxime Ripard
2019-08-23 14:56 ` Maxime Ripard
2019-08-20 3:23 ` [PATCH v4 06/10] ARM: dts: sunxi: a83t: " Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 07/10] ARM: dts: sunxi: h3/h5: " Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 08/10] arm64: dts: allwinner: a64: " Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 09/10] arm64: dts: allwinner: h6: " Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` [PATCH v4 10/10] [DO NOT MERGE] drivers: firmware: msgbox demo Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-08-20 3:23 ` Samuel Holland
2019-09-09 3:22 ` [PATCH v4 00/10] Allwinner sunxi message box support Ondřej Jirman
2019-09-09 3:22 ` Ondřej Jirman
2019-09-09 3:22 ` Ondřej Jirman
2019-09-09 3:54 ` Samuel Holland
2019-09-09 3:54 ` Samuel Holland
2019-09-09 3:54 ` Samuel Holland
2019-09-09 12:36 ` Ondřej Jirman
2019-09-09 12:36 ` Ondřej Jirman
2019-09-09 12:36 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905185605.9203A206BA@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=anarsoul@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.