From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Jafar Abdi <cafer.abdi@gmail.com>,
qemu-trivial@nongnu.org, jusual@mail.ru, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH V2 0/4] fix usage of bool
Date: Fri, 6 Sep 2019 15:36:48 +0100 [thread overview]
Message-ID: <20190906143648.GA21331@redhat.com> (raw)
In-Reply-To: <20190326081814.GF21018@stefanha-x1.localdomain>
On Tue, Mar 26, 2019 at 08:18:14AM +0000, Stefan Hajnoczi wrote:
> On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote:
> > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> >
> > FALSE and TRUE (with capital letters) are the constants defined by glib for
> > being used with the "gboolean" type of glib. But some parts of the code also use
> > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
>
> CCing qemu-trivial
Ping qemu-trivial - this was seems to have been missed, though
patches 2 & 3 got merged via ppc tree meanwhile. The other two
are still valid.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, jusual@mail.ru,
Jafar Abdi <cafer.abdi@gmail.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 0/4] fix usage of bool
Date: Fri, 6 Sep 2019 15:36:48 +0100 [thread overview]
Message-ID: <20190906143648.GA21331@redhat.com> (raw)
In-Reply-To: <20190326081814.GF21018@stefanha-x1.localdomain>
On Tue, Mar 26, 2019 at 08:18:14AM +0000, Stefan Hajnoczi wrote:
> On Sat, Mar 23, 2019 at 05:26:33PM +0300, Jafar Abdi wrote:
> > Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> >
> > FALSE and TRUE (with capital letters) are the constants defined by glib for
> > being used with the "gboolean" type of glib. But some parts of the code also use
> > TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
>
> CCing qemu-trivial
Ping qemu-trivial - this was seems to have been missed, though
patches 2 & 3 got merged via ppc tree meanwhile. The other two
are still valid.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-09-06 14:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1553351197-14581-1-git-send-email-cafer.abdi@gmail.com>
[not found] ` <1553351197-14581-2-git-send-email-cafer.abdi@gmail.com>
2019-03-24 19:37 ` [Qemu-trivial] [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c Thomas Huth
[not found] ` <1553351197-14581-3-git-send-email-cafer.abdi@gmail.com>
2019-03-24 19:39 ` [Qemu-trivial] [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c Thomas Huth
[not found] ` <1553351197-14581-4-git-send-email-cafer.abdi@gmail.com>
2019-03-24 19:40 ` [Qemu-trivial] [Qemu-devel] [PATCH V2 3/4] tests/libqos: fix usage of bool in pci-spapr.c Thomas Huth
[not found] ` <1553351197-14581-5-git-send-email-cafer.abdi@gmail.com>
2019-03-24 19:41 ` [Qemu-trivial] [Qemu-devel] [PATCH V2 4/4] hw/tpm: fix usage of bool in tpm-tis.c Thomas Huth
2019-03-26 13:55 ` Stefan Berger
2020-05-07 11:52 ` Daniel P. Berrangé
2020-05-07 11:52 ` Daniel P. Berrangé
2020-05-08 19:42 ` Stefan Berger
2020-05-08 19:42 ` Stefan Berger
2019-03-26 8:18 ` [Qemu-trivial] [PATCH V2 0/4] fix usage of bool Stefan Hajnoczi
2019-09-06 14:36 ` Daniel P. Berrangé [this message]
2019-09-06 14:36 ` [Qemu-devel] " Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906143648.GA21331@redhat.com \
--to=berrange@redhat.com \
--cc=cafer.abdi@gmail.com \
--cc=jusual@mail.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.