* [meta-oe][PATCH V2 1/3] remmina: Add recipe for the remmina remote desktop client
@ 2019-09-06 16:32 Khem Raj
2019-09-06 16:32 ` [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl Khem Raj
2019-09-06 16:32 ` [meta-networking][PATCH 3/3] samba: Fix configure tests to work with clang Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Khem Raj @ 2019-09-06 16:32 UTC (permalink / raw)
To: openembedded-devel
From: "aehs29@gmail.com" <aehs29@gmail.com>
Remmina has become one of the most widely used RDP clients,
it uses freeRDP 2.0 as a backend and also supports multiple
network protocols like RSP, VNC, SPICE, NX, and SSH.
Signed-off-by: Alejandro Enedino Hernandez Samaniego <aehs29@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
v2: Rebased
.../recipes-support/remmina/remmina_1.3.6.bb | 28 +++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 meta-oe/recipes-support/remmina/remmina_1.3.6.bb
diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
new file mode 100644
index 0000000000..a14a2592cd
--- /dev/null
+++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
@@ -0,0 +1,28 @@
+DESCRIPTION = "A feature rich Remote Desktop Application written in GTK+"
+HOMEPAGE = "https://remmina.org"
+SECTION = "Support"
+LICENSE = "GPLv2 & openssl"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
+DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
+
+SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
+"
+SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
+SRC_URI[sha256sum] = "fbed745438bb0c21467b60cbd67c8148a9289b5ebc7482d06db443bea556af1a"
+
+S = "${WORKDIR}/Remmina-v${PV}"
+
+inherit cmake
+
+EXTRA_OECMAKE += "-DWITH_APPINDICATOR=OFF -DWITH_GETTEXT=OFF -DWITH_TRANSLATIONS=OFF"
+
+do_install_append(){
+ # We dont need the extra stuff form other desktop environments
+ rm -rf ${D}/${datadir}/xsessions
+ rm -rf ${D}/${datadir}/metainfo
+ rm -rf ${D}/${datadir}/gnome-session
+}
+
+RDEPENDS_${PN} = "bash"
+
+FILES_${PN}_append = " ${datadir}/icons/hicolor/*"
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl
2019-09-06 16:32 [meta-oe][PATCH V2 1/3] remmina: Add recipe for the remmina remote desktop client Khem Raj
@ 2019-09-06 16:32 ` Khem Raj
2019-09-06 16:35 ` Alejandro Enedino Hernandez Samaniego
2019-09-06 16:32 ` [meta-networking][PATCH 3/3] samba: Fix configure tests to work with clang Khem Raj
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2019-09-06 16:32 UTC (permalink / raw)
To: openembedded-devel
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Alejandro Enedino Hernandez Samaniego <aehs29@gmail.com>
---
meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
index a14a2592cd..a86deccc8f 100644
--- a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
+++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
@@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
+DEPENDS_append_libc-musl = "libexecinfo"
+LDFLAGS_append_libc-musl = " -lexecinfo"
+
SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
"
SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [meta-networking][PATCH 3/3] samba: Fix configure tests to work with clang
2019-09-06 16:32 [meta-oe][PATCH V2 1/3] remmina: Add recipe for the remmina remote desktop client Khem Raj
2019-09-06 16:32 ` [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl Khem Raj
@ 2019-09-06 16:32 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2019-09-06 16:32 UTC (permalink / raw)
To: openembedded-devel
Do not use nested functions ( main inside main )
Use global scope for __thread variables
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
...ipt-Avoid-generating-nested-main-fun.patch | 30 ++++++++++
...ve-__thread-variable-to-global-scope.patch | 58 +++++++++++++++++++
.../samba/samba_4.10.7.bb | 2 +
3 files changed, 90 insertions(+)
create mode 100644 meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch
create mode 100644 meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch
diff --git a/meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch b/meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch
new file mode 100644
index 0000000000..de7f311834
--- /dev/null
+++ b/meta-networking/recipes-connectivity/samba/samba/0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch
@@ -0,0 +1,30 @@
+From 3a935c638605bfb392ca7780d22c08c1a0a71e71 Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 5 Sep 2019 21:37:33 -0700
+Subject: [PATCH 1/2] lib/replace/wscript: Avoid generating nested main
+ function
+
+clang is not happy when it sees another main nested inside the main
+function and fails the test for prctl syscall, therefore avoid adding
+implicit main() here
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ lib/replace/wscript | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/lib/replace/wscript b/lib/replace/wscript
+index a7fd25d..d6767fc 100644
+--- a/lib/replace/wscript
++++ b/lib/replace/wscript
+@@ -137,6 +137,7 @@ def configure(conf):
+ }
+ ''',
+ 'HAVE_PRCTL',
++ addmain=False,
+ headers='sys/prctl.h',
+ msg='Checking for prctl syscall')
+
+--
+2.23.0
+
diff --git a/meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch b/meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch
new file mode 100644
index 0000000000..6fc849337c
--- /dev/null
+++ b/meta-networking/recipes-connectivity/samba/samba/0002-util_sec.c-Move-__thread-variable-to-global-scope.patch
@@ -0,0 +1,58 @@
+From c62a6f32ab965de2ec77a614f20f04568116835b Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Thu, 5 Sep 2019 21:39:05 -0700
+Subject: [PATCH 2/2] util_sec.c: Move __thread variable to global scope
+
+Make clang happy otherwise it complains about variable scope
+
+fixes
+
+source3/./lib/util_sec.c:470:4: error: '__thread' variables must have global storage
+ } __thread cache;
+ ^
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ source3/lib/util_sec.c | 19 +++++++++++--------
+ 1 file changed, 11 insertions(+), 8 deletions(-)
+
+diff --git a/source3/lib/util_sec.c b/source3/lib/util_sec.c
+index 9408269..7390318 100644
+--- a/source3/lib/util_sec.c
++++ b/source3/lib/util_sec.c
+@@ -444,6 +444,17 @@ void become_user_permanently(uid_t uid, gid_t gid)
+ assert_gid(gid, gid);
+ }
+
++#ifdef HAVE___THREAD
++ struct cache_t {
++ bool active;
++ uid_t uid;
++ gid_t gid;
++ size_t setlen;
++ uintptr_t gidset;
++ };
++
++static __thread struct cache_t cache;
++#endif
+ /**********************************************************
+ Function to set thread specific credentials. Leave
+ saved-set uid/gid alone.Must be thread-safe code.
+@@ -461,14 +472,6 @@ int set_thread_credentials(uid_t uid,
+ * available.
+ */
+ #ifdef HAVE___THREAD
+- static struct {
+- bool active;
+- uid_t uid;
+- gid_t gid;
+- size_t setlen;
+- uintptr_t gidset;
+- } __thread cache;
+-
+ if (cache.active &&
+ cache.uid == uid &&
+ cache.gid == gid &&
+--
+2.23.0
+
diff --git a/meta-networking/recipes-connectivity/samba/samba_4.10.7.bb b/meta-networking/recipes-connectivity/samba/samba_4.10.7.bb
index d13a6b4dbb..1b2bc087d5 100644
--- a/meta-networking/recipes-connectivity/samba/samba_4.10.7.bb
+++ b/meta-networking/recipes-connectivity/samba/samba_4.10.7.bb
@@ -24,6 +24,8 @@ SRC_URI = "${SAMBA_MIRROR}/stable/samba-${PV}.tar.gz \
file://smb_conf-4.7.0.patch \
file://volatiles.03_samba \
file://0001-waf-add-support-of-cross_compile.patch \
+ file://0001-lib-replace-wscript-Avoid-generating-nested-main-fun.patch \
+ file://0002-util_sec.c-Move-__thread-variable-to-global-scope.patch \
"
SRC_URI_append_libc-musl = " \
file://samba-pam.patch \
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl
2019-09-06 16:32 ` [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl Khem Raj
@ 2019-09-06 16:35 ` Alejandro Enedino Hernandez Samaniego
2019-09-07 16:25 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2019-09-06 16:35 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-devel
Hey Khem,
Thanks for this, I hadn't fixed it because I have no access to my laptop
for now, looks good to me though.
Alejandro
On Fri, Sep 6, 2019, 9:32 AM Khem Raj <raj.khem@gmail.com> wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Alejandro Enedino Hernandez Samaniego <aehs29@gmail.com>
> ---
> meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> index a14a2592cd..a86deccc8f 100644
> --- a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> +++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> @@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f
> file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
> DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui
> libsodium libssh vte json-glib libsoup-2.4 libvncserver spice
> spice-protocol libsecret"
>
> +DEPENDS_append_libc-musl = "libexecinfo"
> +LDFLAGS_append_libc-musl = " -lexecinfo"
> +
> SRC_URI = "
> https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2
> \
> "
> SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
> --
> 2.23.0
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl
2019-09-06 16:35 ` Alejandro Enedino Hernandez Samaniego
@ 2019-09-07 16:25 ` Khem Raj
2019-09-07 19:20 ` Alejandro Enedino Hernandez Samaniego
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2019-09-07 16:25 UTC (permalink / raw)
To: Alejandro Enedino Hernandez Samaniego; +Cc: openembeded-devel
another issue on arm
ERROR: Nothing PROVIDES 'spice' (but
/mnt/b/yoe/sources/meta-openembedded/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
DEPENDS on
or otherwise requires it)
spice was skipped: incompatible with host arm-yoe-linux-gnueabi (not
in COMPATIBLE_HOST)
I think you need to mold arch support for it as per deps
On Fri, Sep 6, 2019 at 9:35 AM Alejandro Enedino Hernandez Samaniego
<aehs29@gmail.com> wrote:
>
> Hey Khem,
>
> Thanks for this, I hadn't fixed it because I have no access to my laptop for now, looks good to me though.
>
> Alejandro
>
> On Fri, Sep 6, 2019, 9:32 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> Cc: Alejandro Enedino Hernandez Samaniego <aehs29@gmail.com>
>> ---
>> meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
>> index a14a2592cd..a86deccc8f 100644
>> --- a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
>> +++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
>> @@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
>> LIC_FILES_CHKSUM = "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
>> DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui libsodium libssh vte json-glib libsoup-2.4 libvncserver spice spice-protocol libsecret"
>>
>> +DEPENDS_append_libc-musl = "libexecinfo"
>> +LDFLAGS_append_libc-musl = " -lexecinfo"
>> +
>> SRC_URI = "https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2 \
>> "
>> SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
>> --
>> 2.23.0
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl
2019-09-07 16:25 ` Khem Raj
@ 2019-09-07 19:20 ` Alejandro Enedino Hernandez Samaniego
0 siblings, 0 replies; 6+ messages in thread
From: Alejandro Enedino Hernandez Samaniego @ 2019-09-07 19:20 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Sat, Sep 7, 2019, 9:25 AM Khem Raj <raj.khem@gmail.com> wrote:
> another issue on arm
>
> ERROR: Nothing PROVIDES 'spice' (but
> /mnt/b/yoe/sources/meta-openembedded/meta-oe/recipes-support/remmina/
> remmina_1.3.6.bb
> DEPENDS on
> or otherwise requires it)
> spice was skipped: incompatible with host arm-yoe-linux-gnueabi (not
> in COMPATIBLE_HOST)
>
> I think you need to mold arch support for it as per deps
>
I'll take a look later tonight, thanks.
Alejandro
> On Fri, Sep 6, 2019 at 9:35 AM Alejandro Enedino Hernandez Samaniego
> <aehs29@gmail.com> wrote:
> >
> > Hey Khem,
> >
> > Thanks for this, I hadn't fixed it because I have no access to my laptop
> for now, looks good to me though.
> >
> > Alejandro
> >
> > On Fri, Sep 6, 2019, 9:32 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> Cc: Alejandro Enedino Hernandez Samaniego <aehs29@gmail.com>
> >> ---
> >> meta-oe/recipes-support/remmina/remmina_1.3.6.bb | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> >> index a14a2592cd..a86deccc8f 100644
> >> --- a/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> >> +++ b/meta-oe/recipes-support/remmina/remmina_1.3.6.bb
> >> @@ -5,6 +5,9 @@ LICENSE = "GPLv2 & openssl"
> >> LIC_FILES_CHKSUM =
> "file://LICENSE;md5=dab7215512044d49037272ce1ac4ea8f
> file://LICENSE.OpenSSL;md5=c1eb3cee0a4dea27503c531267a69769"
> >> DEPENDS += "openssl freerdp gtk+3 gdk-pixbuf atk libgcrypt avahi-ui
> libsodium libssh vte json-glib libsoup-2.4 libvncserver spice
> spice-protocol libsecret"
> >>
> >> +DEPENDS_append_libc-musl = "libexecinfo"
> >> +LDFLAGS_append_libc-musl = " -lexecinfo"
> >> +
> >> SRC_URI = "
> https://gitlab.com/Remmina/Remmina/-/archive/v${PV}/Remmina-v${PV}.tar.bz2
> \
> >> "
> >> SRC_URI[md5sum] = "6da599c3a5cab2df37a70f8fba2f5438"
> >> --
> >> 2.23.0
> >>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-07 19:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 16:32 [meta-oe][PATCH V2 1/3] remmina: Add recipe for the remmina remote desktop client Khem Raj
2019-09-06 16:32 ` [meta-oe][PATCH 2/3] remmina: Link with libexecinfo explicitly on musl Khem Raj
2019-09-06 16:35 ` Alejandro Enedino Hernandez Samaniego
2019-09-07 16:25 ` Khem Raj
2019-09-07 19:20 ` Alejandro Enedino Hernandez Samaniego
2019-09-06 16:32 ` [meta-networking][PATCH 3/3] samba: Fix configure tests to work with clang Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.