* [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency
@ 2019-08-12 17:58 Fabrice Fontaine
2019-08-12 20:48 ` Thomas Petazzoni
2019-09-08 6:02 ` Ricardo Martincoski
0 siblings, 2 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2019-08-12 17:58 UTC (permalink / raw)
To: buildroot
intltool is not needed since version 236 and
https://github.com/systemd/systemd/commit/c81217920effddc93fb780cf8f9eb699d6fe1319
https://github.com/systemd/systemd/commit/9e8f3893e349a68312a817da72b3473b81b6869e
So drop it and replace it by TARGET_NLS_DEPENDENCIES
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/systemd/systemd.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index e8fd7967bd..b6aac6dc53 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -12,10 +12,10 @@ SYSTEMD_INSTALL_STAGING = YES
SYSTEMD_DEPENDENCIES = \
$(if $(BR2_PACKAGE_BASH_COMPLETION),bash-completion) \
host-gperf \
- host-intltool \
kmod \
libcap \
- util-linux
+ util-linux \
+ $(TARGET_NLS_DEPENDENCIES)
SYSTEMD_PROVIDES = udev
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency
2019-08-12 17:58 [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency Fabrice Fontaine
@ 2019-08-12 20:48 ` Thomas Petazzoni
2019-08-13 7:05 ` Peter Korsgaard
2019-09-08 6:02 ` Ricardo Martincoski
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2019-08-12 20:48 UTC (permalink / raw)
To: buildroot
On Mon, 12 Aug 2019 19:58:09 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> intltool is not needed since version 236 and
> https://github.com/systemd/systemd/commit/c81217920effddc93fb780cf8f9eb699d6fe1319
> https://github.com/systemd/systemd/commit/9e8f3893e349a68312a817da72b3473b81b6869e
>
> So drop it and replace it by TARGET_NLS_DEPENDENCIES
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/systemd/systemd.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency
2019-08-12 17:58 [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency Fabrice Fontaine
2019-08-12 20:48 ` Thomas Petazzoni
@ 2019-09-08 6:02 ` Ricardo Martincoski
2019-09-08 7:58 ` Fabrice Fontaine
1 sibling, 1 reply; 9+ messages in thread
From: Ricardo Martincoski @ 2019-09-08 6:02 UTC (permalink / raw)
To: buildroot
Hello,
+ Thomas P
On Mon, Aug 12, 2019 at 02:58 PM, Fabrice Fontaine wrote:
> intltool is not needed since version 236 and
> https://github.com/systemd/systemd/commit/c81217920effddc93fb780cf8f9eb699d6fe1319
> https://github.com/systemd/systemd/commit/9e8f3893e349a68312a817da72b3473b81b6869e
>
> So drop it and replace it by TARGET_NLS_DEPENDENCIES
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/systemd/systemd.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index e8fd7967bd..b6aac6dc53 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -12,10 +12,10 @@ SYSTEMD_INSTALL_STAGING = YES
> SYSTEMD_DEPENDENCIES = \
> $(if $(BR2_PACKAGE_BASH_COMPLETION),bash-completion) \
> host-gperf \
> - host-intltool \
> kmod \
> libcap \
> - util-linux
> + util-linux \
> + $(TARGET_NLS_DEPENDENCIES)
>
> SYSTEMD_PROVIDES = udev
>
> --
After this patch, 4 runtime tests started to fail. See the run before [1] and
after [2] this patch:
[1] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290109684
[2] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290110315
These are the tests:
...ystemSystemdRoIfupdown | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126471 | ORPH
...ystemSystemdRoNetworkd | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126473 | ORPH
...ystemSystemdRwIfupdown | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126476 | ORPH
...ystemSystemdRwNetworkd | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126477 | ORPH
systemd build fails at configure step:
po/meson.build:4:5: ERROR: Can not do gettext because xgettext is not installed.
Running the same tests in my PC without the docker image all 4 tests pass.
Autobuilders did not catch this:
http://autobuild.buildroot.net/?reason=systemd-241
I tried the bump to 243, the same build error occurs:
http://patchwork.ozlabs.org/patch/1157207/
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290136894
An error in another package with the same error message was fixed by you in:
"56fb7401b9 package/ncmpc: fix build without NLS"
Can you investigate this?
Regards,
Ricardo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency
2019-09-08 6:02 ` Ricardo Martincoski
@ 2019-09-08 7:58 ` Fabrice Fontaine
2019-09-08 12:52 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Fabrice Fontaine @ 2019-09-08 7:58 UTC (permalink / raw)
To: buildroot
Hello Ricardo,
Le dim. 8 sept. 2019 ? 08:02, Ricardo Martincoski
<ricardo.martincoski@gmail.com> a ?crit :
>
> Hello,
>
> + Thomas P
>
> On Mon, Aug 12, 2019 at 02:58 PM, Fabrice Fontaine wrote:
>
> > intltool is not needed since version 236 and
> > https://github.com/systemd/systemd/commit/c81217920effddc93fb780cf8f9eb699d6fe1319
> > https://github.com/systemd/systemd/commit/9e8f3893e349a68312a817da72b3473b81b6869e
> >
> > So drop it and replace it by TARGET_NLS_DEPENDENCIES
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/systemd/systemd.mk | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> > index e8fd7967bd..b6aac6dc53 100644
> > --- a/package/systemd/systemd.mk
> > +++ b/package/systemd/systemd.mk
> > @@ -12,10 +12,10 @@ SYSTEMD_INSTALL_STAGING = YES
> > SYSTEMD_DEPENDENCIES = \
> > $(if $(BR2_PACKAGE_BASH_COMPLETION),bash-completion) \
> > host-gperf \
> > - host-intltool \
> > kmod \
> > libcap \
> > - util-linux
> > + util-linux \
> > + $(TARGET_NLS_DEPENDENCIES)
> >
> > SYSTEMD_PROVIDES = udev
> >
> > --
>
> After this patch, 4 runtime tests started to fail. See the run before [1] and
> after [2] this patch:
>
> [1] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290109684
> [2] https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290110315
>
> These are the tests:
> ...ystemSystemdRoIfupdown | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126471 | ORPH
> ...ystemSystemdRoNetworkd | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126473 | ORPH
> ...ystemSystemdRwIfupdown | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126476 | ORPH
> ...ystemSystemdRwNetworkd | https://gitlab.com/buildroot.org/buildroot/-/jobs/289126477 | ORPH
>
> systemd build fails at configure step:
> po/meson.build:4:5: ERROR: Can not do gettext because xgettext is not installed.
>
> Running the same tests in my PC without the docker image all 4 tests pass.
>
> Autobuilders did not catch this:
> http://autobuild.buildroot.net/?reason=systemd-241
>
> I tried the bump to 243, the same build error occurs:
> http://patchwork.ozlabs.org/patch/1157207/
> https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/290136894
>
> An error in another package with the same error message was fixed by you in:
> "56fb7401b9 package/ncmpc: fix build without NLS"
>
> Can you investigate this?
I think it should be fixed by adding host-gettext to
SYSTEMD_DEPENDENCIES. Could you check if it fixes the build failure?
I'll then send a patch.
>
>
> Regards,
> Ricardo
Regards,
Fabrice
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-09-08 21:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-12 17:58 [Buildroot] [PATCH/next 1/1] package/systemd: drop host-intltool dependency Fabrice Fontaine
2019-08-12 20:48 ` Thomas Petazzoni
2019-08-13 7:05 ` Peter Korsgaard
2019-08-13 12:11 ` Thomas Petazzoni
2019-09-08 6:02 ` Ricardo Martincoski
2019-09-08 7:58 ` Fabrice Fontaine
2019-09-08 12:52 ` Thomas Petazzoni
2019-09-08 14:24 ` James Hilliard
2019-09-08 21:11 ` Ricardo Martincoski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.