* [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
@ 2019-09-06 20:01 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2019-09-06 20:01 UTC (permalink / raw)
To: linux-omap
Cc: Andrew F . Davis, Dave Gerlach, Faiz Abbas, Greg Kroah-Hartman,
Keerthy, Nishanth Menon, Peter Ujfalusi, Roger Quadros,
Suman Anna, Tero Kristo, linux-kernel, linux-arm-kernel,
Vignesh Raghavendra
Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
quirks") fixed handling for no-idle quirk modules that are not enabled
by the bootloader.
But it also caused unpaired clockdomain calls that won't allow idling
the system. That's because clkdm_allow_idle_nolock() and
clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
Cc: Keerthy <j-keerthy@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/bus/ti-sysc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
*/
if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
SYSC_QUIRK_NO_IDLE_ON_INIT)) {
- sysc_clkdm_deny_idle(ddata);
sysc_disable_main_clocks(ddata);
sysc_disable_opt_clocks(ddata);
sysc_clkdm_allow_idle(ddata);
--
2.23.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
@ 2019-09-06 20:01 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2019-09-06 20:01 UTC (permalink / raw)
To: linux-omap
Cc: Nishanth Menon, Tero Kristo, Vignesh Raghavendra, Dave Gerlach,
Keerthy, linux-kernel, Andrew F . Davis, Peter Ujfalusi,
Faiz Abbas, Greg Kroah-Hartman, linux-arm-kernel, Roger Quadros
Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
quirks") fixed handling for no-idle quirk modules that are not enabled
by the bootloader.
But it also caused unpaired clockdomain calls that won't allow idling
the system. That's because clkdm_allow_idle_nolock() and
clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
Cc: Keerthy <j-keerthy@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/bus/ti-sysc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
*/
if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
SYSC_QUIRK_NO_IDLE_ON_INIT)) {
- sysc_clkdm_deny_idle(ddata);
sysc_disable_main_clocks(ddata);
sysc_disable_opt_clocks(ddata);
sysc_clkdm_allow_idle(ddata);
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
2019-09-06 20:01 ` Tony Lindgren
(?)
@ 2019-09-09 1:57 ` Keerthy
-1 siblings, 0 replies; 7+ messages in thread
From: Keerthy @ 2019-09-09 1:57 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Nishanth Menon, Tero Kristo, Vignesh Raghavendra, Dave Gerlach,
Greg Kroah-Hartman, linux-kernel, Andrew F . Davis,
Peter Ujfalusi, Faiz Abbas, linux-arm-kernel, Roger Quadros
On 07/09/19 1:31 AM, Tony Lindgren wrote:
> Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
> quirks") fixed handling for no-idle quirk modules that are not enabled
> by the bootloader.
>
> But it also caused unpaired clockdomain calls that won't allow idling
> the system. That's because clkdm_allow_idle_nolock() and
> clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
>
> Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Tested-by: Keerthy <j-keerthy@ti.com>
I believe still the previous fix [1] for nfs boot is still not on
linux-next. Are you planning on more testing or it will be queued as fixes?
[1] https://lkml.org/lkml/2019/9/5/616
- Keerthy
>
> Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/bus/ti-sysc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
> */
> if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
> SYSC_QUIRK_NO_IDLE_ON_INIT)) {
> - sysc_clkdm_deny_idle(ddata);
> sysc_disable_main_clocks(ddata);
> sysc_disable_opt_clocks(ddata);
> sysc_clkdm_allow_idle(ddata);
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
@ 2019-09-09 1:57 ` Keerthy
0 siblings, 0 replies; 7+ messages in thread
From: Keerthy @ 2019-09-09 1:57 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Andrew F . Davis, Dave Gerlach, Faiz Abbas, Greg Kroah-Hartman,
Nishanth Menon, Peter Ujfalusi, Roger Quadros, Suman Anna,
Tero Kristo, linux-kernel, linux-arm-kernel, Vignesh Raghavendra
On 07/09/19 1:31 AM, Tony Lindgren wrote:
> Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
> quirks") fixed handling for no-idle quirk modules that are not enabled
> by the bootloader.
>
> But it also caused unpaired clockdomain calls that won't allow idling
> the system. That's because clkdm_allow_idle_nolock() and
> clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
>
> Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Tested-by: Keerthy <j-keerthy@ti.com>
I believe still the previous fix [1] for nfs boot is still not on
linux-next. Are you planning on more testing or it will be queued as fixes?
[1] https://lkml.org/lkml/2019/9/5/616
- Keerthy
>
> Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/bus/ti-sysc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
> */
> if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
> SYSC_QUIRK_NO_IDLE_ON_INIT)) {
> - sysc_clkdm_deny_idle(ddata);
> sysc_disable_main_clocks(ddata);
> sysc_disable_opt_clocks(ddata);
> sysc_clkdm_allow_idle(ddata);
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
@ 2019-09-09 1:57 ` Keerthy
0 siblings, 0 replies; 7+ messages in thread
From: Keerthy @ 2019-09-09 1:57 UTC (permalink / raw)
To: Tony Lindgren, linux-omap
Cc: Nishanth Menon, Tero Kristo, Vignesh Raghavendra, Dave Gerlach,
Greg Kroah-Hartman, linux-kernel, Andrew F . Davis,
Peter Ujfalusi, Faiz Abbas, linux-arm-kernel, Roger Quadros
On 07/09/19 1:31 AM, Tony Lindgren wrote:
> Commit d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle
> quirks") fixed handling for no-idle quirk modules that are not enabled
> by the bootloader.
>
> But it also caused unpaired clockdomain calls that won't allow idling
> the system. That's because clkdm_allow_idle_nolock() and
> clkdm_deny_idle_nolock() have usage count with clkdm->forcewake_count.
>
> Let's drop the unpaired sysc_clkdm_deny_idle() to fix idling of devices.
Tested-by: Keerthy <j-keerthy@ti.com>
I believe still the previous fix [1] for nfs boot is still not on
linux-next. Are you planning on more testing or it will be queued as fixes?
[1] https://lkml.org/lkml/2019/9/5/616
- Keerthy
>
> Fixes: d098913a10f8 ("bus: ti-sysc: Fix clock handling for no-idle quirks")
> Cc: Keerthy <j-keerthy@ti.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/bus/ti-sysc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2363,7 +2363,6 @@ static void ti_sysc_idle(struct work_struct *work)
> */
> if (ddata->cfg.quirks & (SYSC_QUIRK_NO_IDLE |
> SYSC_QUIRK_NO_IDLE_ON_INIT)) {
> - sysc_clkdm_deny_idle(ddata);
> sysc_disable_main_clocks(ddata);
> sysc_disable_opt_clocks(ddata);
> sysc_clkdm_allow_idle(ddata);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
2019-09-09 1:57 ` Keerthy
@ 2019-09-09 16:19 ` Tony Lindgren
-1 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2019-09-09 16:19 UTC (permalink / raw)
To: Keerthy
Cc: linux-omap, Andrew F . Davis, Dave Gerlach, Faiz Abbas,
Greg Kroah-Hartman, Nishanth Menon, Peter Ujfalusi, Roger Quadros,
Suman Anna, Tero Kristo, linux-kernel, linux-arm-kernel,
Vignesh Raghavendra
Hi,
* Keerthy <j-keerthy@ti.com> [190909 01:57]:
> I believe still the previous fix [1] for nfs boot is still not on
> linux-next. Are you planning on more testing or it will be queued as fixes?
I pushed out the pending fixes on Saturday so they should be in
the next version of Linux next.
Regards,
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle()
@ 2019-09-09 16:19 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2019-09-09 16:19 UTC (permalink / raw)
To: Keerthy
Cc: Nishanth Menon, Tero Kristo, Vignesh Raghavendra, Dave Gerlach,
Greg Kroah-Hartman, linux-kernel, Andrew F . Davis,
Peter Ujfalusi, Faiz Abbas, linux-omap, linux-arm-kernel,
Roger Quadros
Hi,
* Keerthy <j-keerthy@ti.com> [190909 01:57]:
> I believe still the previous fix [1] for nfs boot is still not on
> linux-next. Are you planning on more testing or it will be queued as fixes?
I pushed out the pending fixes on Saturday so they should be in
the next version of Linux next.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-09 16:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 20:01 [PATCH] bus: ti-sysc: Remove unpaired sysc_clkdm_deny_idle() Tony Lindgren
2019-09-06 20:01 ` Tony Lindgren
2019-09-09 1:57 ` Keerthy
2019-09-09 1:57 ` Keerthy
2019-09-09 1:57 ` Keerthy
2019-09-09 16:19 ` Tony Lindgren
2019-09-09 16:19 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.