* [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling @ 2019-09-10 13:42 ` Dan Carpenter 2020-04-30 14:10 ` Wolfram Sang 0 siblings, 1 reply; 9+ messages in thread From: Dan Carpenter @ 2019-09-10 13:42 UTC (permalink / raw) To: kernel-janitors The problem is that we dereference "privdata->pci_dev" when we print the error messages in amd_mp2_pci_init(): dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); ^^^^^^^^^^^^^^^^^ Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: style change drivers/i2c/busses/i2c-amd-mp2-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-amd-mp2-pci.c b/drivers/i2c/busses/i2c-amd-mp2-pci.c index 5e4800d72e00..cd3fd5ee5f65 100644 --- a/drivers/i2c/busses/i2c-amd-mp2-pci.c +++ b/drivers/i2c/busses/i2c-amd-mp2-pci.c @@ -349,12 +349,12 @@ static int amd_mp2_pci_probe(struct pci_dev *pci_dev, if (!privdata) return -ENOMEM; + privdata->pci_dev = pci_dev; rc = amd_mp2_pci_init(privdata, pci_dev); if (rc) return rc; mutex_init(&privdata->c2p_lock); - privdata->pci_dev = pci_dev; pm_runtime_set_autosuspend_delay(&pci_dev->dev, 1000); pm_runtime_use_autosuspend(&pci_dev->dev); -- 2.20.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling 2019-09-10 13:42 ` [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling Dan Carpenter @ 2020-04-30 14:10 ` Wolfram Sang 0 siblings, 0 replies; 9+ messages in thread From: Wolfram Sang @ 2020-04-30 14:10 UTC (permalink / raw) To: Dan Carpenter Cc: Elie Morisse, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors [-- Attachment #1: Type: text/plain, Size: 537 bytes --] On Tue, Sep 10, 2019 at 04:42:42PM +0300, Dan Carpenter wrote: > The problem is that we dereference "privdata->pci_dev" when we print > the error messages in amd_mp2_pci_init(): > > dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); > ^^^^^^^^^^^^^^^^^ > > Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to for-current, thanks! Elie, Nehal, Shyam, are you still there to review patches for this driver? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling @ 2020-04-30 14:10 ` Wolfram Sang 0 siblings, 0 replies; 9+ messages in thread From: Wolfram Sang @ 2020-04-30 14:10 UTC (permalink / raw) To: Dan Carpenter Cc: Elie Morisse, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors [-- Attachment #1: Type: text/plain, Size: 537 bytes --] On Tue, Sep 10, 2019 at 04:42:42PM +0300, Dan Carpenter wrote: > The problem is that we dereference "privdata->pci_dev" when we print > the error messages in amd_mp2_pci_init(): > > dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); > ^^^^^^^^^^^^^^^^^ > > Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied to for-current, thanks! Elie, Nehal, Shyam, are you still there to review patches for this driver? [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling 2020-04-30 14:10 ` Wolfram Sang @ 2020-04-30 19:43 ` Elie Morisse -1 siblings, 0 replies; 9+ messages in thread From: Elie Morisse @ 2020-04-30 19:43 UTC (permalink / raw) To: Wolfram Sang Cc: Dan Carpenter, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors Hi, Yes I'm still here to review patches. Sorry about this one, I replied to the v1 but in HTML so it bounced back the ML and should have but didn't give my ack to the v2. I'll make sure to give proper feedback to the latest versions of the patches for the I2C MP2 driver in the future. Elie Le jeu. 30 avr. 2020 à 11:10, Wolfram Sang <wsa@the-dreams.de> a écrit : > > On Tue, Sep 10, 2019 at 04:42:42PM +0300, Dan Carpenter wrote: > > The problem is that we dereference "privdata->pci_dev" when we print > > the error messages in amd_mp2_pci_init(): > > > > dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); > > ^^^^^^^^^^^^^^^^^ > > > > Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Applied to for-current, thanks! > > Elie, Nehal, Shyam, are you still there to review patches for this > driver? > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling @ 2020-04-30 19:43 ` Elie Morisse 0 siblings, 0 replies; 9+ messages in thread From: Elie Morisse @ 2020-04-30 19:43 UTC (permalink / raw) To: Wolfram Sang Cc: Dan Carpenter, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors Hi, Yes I'm still here to review patches. Sorry about this one, I replied to the v1 but in HTML so it bounced back the ML and should have but didn't give my ack to the v2. I'll make sure to give proper feedback to the latest versions of the patches for the I2C MP2 driver in the future. Elie Le jeu. 30 avr. 2020 à 11:10, Wolfram Sang <wsa@the-dreams.de> a écrit : > > On Tue, Sep 10, 2019 at 04:42:42PM +0300, Dan Carpenter wrote: > > The problem is that we dereference "privdata->pci_dev" when we print > > the error messages in amd_mp2_pci_init(): > > > > dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n"); > > ^^^^^^^^^^^^^^^^^ > > > > Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Applied to for-current, thanks! > > Elie, Nehal, Shyam, are you still there to review patches for this > driver? > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling 2020-04-30 19:43 ` Elie Morisse @ 2020-04-30 20:06 ` Wolfram Sang -1 siblings, 0 replies; 9+ messages in thread From: Wolfram Sang @ 2020-04-30 20:06 UTC (permalink / raw) To: Elie Morisse Cc: Dan Carpenter, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors [-- Attachment #1: Type: text/plain, Size: 64 bytes --] > Yes I'm still here to review patches. Glad to hear that :) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling @ 2020-04-30 20:06 ` Wolfram Sang 0 siblings, 0 replies; 9+ messages in thread From: Wolfram Sang @ 2020-04-30 20:06 UTC (permalink / raw) To: Elie Morisse Cc: Dan Carpenter, Nehal Shah, Shyam Sundar S K, linux-i2c, kernel-janitors [-- Attachment #1: Type: text/plain, Size: 64 bytes --] > Yes I'm still here to review patches. Glad to hear that :) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling 2020-04-30 20:06 ` Wolfram Sang @ 2020-05-01 5:22 ` Shah, Nehal-bakulchandra -1 siblings, 0 replies; 9+ messages in thread From: Shah, Nehal-bakulchandra @ 2020-05-01 5:10 UTC (permalink / raw) To: Wolfram Sang, Elie Morisse Cc: Dan Carpenter, Shyam Sundar S K, linux-i2c, kernel-janitors Hi wolfram, On 5/1/2020 1:36 AM, Wolfram Sang wrote: >> Yes I'm still here to review patches. > Glad to hear that :) Shyam and myslef also are here to review the patches. Thanks Nehal ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling @ 2020-05-01 5:22 ` Shah, Nehal-bakulchandra 0 siblings, 0 replies; 9+ messages in thread From: Shah, Nehal-bakulchandra @ 2020-05-01 5:22 UTC (permalink / raw) To: Wolfram Sang, Elie Morisse Cc: Dan Carpenter, Shyam Sundar S K, linux-i2c, kernel-janitors Hi wolfram, On 5/1/2020 1:36 AM, Wolfram Sang wrote: >> Yes I'm still here to review patches. > Glad to hear that :) Shyam and myslef also are here to review the patches. Thanks Nehal ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-01 5:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAC_JBqofuyRiSmK0mFqVLaY=5k9MYmjGaVmggx2dn_YjN8VOmw@mail.gmail.com>
2019-09-10 13:42 ` [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling Dan Carpenter
2020-04-30 14:10 ` Wolfram Sang
2020-04-30 14:10 ` Wolfram Sang
2020-04-30 19:43 ` Elie Morisse
2020-04-30 19:43 ` Elie Morisse
2020-04-30 20:06 ` Wolfram Sang
2020-04-30 20:06 ` Wolfram Sang
2020-05-01 5:10 ` Shah, Nehal-bakulchandra
2020-05-01 5:22 ` Shah, Nehal-bakulchandra
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.