All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/statx04: use stx_attributes_mask before test
Date: Wed, 11 Sep 2019 14:47:14 +0200	[thread overview]
Message-ID: <20190911124714.GA21670@rei.lan> (raw)
In-Reply-To: <05330771-04f6-0fe4-f99d-eb55ff8b733c@cn.fujitsu.com>

Hi!
> Do you mean use getxattr to ensure bitflags are enable or a functions test?
> I am confused.

For a given filesystem the support for filling in these flags was added
at some point to the kernel. If any kernel newer that this version fails
to fill them up it's a bug.

For ext2 it has been added in:

commit 93bc420ed41df63a18ae794101f7cbf45226a6ef
Author: yangerkun <yangerkun@huawei.com>
Date:   Mon Feb 18 09:07:02 2019 +0800

    ext2: support statx syscall

Hence starting kernel 5.0 ext2 (with ext2 driver) has to set the mask.

For ext4 it has been added in:

commit 3209f68b3ca4667069923a325c88b21131bfdf9f
Author: David Howells <dhowells@redhat.com>
Date:   Fri Mar 31 18:32:17 2017 +0100

	statx: Include a mask for stx_attributes in struct statx


Hence for ext4 the flags should be enabled since kernel 4.11

etc.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2019-09-11 12:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis
2019-08-20  6:33   ` [LTP] [PATCH v2] " Yang Xu
2019-08-27  9:25     ` Petr Vorel
2019-08-27  9:58       ` Petr Vorel
2019-08-27 10:16         ` Cyril Hrubis
2019-09-11 10:22           ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47             ` Cyril Hrubis [this message]
2019-09-12  3:28               ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25  3:53               ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03                 ` Yang Xu
2021-05-25 13:18                 ` Li Wang
2021-05-25 14:16                   ` Cyril Hrubis
2021-05-26  4:00                     ` xuyang2018.jy
2021-05-26  8:31                       ` Li Wang
2021-05-26 10:02                         ` xuyang2018.jy
2021-11-10 13:28                 ` Richard Palethorpe
2021-11-11  3:25                   ` xuyang2018.jy
2019-08-28  3:56       ` [LTP] [PATCH v2] " Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911124714.GA21670@rei.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.