From: xuyang2018.jy@fujitsu.com <xuyang2018.jy@fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test
Date: Wed, 26 May 2021 10:02:35 +0000 [thread overview]
Message-ID: <60AE1CE7.3030002@fujitsu.com> (raw)
In-Reply-To: <CAEemH2eSmf+7kGcq3rZS4_RPZ7W58hSyLqdx=zrzJUsEMQf8og@mail.gmail.com>
Hi Li
> Hi all,
>
> > >> This patch makes sense to me, I'm not sure if any blocker issue for
> > >> holding the apply process. If _no_ I would help to merge it:).
> > >
> > > See:
> > >
> > > https://github.com/linux-test-project/ltp/issues/557
> > >
> > > Basically this change hides a kernel bug.
> > I don't think it is a kernel bug and it is only an non-supported feature
> > before linux 5.1 when not using ext4 driver for ext2.
>
> Cyril hopes to have a reproducer to cover the bug [1](though
> you think it a non-support problem), but that is responsible
> advicefor FileSystem:).
Yes, xfstest is more situable to do this.
> Actually, the worth to say, there already a separate test
> (xfstest/generic/424) for reproducing this problem[2].
Yes, this fix is found by xfstest/generic/424.
> See: https://github.com/kdave/xfstests/blob/master/tests/generic/424
Usually I see xfstests case on offical repo repository
https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
> I believe FS QE/Dev will run it for all filesystems regularly.
I think Theodore Ts'o may do it on xfstests-bld[1] and other
project(like lkp) may also do it by using really ext2 driver. So having
generic/424 is enough to find this kernel bug.
[1]https://git.kernel.org/pub/scm/fs/ext2/xfstests-bld.git/tree/kernel-configs/x86_64-config-5.10#n114
>
> So maybe we can safely apply this patch in LTP without
> adding a duplicated test?
+1. With this patch, we can also run this case on xfs filesystem.
>
> [1] https://bugs.linaro.org/show_bug.cgi?id=4012
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=93bc420ed41df63
>
> --
> Regards,
> Li Wang
next prev parent reply other threads:[~2021-05-26 10:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 10:34 [LTP] [PATCH] syscalls/statx04: use stx_attributes_mask before test Yang Xu
2019-08-02 11:50 ` Cyril Hrubis
2019-08-20 6:33 ` [LTP] [PATCH v2] " Yang Xu
2019-08-27 9:25 ` Petr Vorel
2019-08-27 9:58 ` Petr Vorel
2019-08-27 10:16 ` Cyril Hrubis
2019-09-11 10:22 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-09-11 12:47 ` Cyril Hrubis
2019-09-12 3:28 ` =?unknown-8bit?b?WWFuZy/lvpAg5p2o?=
2019-10-25 3:53 ` [LTP] [PATCH] " Yang Xu
2019-10-31 10:03 ` Yang Xu
2021-05-25 13:18 ` Li Wang
2021-05-25 14:16 ` Cyril Hrubis
2021-05-26 4:00 ` xuyang2018.jy
2021-05-26 8:31 ` Li Wang
2021-05-26 10:02 ` xuyang2018.jy [this message]
2021-11-10 13:28 ` Richard Palethorpe
2021-11-11 3:25 ` xuyang2018.jy
2019-08-28 3:56 ` [LTP] [PATCH v2] " Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60AE1CE7.3030002@fujitsu.com \
--to=xuyang2018.jy@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.