All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Fix DRM_I915_DEBUG IOMMU stuff
@ 2019-09-11 13:50 Ville Syrjala
  2019-09-11 13:59 ` Chris Wilson
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Ville Syrjala @ 2019-09-11 13:50 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We need to select IOMMU_SUPPORT as well, otherwise we can be left
with:
 CONFIG_IOMMU_IOVA=m
 # CONFIG_IOMMU_SUPPORT is not set
 CONFIG_INTEL_IOMMU=y

which complains:
"WARNING: unmet direct dependencies detected for INTEL_IOMMU"

and fails to link:
ld: drivers/iommu/intel-iommu.o: in function `free_all_cpu_cached_iovas':
/home/vsyrjala/src/linux/build_skl/../drivers/iommu/intel-iommu.c:4466: undefined reference to `free_cpu_cached_iovas'
...

Or do we maybe want something like:
 select <iommu thing> if IOMMU_SUPPORT
instead?

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Fixes: 02229acb3926 ("drm/i915: Force compilation with intel-iommu for CI validation")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/Kconfig.debug | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index c5c00cad6ba1..d940280df6b9 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -22,6 +22,7 @@ config DRM_I915_DEBUG
         depends on DRM_I915
 	select PCI_MSI
 	select IOMMU_API
+	select IOMMU_SUPPORT
 	select IOMMU_IOVA
 	select NEED_DMA_MAP_STATE
 	select DMAR_TABLE
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-09-12  4:11 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-11 13:50 [PATCH] drm/i915: Fix DRM_I915_DEBUG IOMMU stuff Ville Syrjala
2019-09-11 13:59 ` Chris Wilson
2019-09-11 14:08   ` Ville Syrjälä
2019-09-11 14:10     ` Chris Wilson
2019-09-11 14:11     ` Ville Syrjälä
2019-09-11 16:03 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-09-11 16:24 ` ✓ Fi.CI.BAT: success " Patchwork
2019-09-12  4:11 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.