* [PATCH v2 1/2] mmc: queue: Fix bigger segments usage
2019-09-12 4:13 [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Yoshihiro Shimoda
@ 2019-09-12 4:13 ` Yoshihiro Shimoda
2019-09-12 17:57 ` Wolfram Sang
2019-09-12 4:13 ` [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE Yoshihiro Shimoda
2019-09-12 12:17 ` [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Yoshihiro Shimoda @ 2019-09-12 4:13 UTC (permalink / raw)
To: hch, ulf.hansson, wsa+renesas
Cc: treding, linux-mmc, linux-renesas-soc, Yoshihiro Shimoda
The commit 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP
layer can merge the segments") always enables the bugger segments
if DMA MAP layer can merge the segments, but some controllers (SDHCI)
have strictly limitation about the segments size, and then the commit
breaks on the controllers.
To fix the issue, this patch adds a new flag MMC_CAP2_MERGE_CAPABLE
into the struct mmc_host and the bigger segments usage is disabled
as default.
Reported-by: Thierry Reding <treding@nvidia.com>
Fixes: 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP layer can merge the segments")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/core/queue.c | 8 +++++++-
include/linux/mmc/host.h | 1 +
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index 1e29b30..9edc086 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -399,6 +399,11 @@ static void mmc_setup_queue(struct mmc_queue *mq, struct mmc_card *card)
init_waitqueue_head(&mq->wait);
}
+static inline bool mmc_merge_capable(struct mmc_host *host)
+{
+ return host->caps2 & MMC_CAP2_MERGE_CAPABLE;
+}
+
/* Set queue depth to get a reasonable value for q->nr_requests */
#define MMC_QUEUE_DEPTH 64
@@ -441,7 +446,8 @@ int mmc_init_queue(struct mmc_queue *mq, struct mmc_card *card)
* the host->can_dma_map_merge should be set before to get max_segs
* from mmc_get_max_segments().
*/
- if (host->max_segs < MMC_DMA_MAP_MERGE_SEGMENTS &&
+ if (mmc_merge_capable(host) &&
+ host->max_segs < MMC_DMA_MAP_MERGE_SEGMENTS &&
dma_get_merge_boundary(mmc_dev(host)))
host->can_dma_map_merge = 1;
else
diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index c5662b3..3becb28 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -367,6 +367,7 @@ struct mmc_host {
#define MMC_CAP2_CQE (1 << 23) /* Has eMMC command queue engine */
#define MMC_CAP2_CQE_DCMD (1 << 24) /* CQE can issue a direct command */
#define MMC_CAP2_AVOID_3_3V (1 << 25) /* Host must negotiate down from 3.3V */
+#define MMC_CAP2_MERGE_CAPABLE (1 << 26) /* Host can merge a segment over the segment size */
int fixed_drv_type; /* fixed driver type for non-removable media */
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 1/2] mmc: queue: Fix bigger segments usage
2019-09-12 4:13 ` [PATCH v2 1/2] " Yoshihiro Shimoda
@ 2019-09-12 17:57 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-09-12 17:57 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: hch, ulf.hansson, wsa+renesas, treding, linux-mmc,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Thu, Sep 12, 2019 at 01:13:55PM +0900, Yoshihiro Shimoda wrote:
> The commit 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP
> layer can merge the segments") always enables the bugger segments
"buffer" :)
> if DMA MAP layer can merge the segments, but some controllers (SDHCI)
> have strictly limitation about the segments size, and then the commit
> breaks on the controllers.
>
> To fix the issue, this patch adds a new flag MMC_CAP2_MERGE_CAPABLE
> into the struct mmc_host and the bigger segments usage is disabled
> as default.
>
> Reported-by: Thierry Reding <treding@nvidia.com>
> Fixes: 38c38cb73223 ("mmc: queue: use bigger segments if DMA MAP layer can merge the segments")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
For the record:
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE
2019-09-12 4:13 [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Yoshihiro Shimoda
2019-09-12 4:13 ` [PATCH v2 1/2] " Yoshihiro Shimoda
@ 2019-09-12 4:13 ` Yoshihiro Shimoda
2019-09-12 17:57 ` Wolfram Sang
2019-09-12 12:17 ` [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Christoph Hellwig
2 siblings, 1 reply; 6+ messages in thread
From: Yoshihiro Shimoda @ 2019-09-12 4:13 UTC (permalink / raw)
To: hch, ulf.hansson, wsa+renesas
Cc: treding, linux-mmc, linux-renesas-soc, Yoshihiro Shimoda
Since this host controller can merge bigger segments if DMA API
layer cam merge the segments, this patch adds the flag.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 751fe91..a66f8d6 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -106,7 +106,7 @@ static const struct renesas_sdhi_of_data of_rcar_gen3_compatible = {
TMIO_MMC_HAVE_CBSY | TMIO_MMC_MIN_RCAR2,
.capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ |
MMC_CAP_CMD23,
- .capabilities2 = MMC_CAP2_NO_WRITE_PROTECT,
+ .capabilities2 = MMC_CAP2_NO_WRITE_PROTECT | MMC_CAP2_MERGE_CAPABLE,
.bus_shift = 2,
.scc_offset = 0x1000,
.taps = rcar_gen3_scc_taps,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE
2019-09-12 4:13 ` [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE Yoshihiro Shimoda
@ 2019-09-12 17:57 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-09-12 17:57 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: hch, ulf.hansson, wsa+renesas, treding, linux-mmc,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Thu, Sep 12, 2019 at 01:13:56PM +0900, Yoshihiro Shimoda wrote:
> Since this host controller can merge bigger segments if DMA API
> layer cam merge the segments, this patch adds the flag.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
For the record:
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 0/2] mmc: queue: Fix bigger segments usage
2019-09-12 4:13 [PATCH v2 0/2] mmc: queue: Fix bigger segments usage Yoshihiro Shimoda
2019-09-12 4:13 ` [PATCH v2 1/2] " Yoshihiro Shimoda
2019-09-12 4:13 ` [PATCH v2 2/2] mmc: renesas_sdhi_internal_dmac: Add MMC_CAP2_MERGE_CAPABLE Yoshihiro Shimoda
@ 2019-09-12 12:17 ` Christoph Hellwig
2 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2019-09-12 12:17 UTC (permalink / raw)
To: Yoshihiro Shimoda
Cc: hch, ulf.hansson, wsa+renesas, treding, linux-mmc,
linux-renesas-soc
Thanks,
applied to the dma-mapping tree for 5.4.
^ permalink raw reply [flat|nested] 6+ messages in thread