[meta-multimedia][PATCH] mycroft: Make rdep on alsa-oss conditional on glibc

[meta-multimedia][PATCH] mycroft: Make rdep on alsa-oss conditional on glibc

[Khem Raj]

alsa-oss does not build for musl so its marked incompatible for musl

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
index becd0bf790..8d1c9179be 100644
--- a/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
+++ b/meta-multimedia/recipes-multimedia/mycroft/mycroft_19.2.3.bb
@@ -64,7 +64,8 @@ RDEPENDS_${PN} += "python3-pip \
                  "
 
 # Mycroft uses Alsa, PulseAudio and Flac
-RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
+RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
 RDEPENDS_${PN} += "pulseaudio pulseaudio-misc pulseaudio-server"
 RDEPENDS_${PN} += "flac"
 
-- 
2.23.0

Re: [meta-multimedia][PATCH] mycroft: Make rdep on alsa-oss conditional on glibc

[Adrian Bunk]

On Thu, Sep 12, 2019 at 01:18:31PM -0700, Khem Raj wrote:
> alsa-oss does not build for musl so its marked incompatible for musl
>...
>  # Mycroft uses Alsa, PulseAudio and Flac
> -RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
> +RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
> +RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
>...

This looks wrong - either it needs also-oss or it does not need it.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [meta-multimedia][PATCH] mycroft: Make rdep on alsa-oss conditional on glibc

[Khem Raj]

On Thu, Sep 12, 2019 at 2:12 PM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Thu, Sep 12, 2019 at 01:18:31PM -0700, Khem Raj wrote:
> > alsa-oss does not build for musl so its marked incompatible for musl
> >...
> >  # Mycroft uses Alsa, PulseAudio and Flac
> > -RDEPENDS_${PN} += "alsa-oss alsa-utils alsa-plugins alsa-tools"
> > +RDEPENDS_${PN} += "alsa-utils alsa-plugins alsa-tools"
> > +RDEPENDS_${PN}_append_libc-glibc = " alsa-oss"
> >...
>
> This looks wrong - either it needs also-oss or it does not need it.

actually I do not see is needing alsa-oss, it seems to be ok with
pulseadio-alsa plugins
but since I have only tried with musl I tried to keep it unmodified
for glibc but I guess we
should just remove it.

>
> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>