From: Pavel Machek <pavel@ucw.cz>
To: Daniel Mack <daniel@zonque.org>
Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH] drivers: leds: tlc591xx: check error during device init
Date: Sun, 15 Sep 2019 18:52:24 +0200 [thread overview]
Message-ID: <20190915165224.GB4857@bug> (raw)
In-Reply-To: <20190913180749.25740-1-daniel@zonque.org>
On Fri 2019-09-13 20:07:49, Daniel Mack wrote:
> The driver currently ignores errors from register writes at probe time.
> It will hence register an LED class device no matter whether the
> pyhsical device is present or not.
>
> To fix this, make the device probe fail in case regmap operations
> return an error.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-09-15 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:07 [PATCH] drivers: leds: tlc591xx: check error during device init Daniel Mack
2019-09-15 16:52 ` Pavel Machek [this message]
2019-09-19 20:26 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915165224.GB4857@bug \
--to=pavel@ucw.cz \
--cc=daniel@zonque.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.