* [PATCH] drivers: leds: tlc591xx: check error during device init
@ 2019-09-13 18:07 Daniel Mack
2019-09-15 16:52 ` Pavel Machek
2019-09-19 20:26 ` Jacek Anaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Mack @ 2019-09-13 18:07 UTC (permalink / raw)
To: jacek.anaszewski; +Cc: linux-leds, Daniel Mack
The driver currently ignores errors from register writes at probe time.
It will hence register an LED class device no matter whether the
pyhsical device is present or not.
To fix this, make the device probe fail in case regmap operations
return an error.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/leds/leds-tlc591xx.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index 59ff088c7d75..00702824d27c 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -147,7 +147,10 @@ tlc591xx_configure(struct device *dev,
unsigned int i;
int err = 0;
- tlc591xx_set_mode(priv->regmap, MODE2_DIM);
+ err = tlc591xx_set_mode(priv->regmap, MODE2_DIM);
+ if (err < 0)
+ return err;
+
for (i = 0; i < TLC591XX_MAX_LEDS; i++) {
struct tlc591xx_led *led = &priv->leds[i];
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers: leds: tlc591xx: check error during device init
2019-09-13 18:07 [PATCH] drivers: leds: tlc591xx: check error during device init Daniel Mack
@ 2019-09-15 16:52 ` Pavel Machek
2019-09-19 20:26 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2019-09-15 16:52 UTC (permalink / raw)
To: Daniel Mack; +Cc: jacek.anaszewski, linux-leds
On Fri 2019-09-13 20:07:49, Daniel Mack wrote:
> The driver currently ignores errors from register writes at probe time.
> It will hence register an LED class device no matter whether the
> pyhsical device is present or not.
>
> To fix this, make the device probe fail in case regmap operations
> return an error.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: leds: tlc591xx: check error during device init
2019-09-13 18:07 [PATCH] drivers: leds: tlc591xx: check error during device init Daniel Mack
2019-09-15 16:52 ` Pavel Machek
@ 2019-09-19 20:26 ` Jacek Anaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2019-09-19 20:26 UTC (permalink / raw)
To: Daniel Mack; +Cc: linux-leds
Hi Daniel,
Thank you for the patch.
On 9/13/19 8:07 PM, Daniel Mack wrote:
> The driver currently ignores errors from register writes at probe time.
> It will hence register an LED class device no matter whether the
> pyhsical device is present or not.
>
> To fix this, make the device probe fail in case regmap operations
> return an error.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
> drivers/leds/leds-tlc591xx.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index 59ff088c7d75..00702824d27c 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -147,7 +147,10 @@ tlc591xx_configure(struct device *dev,
> unsigned int i;
> int err = 0;
>
> - tlc591xx_set_mode(priv->regmap, MODE2_DIM);
> + err = tlc591xx_set_mode(priv->regmap, MODE2_DIM);
> + if (err < 0)
> + return err;
> +
> for (i = 0; i < TLC591XX_MAX_LEDS; i++) {
> struct tlc591xx_led *led = &priv->leds[i];
>
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-19 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-13 18:07 [PATCH] drivers: leds: tlc591xx: check error during device init Daniel Mack
2019-09-15 16:52 ` Pavel Machek
2019-09-19 20:26 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.