All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Christian Brauner <christian@brauner.io>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args
Date: Tue, 17 Sep 2019 09:49:09 +0200	[thread overview]
Message-ID: <20190917074909.GA49590@gmail.com> (raw)
In-Reply-To: <20190917071853.12385-1-seth.forshee@canonical.com>


* Seth Forshee <seth.forshee@canonical.com> wrote:

> The addition of struct clone_args to uapi/linux/sched.h is not
> protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
> RISC-V. Add the guards to fix this.
> 
> Fixes: 7f192e3cd316 ("fork: add clone3")
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
>  include/uapi/linux/sched.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index b3105ac1381a..851ff1feadd5 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -33,6 +33,7 @@
>  #define CLONE_NEWNET		0x40000000	/* New network namespace */
>  #define CLONE_IO		0x80000000	/* Clone io context */
>  
> +#ifndef __ASSEMBLY__
>  /*
>   * Arguments for the clone3 syscall
>   */
> @@ -46,6 +47,7 @@ struct clone_args {
>  	__aligned_u64 stack_size;
>  	__aligned_u64 tls;
>  };
> +#endif

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

      parent reply	other threads:[~2019-09-17  7:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17  7:18 [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args Seth Forshee
2019-09-17  7:34 ` Christian Brauner
2019-09-17  7:49 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917074909.GA49590@gmail.com \
    --to=mingo@kernel.org \
    --cc=christian@brauner.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.