* [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args
@ 2019-09-17 7:18 Seth Forshee
2019-09-17 7:34 ` Christian Brauner
2019-09-17 7:49 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Seth Forshee @ 2019-09-17 7:18 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Christian Brauner; +Cc: linux-kernel
The addition of struct clone_args to uapi/linux/sched.h is not
protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
RISC-V. Add the guards to fix this.
Fixes: 7f192e3cd316 ("fork: add clone3")
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
include/uapi/linux/sched.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
index b3105ac1381a..851ff1feadd5 100644
--- a/include/uapi/linux/sched.h
+++ b/include/uapi/linux/sched.h
@@ -33,6 +33,7 @@
#define CLONE_NEWNET 0x40000000 /* New network namespace */
#define CLONE_IO 0x80000000 /* Clone io context */
+#ifndef __ASSEMBLY__
/*
* Arguments for the clone3 syscall
*/
@@ -46,6 +47,7 @@ struct clone_args {
__aligned_u64 stack_size;
__aligned_u64 tls;
};
+#endif
/*
* Scheduling policies
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args
2019-09-17 7:18 [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args Seth Forshee
@ 2019-09-17 7:34 ` Christian Brauner
2019-09-17 7:49 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2019-09-17 7:34 UTC (permalink / raw)
To: Seth Forshee; +Cc: Ingo Molnar, Peter Zijlstra, linux-kernel
On Tue, Sep 17, 2019 at 09:18:53AM +0200, Seth Forshee wrote:
> The addition of struct clone_args to uapi/linux/sched.h is not
> protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
> RISC-V. Add the guards to fix this.
>
> Fixes: 7f192e3cd316 ("fork: add clone3")
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Applied to:
https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=fixes
Just replaced FTBS with "failure to build from source" since I had to
search for this and also added Cc: <stable@vger.kernel.org> for 5.3.
Thanks!
Christian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args
2019-09-17 7:18 [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args Seth Forshee
2019-09-17 7:34 ` Christian Brauner
@ 2019-09-17 7:49 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2019-09-17 7:49 UTC (permalink / raw)
To: Seth Forshee; +Cc: Ingo Molnar, Peter Zijlstra, Christian Brauner, linux-kernel
* Seth Forshee <seth.forshee@canonical.com> wrote:
> The addition of struct clone_args to uapi/linux/sched.h is not
> protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
> RISC-V. Add the guards to fix this.
>
> Fixes: 7f192e3cd316 ("fork: add clone3")
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
> include/uapi/linux/sched.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index b3105ac1381a..851ff1feadd5 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -33,6 +33,7 @@
> #define CLONE_NEWNET 0x40000000 /* New network namespace */
> #define CLONE_IO 0x80000000 /* Clone io context */
>
> +#ifndef __ASSEMBLY__
> /*
> * Arguments for the clone3 syscall
> */
> @@ -46,6 +47,7 @@ struct clone_args {
> __aligned_u64 stack_size;
> __aligned_u64 tls;
> };
> +#endif
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-17 7:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-17 7:18 [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args Seth Forshee
2019-09-17 7:34 ` Christian Brauner
2019-09-17 7:49 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.