All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Baruch Siach <baruch@tkos.co.il>,
	Fabio Estevam <festevam@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	tinywrkb <tinywrkb@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed
Date: Tue, 17 Sep 2019 18:37:28 +0100	[thread overview]
Message-ID: <20190917173728.GZ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190917172658.GB9591@lunn.ch>

On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote:
> > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> > index b3893347804d..85cf4a4a5e81 100644
> > --- a/drivers/net/phy/at803x.c
> > +++ b/drivers/net/phy/at803x.c
> 
> Hi Russell
> 
> This won't work. In the kernel logs, you see 
> 
> kernel: Generic PHY 2188000.ethernet-1:00: attached PHY driver [Generic PHY]
> 
> The generic PHY driver is being used, not the at803x driver.

Well, the _correct_ driver needs to be used for the PHY specific
features to be properly controlled.  Using the generic driver
in this situation will not be guaranteed to work.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: tinywrkb <tinywrkb@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Baruch Siach <baruch@tkos.co.il>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed
Date: Tue, 17 Sep 2019 18:37:28 +0100	[thread overview]
Message-ID: <20190917173728.GZ25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190917172658.GB9591@lunn.ch>

On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote:
> > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> > index b3893347804d..85cf4a4a5e81 100644
> > --- a/drivers/net/phy/at803x.c
> > +++ b/drivers/net/phy/at803x.c
> 
> Hi Russell
> 
> This won't work. In the kernel logs, you see 
> 
> kernel: Generic PHY 2188000.ethernet-1:00: attached PHY driver [Generic PHY]
> 
> The generic PHY driver is being used, not the at803x driver.

Well, the _correct_ driver needs to be used for the PHY specific
features to be properly controlled.  Using the generic driver
in this situation will not be guaranteed to work.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

  reply	other threads:[~2019-09-17 17:37 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 15:55 [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed tinywrkb
2019-09-10 15:55 ` tinywrkb
2019-09-10 15:55 ` tinywrkb
2019-09-10 16:10 ` Fabio Estevam
2019-09-10 16:10   ` Fabio Estevam
2019-09-10 16:10   ` Fabio Estevam
2019-09-10 16:17 ` Baruch Siach
2019-09-10 16:17   ` Baruch Siach
2019-09-10 16:46 ` Russell King - ARM Linux admin
2019-09-10 16:46   ` Russell King - ARM Linux admin
2019-09-10 18:50 ` Andrew Lunn
2019-09-10 18:50   ` Andrew Lunn
2019-09-15  6:30   ` Baruch Siach
2019-09-15  6:30     ` Baruch Siach
2019-09-15  6:30     ` Baruch Siach
2019-09-15 12:29     ` Russell King - ARM Linux admin
2019-09-15 12:29       ` Russell King - ARM Linux admin
2019-09-15 13:56     ` Andrew Lunn
2019-09-15 13:56       ` Andrew Lunn
2019-09-15 14:06       ` Russell King - ARM Linux admin
2019-09-15 14:06         ` Russell King - ARM Linux admin
2019-09-15 14:15         ` Russell King - ARM Linux admin
2019-09-15 14:15           ` Russell King - ARM Linux admin
2019-09-15 14:42           ` Andrew Lunn
2019-09-15 14:42             ` Andrew Lunn
2019-09-15 14:42             ` Andrew Lunn
2019-09-15 14:58             ` Russell King - ARM Linux admin
2019-09-15 14:58               ` Russell King - ARM Linux admin
2019-09-17 12:41       ` tinywrkb
2019-09-17 12:41         ` tinywrkb
2019-09-17 12:54         ` Andrew Lunn
2019-09-17 12:54           ` Andrew Lunn
2019-09-17 13:32           ` tinywrkb
2019-09-17 13:32             ` tinywrkb
2019-09-17 13:39             ` Russell King - ARM Linux admin
2019-09-17 13:39               ` Russell King - ARM Linux admin
2019-09-17 15:17               ` Russell King - ARM Linux admin
2019-09-17 15:17                 ` Russell King - ARM Linux admin
2019-09-17 15:30                 ` Russell King - ARM Linux admin
2019-09-17 15:30                   ` Russell King - ARM Linux admin
2019-09-17 16:34                   ` tinywrkb
2019-09-17 16:34                     ` tinywrkb
2019-09-17 17:04                     ` Russell King - ARM Linux admin
2019-09-17 17:04                       ` Russell King - ARM Linux admin
2019-09-17 17:19                       ` Russell King - ARM Linux admin
2019-09-17 17:19                         ` Russell King - ARM Linux admin
2019-09-17 17:26                         ` Andrew Lunn
2019-09-17 17:26                           ` Andrew Lunn
2019-09-17 17:37                           ` Russell King - ARM Linux admin [this message]
2019-09-17 17:37                             ` Russell King - ARM Linux admin
2019-09-17 18:19                             ` Russell King - ARM Linux admin
2019-09-17 18:19                               ` Russell King - ARM Linux admin
2019-09-17 18:39                               ` Andrew Lunn
2019-09-17 18:39                                 ` Andrew Lunn
2019-09-20 10:36                                 ` Russell King - ARM Linux admin
2019-09-20 10:36                                   ` Russell King - ARM Linux admin
2019-09-17 21:42                         ` Russell King - ARM Linux admin
2019-09-17 21:42                           ` Russell King - ARM Linux admin
2019-09-20 13:42                           ` Russell King - ARM Linux admin
2019-09-20 13:42                             ` Russell King - ARM Linux admin
2019-09-17 22:30             ` Russell King - ARM Linux admin
2019-09-17 22:30               ` Russell King - ARM Linux admin
2019-09-17 22:43               ` Russell King - ARM Linux admin
2019-09-17 22:43                 ` Russell King - ARM Linux admin
2019-09-18 14:45                 ` tinywrkb
2019-09-18 14:45                   ` tinywrkb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917173728.GZ25745@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=baruch@tkos.co.il \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tinywrkb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.