All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: John Dorminy <jdorminy@redhat.com>
Cc: lvm-devel@redhat.com, Christoph Hellwig <hch@infradead.org>,
	device-mapper development <dm-devel@redhat.com>,
	Zdenek Kabelac <zkabelac@redhat.com>,
	Milan Broz <gmazyland@gmail.com>
Subject: Re: dm: introduce DM_GET_TARGET_VERSION
Date: Tue, 17 Sep 2019 16:08:28 -0400	[thread overview]
Message-ID: <20190917200827.GA5042@redhat.com> (raw)
In-Reply-To: <CAMeeMh_cq=F3JRZQrLbXA8=DkrvWD7qWNrNyBZdLarWWKcZXAQ@mail.gmail.com>

On Tue, Sep 17 2019 at 11:44am -0400,
John Dorminy <jdorminy@redhat.com> wrote:

>    Makes sense, sorry I missed that detail.
> 
>    Might it be better to just extend 'dmsetup targets' to take an optional
>    target-name parameter? When I saw this change, I thought 'dmsetup targets
>    <name>' surely worked already for the purpose, and was somewhat surprised
>    when experiment disagreed. Then list_versions() has much the same code
>    change as in this change, there's a little change in validate_params(),
>    and it seems less surprising (to me) to extend the existing
>    target-information-printing dmsetup command than to add another one.

No, I don't think it better to extend 'dmsetup targets'.  There is
little to be gained in doing so.

The DM_GET_TARGET_VERSION ioctl's implementation happens to be shared
with the DM_LIST_VERSIONS ioctl (used by 'dmsetup targets') but that
doesn't imply DM_LIST_VERSIONS should be extended instead.

This is a simple change that enables userspace to accomplish a specific
goal without altering an established DM ioctl.

--
lvm-devel mailing list
lvm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/lvm-devel

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: dm: introduce DM_GET_TARGET_VERSION
Date: Tue, 17 Sep 2019 16:08:28 -0400	[thread overview]
Message-ID: <20190917200827.GA5042@redhat.com> (raw)
In-Reply-To: <CAMeeMh_cq=F3JRZQrLbXA8=DkrvWD7qWNrNyBZdLarWWKcZXAQ@mail.gmail.com>

On Tue, Sep 17 2019 at 11:44am -0400,
John Dorminy <jdorminy@redhat.com> wrote:

>    Makes sense, sorry I missed that detail.
> 
>    Might it be better to just extend 'dmsetup targets' to take an optional
>    target-name parameter? When I saw this change, I thought 'dmsetup targets
>    <name>' surely worked already for the purpose, and was somewhat surprised
>    when experiment disagreed. Then list_versions() has much the same code
>    change as in this change, there's a little change in validate_params(),
>    and it seems less surprising (to me) to extend the existing
>    target-information-printing dmsetup command than to add another one.

No, I don't think it better to extend 'dmsetup targets'.  There is
little to be gained in doing so.

The DM_GET_TARGET_VERSION ioctl's implementation happens to be shared
with the DM_LIST_VERSIONS ioctl (used by 'dmsetup targets') but that
doesn't imply DM_LIST_VERSIONS should be extended instead.

This is a simple change that enables userspace to accomplish a specific
goal without altering an established DM ioctl.



  reply	other threads:[~2019-09-17 20:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-16  9:55 [PATCH] dm: introduce DM_GET_TARGET_VERSION Mikulas Patocka
2019-09-16  9:55 ` Mikulas Patocka
2019-09-16  9:58 ` [PATCH] lvm: " Mikulas Patocka
2019-09-16  9:58   ` Mikulas Patocka
2019-09-16 14:21 ` dm: " Mike Snitzer
2019-09-16 14:21   ` Mike Snitzer
2019-09-16 18:01 ` [PATCH] " Christoph Hellwig
2019-09-16 18:01   ` [dm-devel] " Christoph Hellwig
2019-09-16 18:16   ` Milan Broz
2019-09-16 18:16     ` [dm-devel] " Milan Broz
2019-09-17  6:32     ` Christoph Hellwig
2019-09-17  6:32       ` [dm-devel] " Christoph Hellwig
2019-09-17 13:39       ` Mike Snitzer
2019-09-17 13:39         ` Mike Snitzer
2019-09-17 13:56     ` [PATCH] " John Dorminy
2019-09-17 13:56       ` [dm-devel] " John Dorminy
2019-09-17 14:06       ` Mike Snitzer
2019-09-17 14:06         ` Mike Snitzer
2019-09-17 15:38         ` Mikulas Patocka
2019-09-17 15:38           ` Mikulas Patocka
2019-09-17 15:44           ` John Dorminy
2019-09-17 15:44             ` John Dorminy
2019-09-17 20:08             ` Mike Snitzer [this message]
2019-09-17 20:08               ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190917200827.GA5042@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=hch@infradead.org \
    --cc=jdorminy@redhat.com \
    --cc=lvm-devel@redhat.com \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.