* [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable
@ 2019-09-18 1:39 srinivasan.s
2019-09-18 2:30 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: srinivasan.s @ 2019-09-18 1:39 UTC (permalink / raw)
To: intel-gfx, jani.nikula, manasi.d.navare, ville.syrjala, dri-devel
Cc: Srinivasan S
From: Srinivasan S <srinivasan.s@intel.com>
This patch avoids DP MST payload error message in dmesg, as it is trying
to read the payload from the disconnected DP MST device. After the unplug
the connector status is disconnected and we should not be looking for the
payload and hence remove the error and throw the warning.
This details can be found in:
https://bugs.freedesktop.org/show_bug.cgi?id=111632
Signed-off-by: Srinivasan S <srinivasan.s@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
index eeeb3f933aa4..5b2278fdf675 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
@@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder,
ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr);
if (ret) {
- DRM_ERROR("failed to update payload %d\n", ret);
+ if (!connector ||
+ connector->base.status != connector_status_connected) {
+ DRM_WARN("DP MST disconnect\n");
+ } else {
+ DRM_ERROR("failed to update payload %d\n", ret);
+ }
}
if (old_crtc_state->has_audio)
intel_audio_codec_disable(encoder,
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 1:39 [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable srinivasan.s @ 2019-09-18 2:30 ` Patchwork 2019-09-18 12:16 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-09-18 17:50 ` [PATCH] " Manasi Navare 2 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-09-18 2:30 UTC (permalink / raw) To: srinivasan.s; +Cc: intel-gfx == Series Details == Series: drm/i915/dp: Fix DP MST error after unplugging TypeC cable URL : https://patchwork.freedesktop.org/series/66837/ State : success == Summary == CI Bug Log - changes from CI_DRM_6911 -> Patchwork_14437 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/ Known issues ------------ Here are the changes found in Patchwork_14437 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@core_auth@basic-auth: - fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-icl-u3/igt@core_auth@basic-auth.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-icl-u3/igt@core_auth@basic-auth.html * igt@i915_module_load@reload: - fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724] / [fdo#111214]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-icl-u3/igt@i915_module_load@reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-icl-u3/igt@i915_module_load@reload.html * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: [PASS][5] -> [FAIL][6] ([fdo#108511]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html * igt@kms_chamelium@hdmi-edid-read: - fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-icl-u2/igt@kms_chamelium@hdmi-edid-read.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - fi-blb-e6850: [PASS][9] -> [INCOMPLETE][10] ([fdo#107718]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-blb-e6850/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html #### Possible fixes #### * igt@gem_mmap_gtt@basic-write-no-prefault: - fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-icl-u3/igt@gem_mmap_gtt@basic-write-no-prefault.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html * igt@kms_prop_blob@basic: - {fi-icl-u4}: [DMESG-WARN][15] ([fdo#105602]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/fi-icl-u4/igt@kms_prop_blob@basic.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/fi-icl-u4/igt@kms_prop_blob@basic.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602 [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718 [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724 [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511 [fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483 [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045 [fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214 [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 Participating hosts (54 -> 47) ------------------------------ Additional (1): fi-icl-guc Missing (8): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6911 -> Patchwork_14437 CI-20190529: 20190529 CI_DRM_6911: 2e04def5afc3b2bd724dc6f3f6525c5ebf1f87d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5189: c78b9959fa4050725b16d55a5e56315884a2753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14437: 90e757d078d4105644a710ee872565da671ddc9e @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 90e757d078d4 drm/i915/dp: Fix DP MST error after unplugging TypeC cable == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 1:39 [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable srinivasan.s 2019-09-18 2:30 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2019-09-18 12:16 ` Patchwork 2019-09-18 17:50 ` [PATCH] " Manasi Navare 2 siblings, 0 replies; 15+ messages in thread From: Patchwork @ 2019-09-18 12:16 UTC (permalink / raw) To: srinivasan.s; +Cc: intel-gfx == Series Details == Series: drm/i915/dp: Fix DP MST error after unplugging TypeC cable URL : https://patchwork.freedesktop.org/series/66837/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6911_full -> Patchwork_14437_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_14437_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_14437_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_14437_full: ### Piglit changes ### #### Possible regressions #### * spec@!opengl 1.1@copypixels-sync (NEW): - pig-hsw-4770r: NOTRUN -> [FAIL][1] [1]: None New tests --------- New tests have been introduced between CI_DRM_6911_full and Patchwork_14437_full: ### New Piglit tests (1) ### * spec@!opengl 1.1@copypixels-sync: - Statuses : 1 fail(s) - Exec time: [11.18] s Known issues ------------ Here are the changes found in Patchwork_14437_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@close-race: - shard-snb: [PASS][2] -> [INCOMPLETE][3] ([fdo#105411]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-snb2/igt@gem_busy@close-race.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-snb1/igt@gem_busy@close-race.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#110841]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb4/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_schedule@in-order-bsd: - shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#111325]) +2 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb3/igt@gem_exec_schedule@in-order-bsd.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb1/igt@gem_exec_schedule@in-order-bsd.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-iclb: [PASS][8] -> [INCOMPLETE][9] ([fdo#107713]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic: - shard-glk: [PASS][10] -> [FAIL][11] ([fdo#104873]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-glk1/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-glk4/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic: - shard-hsw: [PASS][12] -> [FAIL][13] ([fdo#105767]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html * igt@kms_cursor_legacy@cursora-vs-flipa-toggle: - shard-apl: [PASS][14] -> [INCOMPLETE][15] ([fdo#103927]) +3 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-apl6/igt@kms_cursor_legacy@cursora-vs-flipa-toggle.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-apl2/igt@kms_cursor_legacy@cursora-vs-flipa-toggle.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-hsw: [PASS][16] -> [INCOMPLETE][17] ([fdo#103540]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-hsw7/igt@kms_flip@flip-vs-suspend-interruptible.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-hsw6/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move: - shard-iclb: [PASS][18] -> [FAIL][19] ([fdo#103167]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt: - shard-iclb: [PASS][20] -> [INCOMPLETE][21] ([fdo#106978] / [fdo#107713]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-msflip-blt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render: - shard-skl: [PASS][22] -> [FAIL][23] ([fdo#103167]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: - shard-apl: [PASS][24] -> [DMESG-WARN][25] ([fdo#108566]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-apl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: - shard-skl: [PASS][26] -> [INCOMPLETE][27] ([fdo#104108]) +1 similar issue [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html * igt@kms_plane_lowres@pipe-a-tiling-y: - shard-iclb: [PASS][28] -> [FAIL][29] ([fdo#103166]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb4/igt@kms_plane_lowres@pipe-a-tiling-y.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: [PASS][30] -> [SKIP][31] ([fdo#109441]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@prime_busy@hang-bsd2: - shard-iclb: [PASS][32] -> [SKIP][33] ([fdo#109276]) +30 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb1/igt@prime_busy@hang-bsd2.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb3/igt@prime_busy@hang-bsd2.html #### Possible fixes #### * igt@gem_eio@reset-stress: - shard-glk: [FAIL][34] ([fdo#109661]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-glk8/igt@gem_eio@reset-stress.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-glk5/igt@gem_eio@reset-stress.html * igt@gem_exec_balancer@nop: - shard-apl: [INCOMPLETE][36] ([fdo#103927]) -> [PASS][37] +1 similar issue [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-apl8/igt@gem_exec_balancer@nop.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-apl7/igt@gem_exec_balancer@nop.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [SKIP][38] ([fdo#111325]) -> [PASS][39] +8 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_workarounds@suspend-resume: - shard-skl: [INCOMPLETE][40] ([fdo#104108]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl2/igt@gem_workarounds@suspend-resume.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl7/igt@gem_workarounds@suspend-resume.html * igt@gem_workarounds@suspend-resume-context: - shard-apl: [DMESG-WARN][42] ([fdo#108566]) -> [PASS][43] +8 similar issues [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-apl4/igt@gem_workarounds@suspend-resume-context.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-apl2/igt@gem_workarounds@suspend-resume-context.html * igt@kms_color@pipe-b-ctm-green-to-red: - shard-skl: [FAIL][44] ([fdo#107201]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl1/igt@kms_color@pipe-b-ctm-green-to-red.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl3/igt@kms_color@pipe-b-ctm-green-to-red.html * igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen: - shard-skl: [FAIL][46] ([fdo#103232]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl10/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl9/igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen.html * igt@kms_flip@flip-vs-expired-vblank: - shard-skl: [FAIL][48] ([fdo#105363]) -> [PASS][49] +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl6/igt@kms_flip@flip-vs-expired-vblank.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html * igt@kms_flip@flip-vs-expired-vblank-interruptible: - shard-kbl: [FAIL][50] ([fdo#105363]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-kbl4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-kbl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-iclb: [INCOMPLETE][52] ([fdo#107713] / [fdo#109507]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb3/igt@kms_flip@flip-vs-suspend-interruptible.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb8/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt: - shard-iclb: [FAIL][54] ([fdo#103167]) -> [PASS][55] +1 similar issue [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][56] ([fdo#108145] / [fdo#110403]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@no_drrs: - shard-iclb: [FAIL][58] ([fdo#108341]) -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb1/igt@kms_psr@no_drrs.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb7/igt@kms_psr@no_drrs.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][60] ([fdo#109441]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb8/igt@kms_psr@psr2_no_drrs.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@kms_psr@suspend: - shard-skl: [INCOMPLETE][62] ([fdo#108972]) -> [PASS][63] [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-skl5/igt@kms_psr@suspend.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-skl5/igt@kms_psr@suspend.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [SKIP][64] ([fdo#109276]) -> [PASS][65] +15 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb4/igt@prime_vgem@fence-wait-bsd2.html #### Warnings #### * igt@gem_mocs_settings@mocs-settings-bsd2: - shard-iclb: [SKIP][66] ([fdo#109276]) -> [FAIL][67] ([fdo#111330]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6911/shard-iclb5/igt@gem_mocs_settings@mocs-settings-bsd2.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166 [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167 [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232 [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540 [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927 [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108 [fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873 [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363 [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411 [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767 [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978 [fdo#107201]: https://bugs.freedesktop.org/show_bug.cgi?id=107201 [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341 [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566 [fdo#108972]: https://bugs.freedesktop.org/show_bug.cgi?id=108972 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507 [fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661 [fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325 [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330 [fdo#111716]: https://bugs.freedesktop.org/show_bug.cgi?id=111716 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_6911 -> Patchwork_14437 CI-20190529: 20190529 CI_DRM_6911: 2e04def5afc3b2bd724dc6f3f6525c5ebf1f87d2 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5189: c78b9959fa4050725b16d55a5e56315884a2753d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_14437: 90e757d078d4105644a710ee872565da671ddc9e @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14437/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 1:39 [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable srinivasan.s 2019-09-18 2:30 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-18 12:16 ` ✗ Fi.CI.IGT: failure " Patchwork @ 2019-09-18 17:50 ` Manasi Navare 2019-09-18 18:11 ` Ville Syrjälä 2019-09-19 12:18 ` Jani Nikula 2 siblings, 2 replies; 15+ messages in thread From: Manasi Navare @ 2019-09-18 17:50 UTC (permalink / raw) To: srinivasan.s; +Cc: dri-devel, intel-gfx On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > From: Srinivasan S <srinivasan.s@intel.com> > > This patch avoids DP MST payload error message in dmesg, as it is trying > to read the payload from the disconnected DP MST device. After the unplug > the connector status is disconnected and we should not be looking for the > payload and hence remove the error and throw the warning. > > This details can be found in: > https://bugs.freedesktop.org/show_bug.cgi?id=111632 Please add this link as Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign off statement > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index eeeb3f933aa4..5b2278fdf675 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { > - DRM_ERROR("failed to update payload %d\n", ret); > + if (!connector || > + connector->base.status != connector_status_connected) { > + DRM_WARN("DP MST disconnect\n"); May be adding this check before calling drm_dp_update_payload_part1() is a better idea? If the connector is disconnected, why update payload? Jani, Ville, thoughts? Regards Manasi > + } else { > + DRM_ERROR("failed to update payload %d\n", ret); > + } > } > if (old_crtc_state->has_audio) > intel_audio_codec_disable(encoder, > -- > 2.7.4 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 17:50 ` [PATCH] " Manasi Navare @ 2019-09-18 18:11 ` Ville Syrjälä 2019-09-18 18:25 ` Manasi Navare 2019-09-19 12:18 ` Jani Nikula 1 sibling, 1 reply; 15+ messages in thread From: Ville Syrjälä @ 2019-09-18 18:11 UTC (permalink / raw) To: Manasi Navare; +Cc: srinivasan.s, intel-gfx, dri-devel On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > From: Srinivasan S <srinivasan.s@intel.com> > > > > This patch avoids DP MST payload error message in dmesg, as it is trying > > to read the payload from the disconnected DP MST device. After the unplug > > the connector status is disconnected and we should not be looking for the > > payload and hence remove the error and throw the warning. > > > > This details can be found in: > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > Please add this link as Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign off > statement > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > --- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > index eeeb3f933aa4..5b2278fdf675 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > if (ret) { > > - DRM_ERROR("failed to update payload %d\n", ret); > > + if (!connector || > > + connector->base.status != connector_status_connected) { > > + DRM_WARN("DP MST disconnect\n"); > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > If the connector is disconnected, why update payload? > > Jani, Ville, thoughts? Or just convert it to a debug? > > Regards > Manasi > > > + } else { > > + DRM_ERROR("failed to update payload %d\n", ret); > > + } > > } > > if (old_crtc_state->has_audio) > > intel_audio_codec_disable(encoder, > > -- > > 2.7.4 > > -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 18:11 ` Ville Syrjälä @ 2019-09-18 18:25 ` Manasi Navare 2019-09-19 7:23 ` S, Srinivasan 0 siblings, 1 reply; 15+ messages in thread From: Manasi Navare @ 2019-09-18 18:25 UTC (permalink / raw) To: Ville Syrjälä; +Cc: intel-gfx, dri-devel On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > This patch avoids DP MST payload error message in dmesg, as it is trying > > > to read the payload from the disconnected DP MST device. After the unplug > > > the connector status is disconnected and we should not be looking for the > > > payload and hence remove the error and throw the warning. > > > > > > This details can be found in: > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > Please add this link as Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign off > > statement > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > if (ret) { > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > + if (!connector || > > > + connector->base.status != connector_status_connected) { > > > + DRM_WARN("DP MST disconnect\n"); > > > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > > If the connector is disconnected, why update payload? > > > > Jani, Ville, thoughts? > > Or just convert it to a debug? Sure that will work, but do we really want to update the payload if the connector status is disconnected. So shouldnt checking that before calling the function be a better fix? Manasi > > > > > Regards > > Manasi > > > > > + } else { > > > + DRM_ERROR("failed to update payload %d\n", ret); > > > + } > > > } > > > if (old_crtc_state->has_audio) > > > intel_audio_codec_disable(encoder, > > > -- > > > 2.7.4 > > > > > -- > Ville Syrjälä > Intel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 18:25 ` Manasi Navare @ 2019-09-19 7:23 ` S, Srinivasan 2019-09-19 12:03 ` Ville Syrjälä 0 siblings, 1 reply; 15+ messages in thread From: S, Srinivasan @ 2019-09-19 7:23 UTC (permalink / raw) To: Navare, Manasi D, Ville Syrjälä Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Would the following be appropriate fix? if (connector || connector->base.status == connector_status_connected) { ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { DRM_ERROR("failed to update payload %d\n", ret); } } Regards, -----Original Message----- From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Manasi Navare Sent: Wednesday, September 18, 2019 11:55 PM To: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: S, Srinivasan <srinivasan.s@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > This patch avoids DP MST payload error message in dmesg, as it is > > > trying to read the payload from the disconnected DP MST device. > > > After the unplug the connector status is disconnected and we > > > should not be looking for the payload and hence remove the error and throw the warning. > > > > > > This details can be found in: > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > Please add this link as Bugzilla: > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign > > off statement > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct > > > intel_encoder *encoder, > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > if (ret) { > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > + if (!connector || > > > + connector->base.status != connector_status_connected) { > > > + DRM_WARN("DP MST disconnect\n"); > > > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > > If the connector is disconnected, why update payload? > > > > Jani, Ville, thoughts? > > Or just convert it to a debug? Sure that will work, but do we really want to update the payload if the connector status is disconnected. So shouldnt checking that before calling the function be a better fix? Manasi > > > > > Regards > > Manasi > > > > > + } else { > > > + DRM_ERROR("failed to update payload %d\n", ret); > > > + } > > > } > > > if (old_crtc_state->has_audio) > > > intel_audio_codec_disable(encoder, > > > -- > > > 2.7.4 > > > > > -- > Ville Syrjälä > Intel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-19 7:23 ` S, Srinivasan @ 2019-09-19 12:03 ` Ville Syrjälä 2019-09-19 13:52 ` S, Srinivasan 0 siblings, 1 reply; 15+ messages in thread From: Ville Syrjälä @ 2019-09-19 12:03 UTC (permalink / raw) To: S, Srinivasan Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org On Thu, Sep 19, 2019 at 07:23:30AM +0000, S, Srinivasan wrote: > Would the following be appropriate fix? > > if (connector || connector->base.status == connector_status_connected) { > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { > DRM_ERROR("failed to update payload %d\n", ret); > } > } The whole connector->status check is racy. IMO don't do it. > > Regards, > -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Manasi Navare > Sent: Wednesday, September 18, 2019 11:55 PM > To: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: S, Srinivasan <srinivasan.s@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable > > On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > > > This patch avoids DP MST payload error message in dmesg, as it is > > > > trying to read the payload from the disconnected DP MST device. > > > > After the unplug the connector status is disconnected and we > > > > should not be looking for the payload and hence remove the error and throw the warning. > > > > > > > > This details can be found in: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > > > Please add this link as Bugzilla: > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign > > > off statement > > > > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct > > > > intel_encoder *encoder, > > > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > > if (ret) { > > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > > + if (!connector || > > > > + connector->base.status != connector_status_connected) { > > > > + DRM_WARN("DP MST disconnect\n"); > > > > > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > > > If the connector is disconnected, why update payload? > > > > > > Jani, Ville, thoughts? > > > > Or just convert it to a debug? > > Sure that will work, but do we really want to update the payload if the connector status is disconnected. > So shouldnt checking that before calling the function be a better fix? > > Manasi > > > > > > > > > Regards > > > Manasi > > > > > > > + } else { > > > > + DRM_ERROR("failed to update payload %d\n", ret); > > > > + } > > > > } > > > > if (old_crtc_state->has_audio) > > > > intel_audio_codec_disable(encoder, > > > > -- > > > > 2.7.4 > > > > > > > > -- > > Ville Syrjälä > > Intel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-19 12:03 ` Ville Syrjälä @ 2019-09-19 13:52 ` S, Srinivasan 2019-09-25 15:02 ` S, Srinivasan 0 siblings, 1 reply; 15+ messages in thread From: S, Srinivasan @ 2019-09-19 13:52 UTC (permalink / raw) To: Ville Syrjälä Cc: Navare, Manasi D, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Then it's better that, could we change it to DRM_DEBUG_KMS("failed to update payload %d\n", ret); instead of DRM_ERROR("failed to update payload %d\n", ret);, without any connector status check, would that be fine? Regards, -----Original Message----- From: Ville Syrjälä <ville.syrjala@linux.intel.com> Sent: Thursday, September 19, 2019 5:34 PM To: S, Srinivasan <srinivasan.s@intel.com> Cc: Navare, Manasi D <manasi.d.navare@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable On Thu, Sep 19, 2019 at 07:23:30AM +0000, S, Srinivasan wrote: > Would the following be appropriate fix? > > if (connector || connector->base.status == connector_status_connected) { > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { > DRM_ERROR("failed to update payload %d\n", ret); > } > } The whole connector->status check is racy. IMO don't do it. > > Regards, > -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of > Manasi Navare > Sent: Wednesday, September 18, 2019 11:55 PM > To: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: S, Srinivasan <srinivasan.s@intel.com>; > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging > TypeC cable > > On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > > > This patch avoids DP MST payload error message in dmesg, as it > > > > is trying to read the payload from the disconnected DP MST device. > > > > After the unplug the connector status is disconnected and we > > > > should not be looking for the payload and hence remove the error and throw the warning. > > > > > > > > This details can be found in: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > > > Please add this link as Bugzilla: > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign > > > off statement > > > > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct > > > > intel_encoder *encoder, > > > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > > if (ret) { > > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > > + if (!connector || > > > > + connector->base.status != connector_status_connected) { > > > > + DRM_WARN("DP MST disconnect\n"); > > > > > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > > > If the connector is disconnected, why update payload? > > > > > > Jani, Ville, thoughts? > > > > Or just convert it to a debug? > > Sure that will work, but do we really want to update the payload if the connector status is disconnected. > So shouldnt checking that before calling the function be a better fix? > > Manasi > > > > > > > > > Regards > > > Manasi > > > > > > > + } else { > > > > + DRM_ERROR("failed to update payload %d\n", ret); > > > > + } > > > > } > > > > if (old_crtc_state->has_audio) > > > > intel_audio_codec_disable(encoder, > > > > -- > > > > 2.7.4 > > > > > > > > -- > > Ville Syrjälä > > Intel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-19 13:52 ` S, Srinivasan @ 2019-09-25 15:02 ` S, Srinivasan 2019-09-30 20:06 ` S, Srinivasan 0 siblings, 1 reply; 15+ messages in thread From: S, Srinivasan @ 2019-09-25 15:02 UTC (permalink / raw) To: 'Ville Syrjälä' Cc: 'intel-gfx@lists.freedesktop.org', 'dri-devel@lists.freedesktop.org' Hi Ville, I have revised the patch from DRM_ERROR to DRM_DEBUG, could you please review? https://patchwork.freedesktop.org/patch/332806/?series=66837&rev=3 Thanks, -----Original Message----- From: S, Srinivasan Sent: Thursday, September 19, 2019 7:22 PM To: 'Ville Syrjälä' <ville.syrjala@linux.intel.com> Cc: Navare, Manasi D <manasi.d.navare@intel.com>; 'intel-gfx@lists.freedesktop.org' <intel-gfx@lists.freedesktop.org>; 'dri-devel@lists.freedesktop.org' <dri-devel@lists.freedesktop.org> Subject: RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable Then it's better that, could we change it to DRM_DEBUG_KMS("failed to update payload %d\n", ret); instead of DRM_ERROR("failed to update payload %d\n", ret);, without any connector status check, would that be fine? Regards, -----Original Message----- From: Ville Syrjälä <ville.syrjala@linux.intel.com> Sent: Thursday, September 19, 2019 5:34 PM To: S, Srinivasan <srinivasan.s@intel.com> Cc: Navare, Manasi D <manasi.d.navare@intel.com>; intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable On Thu, Sep 19, 2019 at 07:23:30AM +0000, S, Srinivasan wrote: > Would the following be appropriate fix? > > if (connector || connector->base.status == connector_status_connected) { > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { > DRM_ERROR("failed to update payload %d\n", ret); > } > } The whole connector->status check is racy. IMO don't do it. > > Regards, > -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of > Manasi Navare > Sent: Wednesday, September 18, 2019 11:55 PM > To: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: S, Srinivasan <srinivasan.s@intel.com>; > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging > TypeC cable > > On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: > > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > > > This patch avoids DP MST payload error message in dmesg, as it > > > > is trying to read the payload from the disconnected DP MST device. > > > > After the unplug the connector status is disconnected and we > > > > should not be looking for the payload and hence remove the error and throw the warning. > > > > > > > > This details can be found in: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > > > Please add this link as Bugzilla: > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign > > > off statement > > > > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct > > > > intel_encoder *encoder, > > > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > > if (ret) { > > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > > + if (!connector || > > > > + connector->base.status != connector_status_connected) { > > > > + DRM_WARN("DP MST disconnect\n"); > > > > > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > > > If the connector is disconnected, why update payload? > > > > > > Jani, Ville, thoughts? > > > > Or just convert it to a debug? > > Sure that will work, but do we really want to update the payload if the connector status is disconnected. > So shouldnt checking that before calling the function be a better fix? > > Manasi > > > > > > > > > Regards > > > Manasi > > > > > > > + } else { > > > > + DRM_ERROR("failed to update payload %d\n", ret); > > > > + } > > > > } > > > > if (old_crtc_state->has_audio) > > > > intel_audio_codec_disable(encoder, > > > > -- > > > > 2.7.4 > > > > > > > > -- > > Ville Syrjälä > > Intel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-25 15:02 ` S, Srinivasan @ 2019-09-30 20:06 ` S, Srinivasan 0 siblings, 0 replies; 15+ messages in thread From: S, Srinivasan @ 2019-09-30 20:06 UTC (permalink / raw) To: 'intel-gfx@lists.freedesktop.org' Cc: Navare, Manasi D, 'dri-devel@lists.freedesktop.org' Could anyone please review the patch below & let me know if any other ideas please? https://patchwork.freedesktop.org/patch/332806/?series=66837&rev=3 Thanks, > -----Original Message----- > From: S, Srinivasan > Sent: Wednesday, September 25, 2019 8:33 PM > To: 'Ville Syrjälä' <ville.syrjala@linux.intel.com> > Cc: Navare, Manasi D <manasi.d.navare@intel.com>; 'intel- > gfx@lists.freedesktop.org' <intel-gfx@lists.freedesktop.org>; 'dri- > devel@lists.freedesktop.org' <dri-devel@lists.freedesktop.org> > Subject: RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC > cable > > Hi Ville, > > I have revised the patch from DRM_ERROR to DRM_DEBUG, could you please > review? > > https://patchwork.freedesktop.org/patch/332806/?series=66837&rev=3 > > Thanks, > > -----Original Message----- > From: S, Srinivasan > Sent: Thursday, September 19, 2019 7:22 PM > To: 'Ville Syrjälä' <ville.syrjala@linux.intel.com> > Cc: Navare, Manasi D <manasi.d.navare@intel.com>; 'intel- > gfx@lists.freedesktop.org' <intel-gfx@lists.freedesktop.org>; 'dri- > devel@lists.freedesktop.org' <dri-devel@lists.freedesktop.org> > Subject: RE: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC > cable > > Then it's better that, could we change it to DRM_DEBUG_KMS("failed to update > payload %d\n", ret); instead of DRM_ERROR("failed to update payload %d\n", > ret);, without any connector status check, would that be fine? > > Regards, > -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: Thursday, September 19, 2019 5:34 PM > To: S, Srinivasan <srinivasan.s@intel.com> > Cc: Navare, Manasi D <manasi.d.navare@intel.com>; intel- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC > cable > > On Thu, Sep 19, 2019 at 07:23:30AM +0000, S, Srinivasan wrote: > > Would the following be appropriate fix? > > > > if (connector || connector->base.status == connector_status_connected) > { > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > if (ret) { > > DRM_ERROR("failed to update payload %d\n", ret); > > } > > } > > The whole connector->status check is racy. IMO don't do it. > > > > > Regards, > > -----Original Message----- > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of > > Manasi Navare > > Sent: Wednesday, September 18, 2019 11:55 PM > > To: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: S, Srinivasan <srinivasan.s@intel.com>; > > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging > > TypeC cable > > > > On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > > > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com > wrote: > > > > > From: Srinivasan S <srinivasan.s@intel.com> > > > > > > > > > > This patch avoids DP MST payload error message in dmesg, as it > > > > > is trying to read the payload from the disconnected DP MST device. > > > > > After the unplug the connector status is disconnected and we > > > > > should not be looking for the payload and hence remove the error and > throw the warning. > > > > > > > > > > This details can be found in: > > > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > > > > > > > Please add this link as Bugzilla: > > > > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign > > > > off statement > > > > > > > > > > > > > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > > > > --- > > > > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- > > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > > index eeeb3f933aa4..5b2278fdf675 100644 > > > > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > > > > @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct > > > > > intel_encoder *encoder, > > > > > > > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > > > > if (ret) { > > > > > - DRM_ERROR("failed to update payload %d\n", ret); > > > > > + if (!connector || > > > > > + connector->base.status != > connector_status_connected) { > > > > > + DRM_WARN("DP MST disconnect\n"); > > > > > > > > May be adding this check before calling drm_dp_update_payload_part1() is > a better idea? > > > > If the connector is disconnected, why update payload? > > > > > > > > Jani, Ville, thoughts? > > > > > > Or just convert it to a debug? > > > > Sure that will work, but do we really want to update the payload if the > connector status is disconnected. > > So shouldnt checking that before calling the function be a better fix? > > > > Manasi > > > > > > > > > > > > > Regards > > > > Manasi > > > > > > > > > + } else { > > > > > + DRM_ERROR("failed to update payload %d\n", > ret); > > > > > + } > > > > > } > > > > > if (old_crtc_state->has_audio) > > > > > intel_audio_codec_disable(encoder, > > > > > -- > > > > > 2.7.4 > > > > > > > > > > > -- > > > Ville Syrjälä > > > Intel > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > -- > Ville Syrjälä > Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-18 17:50 ` [PATCH] " Manasi Navare 2019-09-18 18:11 ` Ville Syrjälä @ 2019-09-19 12:18 ` Jani Nikula 1 sibling, 0 replies; 15+ messages in thread From: Jani Nikula @ 2019-09-19 12:18 UTC (permalink / raw) To: Manasi Navare, srinivasan.s; +Cc: intel-gfx, dri-devel On Wed, 18 Sep 2019, Manasi Navare <manasi.d.navare@intel.com> wrote: > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasan.s@intel.com wrote: >> From: Srinivasan S <srinivasan.s@intel.com> >> >> This patch avoids DP MST payload error message in dmesg, as it is trying >> to read the payload from the disconnected DP MST device. After the unplug >> the connector status is disconnected and we should not be looking for the >> payload and hence remove the error and throw the warning. >> >> This details can be found in: >> https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > Please add this link as Bugzilla: > https://bugs.freedesktop.org/show_bug.cgi?id=111632 after the Sign off > statement ITYM *before* Signed-off-by. But yeah, use the Bugzilla: tag, and please use git log to see plenty of examples. BR, Jani. > >> >> Signed-off-by: Srinivasan S <srinivasan.s@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_dp_mst.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c >> index eeeb3f933aa4..5b2278fdf675 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c >> @@ -215,7 +215,12 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, >> >> ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); >> if (ret) { >> - DRM_ERROR("failed to update payload %d\n", ret); >> + if (!connector || >> + connector->base.status != connector_status_connected) { >> + DRM_WARN("DP MST disconnect\n"); > > May be adding this check before calling drm_dp_update_payload_part1() is a better idea? > If the connector is disconnected, why update payload? > > Jani, Ville, thoughts? > > Regards > Manasi > >> + } else { >> + DRM_ERROR("failed to update payload %d\n", ret); >> + } >> } >> if (old_crtc_state->has_audio) >> intel_audio_codec_disable(encoder, >> -- >> 2.7.4 >> -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable @ 2019-09-25 0:35 srinivasan.s 2019-10-01 12:01 ` Ville Syrjälä 0 siblings, 1 reply; 15+ messages in thread From: srinivasan.s @ 2019-09-25 0:35 UTC (permalink / raw) To: intel-gfx, jani.nikula, manasi.d.navare, ville.syrjala, lakshminarayana.vudum, dri-devel Cc: Srinivasan S From: Srinivasan S <srinivasan.s@intel.com> This patch avoids DP MST payload error message in dmesg, as it is trying to update the payload to the disconnected DP MST device. After DP MST device is disconnected we should not be updating the payload and hence remove the error. v2: Removed the connector status check and converted from error to debug. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 Signed-off-by: Srinivasan S <srinivasan.s@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index eeeb3f933aa4..497a6ae0d2c0 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); if (ret) { - DRM_ERROR("failed to update payload %d\n", ret); + DRM_DEBUG_KMS("failed to update payload %d\n", ret); } if (old_crtc_state->has_audio) intel_audio_codec_disable(encoder, -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-09-25 0:35 srinivasan.s @ 2019-10-01 12:01 ` Ville Syrjälä 2019-10-01 12:45 ` S, Srinivasan 0 siblings, 1 reply; 15+ messages in thread From: Ville Syrjälä @ 2019-10-01 12:01 UTC (permalink / raw) To: srinivasan.s; +Cc: manasi.d.navare, intel-gfx, dri-devel, lakshminarayana.vudum On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasan.s@intel.com wrote: > From: Srinivasan S <srinivasan.s@intel.com> > > This patch avoids DP MST payload error message in dmesg, as it is trying > to update the payload to the disconnected DP MST device. After DP MST > device is disconnected we should not be updating the payload and > hence remove the error. > > v2: Removed the connector status check and converted from error to debug. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> Pushed to dinq. Thanks for the patch. PS. Next time please use --in-reply-to when sending an updated patch so that it's easier to keep track of the discussion. > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index eeeb3f933aa4..497a6ae0d2c0 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder *encoder, > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > if (ret) { > - DRM_ERROR("failed to update payload %d\n", ret); > + DRM_DEBUG_KMS("failed to update payload %d\n", ret); > } > if (old_crtc_state->has_audio) > intel_audio_codec_disable(encoder, > -- > 2.7.4 -- Ville Syrjälä Intel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable 2019-10-01 12:01 ` Ville Syrjälä @ 2019-10-01 12:45 ` S, Srinivasan 0 siblings, 0 replies; 15+ messages in thread From: S, Srinivasan @ 2019-10-01 12:45 UTC (permalink / raw) To: Ville Syrjälä, Navare, Manasi D, Kahola, Mika, Nikula, Jani, Vudum, Lakshminarayana Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Thanks a lot Manasi, Ville, Mika, Jani, Lakshmi, for all your time in reviewing this patch. Best Regards, > -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Ville > Syrjälä > Sent: Tuesday, October 1, 2019 5:31 PM > To: S, Srinivasan <srinivasan.s@intel.com> > Cc: Navare, Manasi D <manasi.d.navare@intel.com>; intel- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vudum, > Lakshminarayana <lakshminarayana.vudum@intel.com> > Subject: Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC > cable > > On Wed, Sep 25, 2019 at 06:05:42AM +0530, srinivasan.s@intel.com wrote: > > From: Srinivasan S <srinivasan.s@intel.com> > > > > This patch avoids DP MST payload error message in dmesg, as it is trying > > to update the payload to the disconnected DP MST device. After DP MST > > device is disconnected we should not be updating the payload and > > hence remove the error. > > > > v2: Removed the connector status check and converted from error to debug. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111632 > > Signed-off-by: Srinivasan S <srinivasan.s@intel.com> > > Pushed to dinq. Thanks for the patch. > > PS. Next time please use --in-reply-to when sending an updated patch > so that it's easier to keep track of the discussion. > > > --- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c > b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > index eeeb3f933aa4..497a6ae0d2c0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > > @@ -215,7 +215,7 @@ static void intel_mst_disable_dp(struct intel_encoder > *encoder, > > > > ret = drm_dp_update_payload_part1(&intel_dp->mst_mgr); > > if (ret) { > > - DRM_ERROR("failed to update payload %d\n", ret); > > + DRM_DEBUG_KMS("failed to update payload %d\n", ret); > > } > > if (old_crtc_state->has_audio) > > intel_audio_codec_disable(encoder, > > -- > > 2.7.4 > > -- > Ville Syrjälä > Intel > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-10-01 12:45 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-09-18 1:39 [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable srinivasan.s 2019-09-18 2:30 ` ✓ Fi.CI.BAT: success for " Patchwork 2019-09-18 12:16 ` ✗ Fi.CI.IGT: failure " Patchwork 2019-09-18 17:50 ` [PATCH] " Manasi Navare 2019-09-18 18:11 ` Ville Syrjälä 2019-09-18 18:25 ` Manasi Navare 2019-09-19 7:23 ` S, Srinivasan 2019-09-19 12:03 ` Ville Syrjälä 2019-09-19 13:52 ` S, Srinivasan 2019-09-25 15:02 ` S, Srinivasan 2019-09-30 20:06 ` S, Srinivasan 2019-09-19 12:18 ` Jani Nikula -- strict thread matches above, loose matches on Subject: below -- 2019-09-25 0:35 srinivasan.s 2019-10-01 12:01 ` Ville Syrjälä 2019-10-01 12:45 ` S, Srinivasan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.