From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Bill Wendling <morbo@google.com>
Cc: kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Orr" <marcorr@google.com>
Subject: Re: [PATCH] x86: remove memory constraint from "mov" instruction
Date: Thu, 19 Sep 2019 14:44:41 -0700 [thread overview]
Message-ID: <20190919214441.GH30495@linux.intel.com> (raw)
In-Reply-To: <20190912205944.120303-1-morbo@google.com>
+cc Paolo, Radim and Marc (to avoid saying the same thing twice)
I recommend having Paolo and Radim in the To: field when sending patches
for KVM or kvm-unit-tests, simply cc'ing the KVM list may not be enough to
ensure Paolo/Radim sees the patch.
https://lkml.kernel.org/r/0d59375c-9313-d31a-4af9-d68115e05d55@redhat.com
On Thu, Sep 12, 2019 at 01:59:44PM -0700, Bill Wendling wrote:
> Remove a bogus memory constraint as x86 does not have a generic
> memory-to-memory "mov" instruction.
>
> Signed-off-by: Bill Wendling <morbo@google.com>
For the actual patch:
Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> lib/x86/desc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/x86/desc.c b/lib/x86/desc.c
> index 5f37cef..451f504 100644
> --- a/lib/x86/desc.c
> +++ b/lib/x86/desc.c
> @@ -263,7 +263,7 @@ unsigned exception_error_code(void)
> {
> unsigned short error_code;
>
> - asm("mov %%gs:6, %0" : "=rm"(error_code));
> + asm("mov %%gs:6, %0" : "=r"(error_code));
> return error_code;
> }
>
> --
> 2.23.0.237.gc6a4ce50a0-goog
>
next prev parent reply other threads:[~2019-09-19 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 21:19 [kvm-unit-tests PATCH] x86: remove memory constraint from "mov" instruction Bill Wendling
2019-09-10 16:44 ` Jim Mattson
2019-09-11 19:08 ` Sean Christopherson
2019-09-11 22:35 ` Bill Wendling
2019-09-12 20:59 ` [PATCH] " Bill Wendling
2019-09-19 21:44 ` Sean Christopherson [this message]
2019-09-24 14:02 ` [kvm-unit-tests PATCH] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919214441.GH30495@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=morbo@google.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.