From: Tony Lindgren <tony@atomide.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
YueHaibing <yuehaibing@huawei.com>, Nishanth Menon <nm@ti.com>,
Tero Kristo <t-kristo@ti.com>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call
Date: Fri, 20 Sep 2019 14:24:44 +0000 [thread overview]
Message-ID: <20190920142444.GP5610@atomide.com> (raw)
In-Reply-To: <20190920122030.14340-1-colin.king@canonical.com>
* Colin King <colin.king@canonical.com> [190920 12:21]:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to pinctrl_count_index_with_args checks for a -EINVAL return
> however this function calls pinctrl_get_list_and_count and this can
> return -ENOENT. Rather than check for a specific error, fix this by
> checking for any error return to catch the -ENOENT case.
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Colin King <colin.king@canonical.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
YueHaibing <yuehaibing@huawei.com>, Nishanth Menon <nm@ti.com>,
Tero Kristo <t-kristo@ti.com>,
linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call
Date: Fri, 20 Sep 2019 07:24:44 -0700 [thread overview]
Message-ID: <20190920142444.GP5610@atomide.com> (raw)
In-Reply-To: <20190920122030.14340-1-colin.king@canonical.com>
* Colin King <colin.king@canonical.com> [190920 12:21]:
> From: Colin Ian King <colin.king@canonical.com>
>
> The call to pinctrl_count_index_with_args checks for a -EINVAL return
> however this function calls pinctrl_get_list_and_count and this can
> return -ENOENT. Rather than check for a specific error, fix this by
> checking for any error return to catch the -ENOENT case.
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2019-09-20 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 12:20 [PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with_args call Colin King
2019-09-20 12:20 ` Colin King
2019-09-20 14:24 ` Tony Lindgren [this message]
2019-09-20 14:24 ` Tony Lindgren
2019-10-04 21:09 ` Linus Walleij
2019-10-04 21:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920142444.GP5610@atomide.com \
--to=tony@atomide.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.