* [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-20 14:25 ` Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 14:25 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Florian Fainelli,
Pawel Dembicki, Vivien Didelot
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 16:17:18 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use devm_platform_ioremap_resource()
Return an error code as a constant
drivers/net/dsa/vitesse-vsc73xx-platform.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe()
2019-09-20 14:25 ` Markus Elfring
@ 2019-09-20 14:28 ` Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 14:28 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Florian Fainelli,
Pawel Dembicki, Vivien Didelot
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 15:23:39 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index 0541785f9fee..a3bbf9bd1bf1 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -89,7 +89,6 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct vsc73xx_platform *vsc_platform;
- struct resource *res = NULL;
int ret;
vsc_platform = devm_kzalloc(dev, sizeof(*vsc_platform), GFP_KERNEL);
@@ -101,16 +100,7 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
vsc_platform->vsc.dev = dev;
vsc_platform->vsc.priv = vsc_platform;
vsc_platform->vsc.ops = &vsc73xx_platform_ops;
-
- /* obtain I/O memory space */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "cannot obtain I/O memory space\n");
- ret = -ENXIO;
- return ret;
- }
-
- vsc_platform->base_addr = devm_ioremap_resource(&pdev->dev, res);
+ vsc_platform->base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsc_platform->base_addr)) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
ret = -ENXIO;
--
2.23.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe()
@ 2019-09-20 14:28 ` Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 14:28 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Florian Fainelli,
Pawel Dembicki, Vivien Didelot
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 15:23:39 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index 0541785f9fee..a3bbf9bd1bf1 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -89,7 +89,6 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct vsc73xx_platform *vsc_platform;
- struct resource *res = NULL;
int ret;
vsc_platform = devm_kzalloc(dev, sizeof(*vsc_platform), GFP_KERNEL);
@@ -101,16 +100,7 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
vsc_platform->vsc.dev = dev;
vsc_platform->vsc.priv = vsc_platform;
vsc_platform->vsc.ops = &vsc73xx_platform_ops;
-
- /* obtain I/O memory space */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "cannot obtain I/O memory space\n");
- ret = -ENXIO;
- return ret;
- }
-
- vsc_platform->base_addr = devm_ioremap_resource(&pdev->dev, res);
+ vsc_platform->base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsc_platform->base_addr)) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
ret = -ENXIO;
--
2.23.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe()
2019-09-20 14:28 ` Markus Elfring
@ 2019-09-20 15:08 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:08 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:28:00PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 15:23:39 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH 1/2] net: dsa: vsc73xx: Use devm_platform_ioremap_resource() in vsc73xx_platform_probe()
@ 2019-09-20 15:08 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:08 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:28:00PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 15:23:39 +0200
>
> Simplify this function implementation by using a known wrapper function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
2019-09-20 14:25 ` Markus Elfring
@ 2019-09-20 14:30 ` Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 14:30 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Florian Fainelli,
Pawel Dembicki, Vivien Didelot
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 16:07:07 +0200
* Return an error code without storing it in an intermediate variable.
* Delete the local variable “ret” which became unnecessary
with this refactoring.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index a3bbf9bd1bf1..0ae8d904ca85 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -89,7 +89,6 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct vsc73xx_platform *vsc_platform;
- int ret;
vsc_platform = devm_kzalloc(dev, sizeof(*vsc_platform), GFP_KERNEL);
if (!vsc_platform)
@@ -103,8 +102,7 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
vsc_platform->base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsc_platform->base_addr)) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
- ret = -ENXIO;
- return ret;
+ return -ENXIO;
}
return vsc73xx_probe(&vsc_platform->vsc);
--
2.23.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
@ 2019-09-20 14:30 ` Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 14:30 UTC (permalink / raw)
To: netdev, Andrew Lunn, David S. Miller, Florian Fainelli,
Pawel Dembicki, Vivien Didelot
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 20 Sep 2019 16:07:07 +0200
* Return an error code without storing it in an intermediate variable.
* Delete the local variable “ret” which became unnecessary
with this refactoring.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index a3bbf9bd1bf1..0ae8d904ca85 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -89,7 +89,6 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct vsc73xx_platform *vsc_platform;
- int ret;
vsc_platform = devm_kzalloc(dev, sizeof(*vsc_platform), GFP_KERNEL);
if (!vsc_platform)
@@ -103,8 +102,7 @@ static int vsc73xx_platform_probe(struct platform_device *pdev)
vsc_platform->base_addr = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(vsc_platform->base_addr)) {
dev_err(&pdev->dev, "cannot request I/O memory space\n");
- ret = -ENXIO;
- return ret;
+ return -ENXIO;
}
return vsc73xx_probe(&vsc_platform->vsc);
--
2.23.0
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
2019-09-20 14:30 ` Markus Elfring
@ 2019-09-20 15:08 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:08 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:30:13PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:07:07 +0200
>
> * Return an error code without storing it in an intermediate variable.
>
> * Delete the local variable “ret” which became unnecessary
> with this refactoring.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread* Re: [PATCH 2/2] net: dsa: vsc73xx: Return an error code as a constant in vsc73xx_platform_probe()
@ 2019-09-20 15:08 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:08 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:30:13PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:07:07 +0200
>
> * Return an error code without storing it in an intermediate variable.
>
> * Delete the local variable “ret” which became unnecessary
> with this refactoring.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
2019-09-20 14:25 ` Markus Elfring
@ 2019-09-20 15:09 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:09 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:25:53PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:17:18 +0200
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
netdev is closed at the moment for patch. Please repost once it
reopens, in about 2 weeks time.
Thanks
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-20 15:09 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2019-09-20 15:09 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, David S. Miller, Florian Fainelli, Pawel Dembicki,
Vivien Didelot, LKML, kernel-janitors
On Fri, Sep 20, 2019 at 04:25:53PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2019 16:17:18 +0200
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
netdev is closed at the moment for patch. Please repost once it
reopens, in about 2 weeks time.
Thanks
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
2019-09-20 15:09 ` Andrew Lunn
@ 2019-09-20 15:30 ` Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 15:30 UTC (permalink / raw)
To: Andrew Lunn, netdev
Cc: David S. Miller, Florian Fainelli, Pawel Dembicki, Vivien Didelot,
Linus Walleij, kernel-janitors, LKML
> netdev is closed at the moment for patch.
I wonder about this information.
> Please repost once it reopens, in about 2 weeks time.
I hope that the presented change possibilities can be integrated
in the near future also without a repetition of this small patch series.
https://lore.kernel.org/patchwork/project/lkml/list/?seriesA1271
Regards,
Markus
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-20 15:30 ` Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-20 15:30 UTC (permalink / raw)
To: Andrew Lunn, netdev
Cc: David S. Miller, Florian Fainelli, Pawel Dembicki, Vivien Didelot,
Linus Walleij, kernel-janitors, LKML
> netdev is closed at the moment for patch.
I wonder about this information.
> Please repost once it reopens, in about 2 weeks time.
I hope that the presented change possibilities can be integrated
in the near future also without a repetition of this small patch series.
https://lore.kernel.org/patchwork/project/lkml/list/?series=411271
Regards,
Markus
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
2019-09-20 15:30 ` Markus Elfring
@ 2019-09-20 16:36 ` Florian Fainelli
-1 siblings, 0 replies; 20+ messages in thread
From: Florian Fainelli @ 2019-09-20 16:36 UTC (permalink / raw)
To: Markus Elfring, Andrew Lunn, netdev
Cc: David S. Miller, Pawel Dembicki, Vivien Didelot, Linus Walleij,
kernel-janitors, LKML
On 9/20/19 8:30 AM, Markus Elfring wrote:
>> netdev is closed at the moment for patch.
>
> I wonder about this information.
This is covered here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40
and you can skip the reading and check this URL:
http://vger.kernel.org/~davem/net-next.html
>
>
>> Please repost once it reopens, in about 2 weeks time.
>
> I hope that the presented change possibilities can be integrated
> in the near future also without a repetition of this small patch series.
> https://lore.kernel.org/patchwork/project/lkml/list/?seriesA1271
You will have to resend it, and unless a bug fix comes in, which would
be the only reason for your changes not to be "current" anymore, then it
should apply as-is and you should be fine.
--
Florian
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-20 16:36 ` Florian Fainelli
0 siblings, 0 replies; 20+ messages in thread
From: Florian Fainelli @ 2019-09-20 16:36 UTC (permalink / raw)
To: Markus Elfring, Andrew Lunn, netdev
Cc: David S. Miller, Pawel Dembicki, Vivien Didelot, Linus Walleij,
kernel-janitors, LKML
On 9/20/19 8:30 AM, Markus Elfring wrote:
>> netdev is closed at the moment for patch.
>
> I wonder about this information.
This is covered here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40
and you can skip the reading and check this URL:
http://vger.kernel.org/~davem/net-next.html
>
>
>> Please repost once it reopens, in about 2 weeks time.
>
> I hope that the presented change possibilities can be integrated
> in the near future also without a repetition of this small patch series.
> https://lore.kernel.org/patchwork/project/lkml/list/?series=411271
You will have to resend it, and unless a bug fix comes in, which would
be the only reason for your changes not to be "current" anymore, then it
should apply as-is and you should be fine.
--
Florian
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
2019-09-20 16:36 ` Florian Fainelli
@ 2019-09-20 22:12 ` Jakub Kicinski
-1 siblings, 0 replies; 20+ messages in thread
From: Jakub Kicinski @ 2019-09-20 22:12 UTC (permalink / raw)
To: Florian Fainelli
Cc: Markus Elfring, Andrew Lunn, netdev, David S. Miller,
Pawel Dembicki, Vivien Didelot, Linus Walleij, kernel-janitors,
LKML
On Fri, 20 Sep 2019 09:36:57 -0700, Florian Fainelli wrote:
> On 9/20/19 8:30 AM, Markus Elfring wrote:
> >> netdev is closed at the moment for patch.
> >
> > I wonder about this information.
>
> This is covered here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40
>
> and you can skip the reading and check this URL:
>
> http://vger.kernel.org/~davem/net-next.html
Indeed, looks like we have a mix of clean ups of varying clarity here.
I will just drop all, including the devm_platform_ioremap_resource()
conversion patches from patchwork for now.
Markus, please repost them all once net-next opens.
Sorry for inconvenience.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-20 22:12 ` Jakub Kicinski
0 siblings, 0 replies; 20+ messages in thread
From: Jakub Kicinski @ 2019-09-20 22:12 UTC (permalink / raw)
To: Florian Fainelli
Cc: Markus Elfring, Andrew Lunn, netdev, David S. Miller,
Pawel Dembicki, Vivien Didelot, Linus Walleij, kernel-janitors,
LKML
On Fri, 20 Sep 2019 09:36:57 -0700, Florian Fainelli wrote:
> On 9/20/19 8:30 AM, Markus Elfring wrote:
> >> netdev is closed at the moment for patch.
> >
> > I wonder about this information.
>
> This is covered here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n40
>
> and you can skip the reading and check this URL:
>
> http://vger.kernel.org/~davem/net-next.html
Indeed, looks like we have a mix of clean ups of varying clarity here.
I will just drop all, including the devm_platform_ioremap_resource()
conversion patches from patchwork for now.
Markus, please repost them all once net-next opens.
Sorry for inconvenience.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
2019-09-20 22:12 ` Jakub Kicinski
@ 2019-09-21 7:12 ` Markus Elfring
-1 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-21 7:12 UTC (permalink / raw)
To: Jakub Kicinski, netdev
Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Pawel Dembicki,
Vivien Didelot, Linus Walleij, kernel-janitors, LKML
> Indeed, looks like we have a mix of clean ups of varying clarity here.
> I will just drop all, including the devm_platform_ioremap_resource()
> conversion patches from patchwork for now.
I would prefer an other patch management in this case.
> Markus, please repost them all once net-next opens.
> Sorry for inconvenience.
I would find it nicer if presented change possibilities can be
automatically reconsidered on demand after each closed period.
https://patchwork.ozlabs.org/project/netdev/list/?submitter=76334&state=*
https://patchwork.ozlabs.org/project/netdev/list/?submitter=65077&state=*&archive=both
Regards,
Markus
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [0/2] net: dsa: vsc73xx: Adjustments for vsc73xx_platform_probe()
@ 2019-09-21 7:12 ` Markus Elfring
0 siblings, 0 replies; 20+ messages in thread
From: Markus Elfring @ 2019-09-21 7:12 UTC (permalink / raw)
To: Jakub Kicinski, netdev
Cc: Florian Fainelli, Andrew Lunn, David S. Miller, Pawel Dembicki,
Vivien Didelot, Linus Walleij, kernel-janitors, LKML
> Indeed, looks like we have a mix of clean ups of varying clarity here.
> I will just drop all, including the devm_platform_ioremap_resource()
> conversion patches from patchwork for now.
I would prefer an other patch management in this case.
> Markus, please repost them all once net-next opens.
> Sorry for inconvenience.
I would find it nicer if presented change possibilities can be
automatically reconsidered on demand after each closed period.
https://patchwork.ozlabs.org/project/netdev/list/?submitter=76334&state=*
https://patchwork.ozlabs.org/project/netdev/list/?submitter=65077&state=*&archive=both
Regards,
Markus
^ permalink raw reply [flat|nested] 20+ messages in thread