* [master/thud/ti2019.03][PATCH] meta-toolchain-arago-qte: add quotes to vars
@ 2019-09-20 13:16 Jacob Stiffler
2019-09-20 18:17 ` Denys Dmytriyenko
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Stiffler @ 2019-09-20 13:16 UTC (permalink / raw)
To: meta-arago
* Add quotes around values which may contain spaces
Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
.../recipes-core/meta/meta-toolchain-arago-qte.bb | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
index b03b639..d313939 100644
--- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
+++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
@@ -5,7 +5,7 @@ TOOLCHAIN_SUFFIX ?= "-qte-sdk"
require meta-toolchain-arago.bb
-PR = "r19"
+PR = "r20"
# There could be qt5, qt4e and qt4x11 providers, but we don't support qt4x11 for now
QT_DIR_NAME = "${@oe.utils.conditional('QT_PROVIDER', 'qt5', '', 'qtopia', d)}"
@@ -19,10 +19,10 @@ toolchain_create_sdk_env_script_append() {
echo 'export OE_QMAKE_CFLAGS="$CFLAGS"' >> $script
echo 'export OE_QMAKE_CXXFLAGS="$CXXFLAGS"' >> $script
echo 'export OE_QMAKE_LDFLAGS="$LDFLAGS"' >> $script
- echo 'export OE_QMAKE_CC=$CC' >> $script
- echo 'export OE_QMAKE_CXX=$CXX' >> $script
- echo 'export OE_QMAKE_LINK=$CXX' >> $script
- echo 'export OE_QMAKE_AR=$AR' >> $script
+ echo 'export OE_QMAKE_CC="$CC"' >> $script
+ echo 'export OE_QMAKE_CXX="$CXX"' >> $script
+ echo 'export OE_QMAKE_LINK="$CXX"' >> $script
+ echo 'export OE_QMAKE_AR="$AR"' >> $script
echo 'export OE_QMAKE_PREFIX_QT=${prefix}' >> $script
echo 'export OE_QMAKE_LIBDIR_QT=${libdir}' >> $script
echo 'export OE_QMAKE_INCDIR_QT=${includedir}/${QT_DIR_NAME}' >> $script
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [master/thud/ti2019.03][PATCH] meta-toolchain-arago-qte: add quotes to vars
2019-09-20 13:16 [master/thud/ti2019.03][PATCH] meta-toolchain-arago-qte: add quotes to vars Jacob Stiffler
@ 2019-09-20 18:17 ` Denys Dmytriyenko
2019-09-20 19:14 ` Stiffler, Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2019-09-20 18:17 UTC (permalink / raw)
To: Jacob Stiffler; +Cc: meta-arago
BTW, do we also need to pass --sysroot parameter for qmake CC vars, like is
done for main CC vars here:
http://arago-project.org/git/?p=meta-arago.git;a=commitdiff;h=4e87564c39e214a61cbf0088ecf1a3f5a3f01bd5
On Fri, Sep 20, 2019 at 09:16:05AM -0400, Jacob Stiffler wrote:
> * Add quotes around values which may contain spaces
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> .../recipes-core/meta/meta-toolchain-arago-qte.bb | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
> index b03b639..d313939 100644
> --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
> +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
> @@ -5,7 +5,7 @@ TOOLCHAIN_SUFFIX ?= "-qte-sdk"
>
> require meta-toolchain-arago.bb
>
> -PR = "r19"
> +PR = "r20"
>
> # There could be qt5, qt4e and qt4x11 providers, but we don't support qt4x11 for now
> QT_DIR_NAME = "${@oe.utils.conditional('QT_PROVIDER', 'qt5', '', 'qtopia', d)}"
> @@ -19,10 +19,10 @@ toolchain_create_sdk_env_script_append() {
> echo 'export OE_QMAKE_CFLAGS="$CFLAGS"' >> $script
> echo 'export OE_QMAKE_CXXFLAGS="$CXXFLAGS"' >> $script
> echo 'export OE_QMAKE_LDFLAGS="$LDFLAGS"' >> $script
> - echo 'export OE_QMAKE_CC=$CC' >> $script
> - echo 'export OE_QMAKE_CXX=$CXX' >> $script
> - echo 'export OE_QMAKE_LINK=$CXX' >> $script
> - echo 'export OE_QMAKE_AR=$AR' >> $script
> + echo 'export OE_QMAKE_CC="$CC"' >> $script
> + echo 'export OE_QMAKE_CXX="$CXX"' >> $script
> + echo 'export OE_QMAKE_LINK="$CXX"' >> $script
> + echo 'export OE_QMAKE_AR="$AR"' >> $script
> echo 'export OE_QMAKE_PREFIX_QT=${prefix}' >> $script
> echo 'export OE_QMAKE_LIBDIR_QT=${libdir}' >> $script
> echo 'export OE_QMAKE_INCDIR_QT=${includedir}/${QT_DIR_NAME}' >> $script
> --
> 2.7.4
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [master/thud/ti2019.03][PATCH] meta-toolchain-arago-qte: add quotes to vars
2019-09-20 18:17 ` Denys Dmytriyenko
@ 2019-09-20 19:14 ` Stiffler, Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Stiffler, Jacob @ 2019-09-20 19:14 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
I am not sure what is require for qmake, but this was the effect with bash. If dash is the shell, then there is an error exporting the variable because of the whitespace.
In summary, this causes no change in behavior if bash is the shell.
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Friday, September 20, 2019 2:18 PM
> To: Stiffler, Jacob
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [master/thud/ti2019.03][PATCH] meta-toolchain-
> arago-qte: add quotes to vars
>
> BTW, do we also need to pass --sysroot parameter for qmake CC vars, like is
> done for main CC vars here:
> http://arago-project.org/git/?p=meta-
> arago.git;a=commitdiff;h=4e87564c39e214a61cbf0088ecf1a3f5a3f01bd5
>
>
> On Fri, Sep 20, 2019 at 09:16:05AM -0400, Jacob Stiffler wrote:
> > * Add quotes around values which may contain spaces
> >
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> > .../recipes-core/meta/meta-toolchain-arago-qte.bb | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-
> qte.bb b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-
> qte.bb
> > index b03b639..d313939 100644
> > --- a/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
> > +++ b/meta-arago-extras/recipes-core/meta/meta-toolchain-arago-qte.bb
> > @@ -5,7 +5,7 @@ TOOLCHAIN_SUFFIX ?= "-qte-sdk"
> >
> > require meta-toolchain-arago.bb
> >
> > -PR = "r19"
> > +PR = "r20"
> >
> > # There could be qt5, qt4e and qt4x11 providers, but we don't support
> qt4x11 for now
> > QT_DIR_NAME = "${@oe.utils.conditional('QT_PROVIDER', 'qt5', '', 'qtopia',
> d)}"
> > @@ -19,10 +19,10 @@ toolchain_create_sdk_env_script_append() {
> > echo 'export OE_QMAKE_CFLAGS="$CFLAGS"' >> $script
> > echo 'export OE_QMAKE_CXXFLAGS="$CXXFLAGS"' >> $script
> > echo 'export OE_QMAKE_LDFLAGS="$LDFLAGS"' >> $script
> > - echo 'export OE_QMAKE_CC=$CC' >> $script
> > - echo 'export OE_QMAKE_CXX=$CXX' >> $script
> > - echo 'export OE_QMAKE_LINK=$CXX' >> $script
> > - echo 'export OE_QMAKE_AR=$AR' >> $script
> > + echo 'export OE_QMAKE_CC="$CC"' >> $script
> > + echo 'export OE_QMAKE_CXX="$CXX"' >> $script
> > + echo 'export OE_QMAKE_LINK="$CXX"' >> $script
> > + echo 'export OE_QMAKE_AR="$AR"' >> $script
> > echo 'export OE_QMAKE_PREFIX_QT=${prefix}' >> $script
> > echo 'export OE_QMAKE_LIBDIR_QT=${libdir}' >> $script
> > echo 'export
> OE_QMAKE_INCDIR_QT=${includedir}/${QT_DIR_NAME}' >> $script
> > --
> > 2.7.4
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-20 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-20 13:16 [master/thud/ti2019.03][PATCH] meta-toolchain-arago-qte: add quotes to vars Jacob Stiffler
2019-09-20 18:17 ` Denys Dmytriyenko
2019-09-20 19:14 ` Stiffler, Jacob
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.