From: Pavel Machek <pavel@ucw.cz>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Anson Huang <anson.huang@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Andy Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"olof@lixom.net" <olof@lixom.net>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Sun, 22 Sep 2019 18:14:01 +0200 [thread overview]
Message-ID: <20190922161401.GC1999@bug> (raw)
In-Reply-To: <dbe0ba0a-29bc-ee96-541d-244b3dbf0b81@pengutronix.de>
Hi!
> >>Why is it global struct? It seems to be flexible configurable over devicetree.
> >>So I would assume it should be able to handle more then one button. Please
> >>remove global variables, make it allocatable per OF node.
> >
> >There is ONLY one button available for SC key, but yes, I think I can make the structure
> >private and get all necessary data from the structure using container_of.
>
> And we will never need more then 640 kB RAM ;)
> https://en.wikiquote.org/wiki/Talk:Bill_Gates
Right question is "is it worth complicating kernel now (and making it slower/bigger)
for future flexibility?". And I believe answer is "no", but it is not a big deal
either way. Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Jacky Bai <ping.bai@nxp.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
Peng Fan <peng.fan@nxp.com>, "stefan@agner.ch" <stefan@agner.ch>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
Anson Huang <anson.huang@nxp.com>,
"will@kernel.org" <will@kernel.org>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"ronald@innovation.ch" <ronald@innovation.ch>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"mripard@kernel.org" <mripard@kernel.org>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
Andy Duan <fugang.duan@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"olof@lixom.net" <olof@lixom.net>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Sun, 22 Sep 2019 18:14:01 +0200 [thread overview]
Message-ID: <20190922161401.GC1999@bug> (raw)
In-Reply-To: <dbe0ba0a-29bc-ee96-541d-244b3dbf0b81@pengutronix.de>
Hi!
> >>Why is it global struct? It seems to be flexible configurable over devicetree.
> >>So I would assume it should be able to handle more then one button. Please
> >>remove global variables, make it allocatable per OF node.
> >
> >There is ONLY one button available for SC key, but yes, I think I can make the structure
> >private and get all necessary data from the structure using container_of.
>
> And we will never need more then 640 kB RAM ;)
> https://en.wikiquote.org/wiki/Talk:Bill_Gates
Right question is "is it worth complicating kernel now (and making it slower/bigger)
for future flexibility?". And I believe answer is "no", but it is not a big deal
either way. Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Anson Huang <anson.huang@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
Andy Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"mripard@kernel.org" <mripard@kernel.org>,
"olof@lixom.net" <olof@lixom.net>,
"arnd@arndb.de" <arnd@arndb.de>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"ronald@innovation.ch" <ronald@innovation.ch>,
"m.felsch@pengutronix.de" <m.felsch@pengutronix.de>,
Jacky Bai <ping.bai@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support
Date: Sun, 22 Sep 2019 18:14:01 +0200 [thread overview]
Message-ID: <20190922161401.GC1999@bug> (raw)
In-Reply-To: <dbe0ba0a-29bc-ee96-541d-244b3dbf0b81@pengutronix.de>
Hi!
> >>Why is it global struct? It seems to be flexible configurable over devicetree.
> >>So I would assume it should be able to handle more then one button. Please
> >>remove global variables, make it allocatable per OF node.
> >
> >There is ONLY one button available for SC key, but yes, I think I can make the structure
> >private and get all necessary data from the structure using container_of.
>
> And we will never need more then 640 kB RAM ;)
> https://en.wikiquote.org/wiki/Talk:Bill_Gates
Right question is "is it worth complicating kernel now (and making it slower/bigger)
for future flexibility?". And I believe answer is "no", but it is not a big deal
either way. Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-09-22 16:14 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 14:03 [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:32 ` Oleksij Rempel
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:37 ` Anson Huang
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:47 ` Oleksij Rempel
2019-09-03 6:55 ` Anson Huang
2019-09-03 6:55 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 2:38 ` Fabio Estevam
2019-09-03 3:11 ` Anson Huang
2019-09-03 3:11 ` Anson Huang
2019-09-03 3:11 ` Anson Huang
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:12 ` Dmitry Torokhov
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:29 ` Oleksij Rempel
2019-09-03 6:48 ` Anson Huang
2019-09-03 6:48 ` Anson Huang
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:28 ` Oleksij Rempel
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:35 ` Anson Huang
2019-09-03 7:43 ` Oleksij Rempel
2019-09-03 7:43 ` Oleksij Rempel
2019-09-22 16:14 ` Pavel Machek [this message]
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-03 14:03 ` [PATCH V2 3/5] arm64: dts: imx8qxp: Add scu power key node Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 4/5] arm64: dts: imx8qxp-mek: Enable scu power key Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` [PATCH V2 5/5] arm64: defconfig: Enable CONFIG_KEYBOARD_IMX_SC_PWRKEY as module Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-03 14:03 ` Anson Huang
2019-09-22 16:13 ` [PATCH V2 1/5] dt-bindings: fsl: scu: add scu power key binding Pavel Machek
2019-09-22 16:13 ` Pavel Machek
2019-09-22 16:13 ` Pavel Machek
2019-09-23 2:31 ` Anson Huang
2019-09-23 2:31 ` Anson Huang
2019-09-23 2:31 ` Anson Huang
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-22 16:14 ` Pavel Machek
2019-09-23 2:34 ` Anson Huang
2019-09-23 2:34 ` Anson Huang
2019-09-23 2:34 ` Anson Huang
2019-10-06 0:32 ` Shawn Guo
2019-10-06 0:32 ` Shawn Guo
2019-10-06 0:32 ` Shawn Guo
2019-10-07 1:29 ` Anson Huang
2019-10-07 1:29 ` Anson Huang
2019-10-07 1:29 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190922161401.GC1999@bug \
--to=pavel@ucw.cz \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.baluta@nxp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olof@lixom.net \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.