From: Keith Busch <kbusch@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: fix an error code in nvme_init_subsystem()
Date: Mon, 23 Sep 2019 14:26:30 +0000 [thread overview]
Message-ID: <20190923142630.GA14804@C02WT3WMHTD6> (raw)
In-Reply-To: <20190923141836.GA31251@mwanda>
On Mon, Sep 23, 2019 at 05:18:36PM +0300, Dan Carpenter wrote:
> "ret" should be a negative error code here, but it's either success or
> possibly uninitialized.
>
> Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, patch looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme: fix an error code in nvme_init_subsystem()
Date: Mon, 23 Sep 2019 08:26:30 -0600 [thread overview]
Message-ID: <20190923142630.GA14804@C02WT3WMHTD6> (raw)
In-Reply-To: <20190923141836.GA31251@mwanda>
On Mon, Sep 23, 2019 at 05:18:36PM +0300, Dan Carpenter wrote:
> "ret" should be a negative error code here, but it's either success or
> possibly uninitialized.
>
> Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, patch looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nvme: fix an error code in nvme_init_subsystem()
Date: Mon, 23 Sep 2019 08:26:30 -0600 [thread overview]
Message-ID: <20190923142630.GA14804@C02WT3WMHTD6> (raw)
In-Reply-To: <20190923141836.GA31251@mwanda>
On Mon, Sep 23, 2019 at 05:18:36PM +0300, Dan Carpenter wrote:
> "ret" should be a negative error code here, but it's either success or
> possibly uninitialized.
>
> Fixes: 32fd90c40768 ("nvme: change locking for the per-subsystem controller list")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, patch looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
next prev parent reply other threads:[~2019-09-23 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:18 [PATCH] nvme: fix an error code in nvme_init_subsystem() Dan Carpenter
2019-09-23 14:18 ` Dan Carpenter
2019-09-23 14:18 ` Dan Carpenter
2019-09-23 14:26 ` Keith Busch [this message]
2019-09-23 14:26 ` Keith Busch
2019-09-23 14:26 ` Keith Busch
2019-09-27 21:17 ` Christoph Hellwig
2019-09-27 21:17 ` Christoph Hellwig
2019-09-27 21:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923142630.GA14804@C02WT3WMHTD6 \
--to=kbusch@kernel.org \
--cc=axboe@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.