From: Jeremy Sowden <jeremy@azazel.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jan Engelhardt <jengelh@inai.de>,
Netfilter Devel <netfilter-devel@vger.kernel.org>,
Sebastian Priebe <sebastian.priebe@de.sii.group>
Subject: Re: [PATCH nftables 1/3] src, include: add upstream linenoise source.
Date: Mon, 23 Sep 2019 19:15:11 +0100 [thread overview]
Message-ID: <20190923181511.GE28617@azazel.net> (raw)
In-Reply-To: <20190923092756.p5563jdmp2wljnex@salvia>
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On 2019-09-23, at 11:27:56 +0200, Pablo Neira Ayuso wrote:
> On Mon, Sep 23, 2019 at 10:47:40AM +0200, Jan Engelhardt wrote:
> > On Sunday 2019-09-22 09:09, Pablo Neira Ayuso wrote:
> > >> > src/linenoise.c | 1201 +++++++++++++++++++++++++++++++++++++++++++
> > >>
> > >> That seems like a recipe to end up with stale code. For a
> > >> distribution, it's static linking worsened by another degree.
> > >>
> > >> (https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries)
> > >
> > >I thought this is like mini-gmp.c? Are distributors packaging this
> > >as a library?
> >
> > Yes; No.
> >
> > After an update to a static library, a distro would have to rebuild
> > dependent packages and then distribute that. Doable, but cumbersome.
> >
> > But bundled code evades even that. If there is a problem, all
> > instances of the "static library" would need updating. Doable, but
> > even more cumbersome.
> >
> > Basically the question is: how is NF going to guarantee that
> > linenoise (or mini-gmp for that matter) are always up to date?
>
> It seems to me that mini-gmp.c was designed to be used like we do.
>
> For the linenoise case, given that there's already a package in
> Fedora, I'm fine to go for AC_CHECK_LIB([linenoise], ...) and _not_
> including the copy in our tree.
Righto. Will send out v2 in a bit.
> Probably other distributions might provide a package soon for this
> library.
I've nearly finished a package for Debian. Will see if anyone fancies
sponsoring it.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-23 18:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-21 12:20 [PATCH nftables 0/3] Add Linenoise support to the CLI Jeremy Sowden
2019-09-21 12:20 ` [PATCH nftables 1/3] src, include: add upstream linenoise source Jeremy Sowden
2019-09-21 19:19 ` Jan Engelhardt
2019-09-22 7:09 ` Pablo Neira Ayuso
2019-09-22 9:22 ` Jeremy Sowden
2019-09-22 22:28 ` Jeremy Sowden
2019-09-23 8:47 ` Jan Engelhardt
2019-09-23 9:27 ` Pablo Neira Ayuso
2019-09-23 18:15 ` Jeremy Sowden [this message]
2019-09-24 6:38 ` AW: " Priebe, Sebastian
2019-09-21 12:20 ` [PATCH nftables 2/3] cli: add linenoise CLI implementation Jeremy Sowden
2019-09-21 12:21 ` [PATCH nftables 3/3] main: add more information to `nft -v` Jeremy Sowden
-- strict thread matches above, loose matches on Subject: below --
2019-09-24 7:40 [PATCH nftables 0/3] Add Linenoise support to the CLI Jeremy Sowden
2019-09-24 7:40 ` [PATCH nftables 1/3] src, include: add upstream linenoise source Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923181511.GE28617@azazel.net \
--to=jeremy@azazel.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=sebastian.priebe@de.sii.group \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.