From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] clk: at91: avoid sleeping early
Date: Mon, 23 Sep 2019 23:34:03 +0200 [thread overview]
Message-ID: <20190923213403.GF4141@piout.net> (raw)
In-Reply-To: <20190923165848.3108A20882@mail.kernel.org>
On 23/09/2019 09:58:47-0700, Stephen Boyd wrote:
> Quoting Alexandre Belloni (2019-09-20 08:39:06)
> > It is not allowed to sleep to early in the boot process and this may lead
> > to kernel issues if the bootloader didn't prepare the slow clock and main
> > clock.
> >
> > This results in the following error and dump stack on the AriettaG25:
> > bad: scheduling from the idle thread!
> >
> > Ensure it is possible to sleep, else simply have a delay.
> >
> > Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> >
> > Note that this was already discussed a while ago and Arnd said this approach was
> > reasonable:
> > https://lore.kernel.org/lkml/6120818.MyeJZ74hYa@wuerfel/
>
> Does this need a Fixes: tag?
>
I'm not sure how far this can get backported
Fixes: 80eded6ce8bb ("clk: at91: add slow clks driver")
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: at91: avoid sleeping early
Date: Mon, 23 Sep 2019 23:34:03 +0200 [thread overview]
Message-ID: <20190923213403.GF4141@piout.net> (raw)
In-Reply-To: <20190923165848.3108A20882@mail.kernel.org>
On 23/09/2019 09:58:47-0700, Stephen Boyd wrote:
> Quoting Alexandre Belloni (2019-09-20 08:39:06)
> > It is not allowed to sleep to early in the boot process and this may lead
> > to kernel issues if the bootloader didn't prepare the slow clock and main
> > clock.
> >
> > This results in the following error and dump stack on the AriettaG25:
> > bad: scheduling from the idle thread!
> >
> > Ensure it is possible to sleep, else simply have a delay.
> >
> > Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > ---
> >
> > Note that this was already discussed a while ago and Arnd said this approach was
> > reasonable:
> > https://lore.kernel.org/lkml/6120818.MyeJZ74hYa@wuerfel/
>
> Does this need a Fixes: tag?
>
I'm not sure how far this can get backported
Fixes: 80eded6ce8bb ("clk: at91: add slow clks driver")
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-23 21:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 15:39 [PATCH] clk: at91: avoid sleeping early Alexandre Belloni
2019-09-20 15:39 ` Alexandre Belloni
2019-09-23 16:58 ` Stephen Boyd
2019-09-23 21:34 ` Alexandre Belloni [this message]
2019-09-23 21:34 ` Alexandre Belloni
2019-09-24 12:21 ` Uwe Kleine-König
2019-09-24 12:21 ` Uwe Kleine-König
2019-09-24 20:20 ` Stephen Boyd
2019-09-24 20:20 ` Stephen Boyd
2019-10-05 20:05 ` Alexandre Belloni
2019-10-05 20:05 ` Alexandre Belloni
2019-10-28 14:54 ` Stephen Boyd
2019-10-28 14:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923213403.GF4141@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.