From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Benoit Parrot <bparrot@ti.com>
Subject: [Patch v3 4/8] media: i2c: ov2659: fix s_stream return value
Date: Tue, 24 Sep 2019 11:44:10 -0500 [thread overview]
Message-ID: <20190924164414.21897-5-bparrot@ti.com> (raw)
In-Reply-To: <20190924164414.21897-1-bparrot@ti.com>
In ov2659_s_stream() return value for invoked function should be checked
and propagated.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
drivers/media/i2c/ov2659.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index f77320e8a60d..cd4625432264 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1187,10 +1187,13 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on)
goto unlock;
}
- ov2659_set_pixel_clock(ov2659);
- ov2659_set_frame_size(ov2659);
- ov2659_set_format(ov2659);
- ov2659_set_streaming(ov2659, 1);
+ ret = ov2659_set_pixel_clock(ov2659);
+ if (!ret)
+ ret = ov2659_set_frame_size(ov2659);
+ if (!ret)
+ ret = ov2659_set_format(ov2659);
+ if (!ret)
+ ov2659_set_streaming(ov2659, 1);
ov2659->streaming = on;
unlock:
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Benoit Parrot <bparrot@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Prabhakar Lad <prabhakar.csengg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Benoit Parrot <bparrot@ti.com>
Subject: [Patch v3 4/8] media: i2c: ov2659: fix s_stream return value
Date: Tue, 24 Sep 2019 11:44:10 -0500 [thread overview]
Message-ID: <20190924164414.21897-5-bparrot@ti.com> (raw)
In-Reply-To: <20190924164414.21897-1-bparrot@ti.com>
In ov2659_s_stream() return value for invoked function should be checked
and propagated.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
drivers/media/i2c/ov2659.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
index f77320e8a60d..cd4625432264 100644
--- a/drivers/media/i2c/ov2659.c
+++ b/drivers/media/i2c/ov2659.c
@@ -1187,10 +1187,13 @@ static int ov2659_s_stream(struct v4l2_subdev *sd, int on)
goto unlock;
}
- ov2659_set_pixel_clock(ov2659);
- ov2659_set_frame_size(ov2659);
- ov2659_set_format(ov2659);
- ov2659_set_streaming(ov2659, 1);
+ ret = ov2659_set_pixel_clock(ov2659);
+ if (!ret)
+ ret = ov2659_set_frame_size(ov2659);
+ if (!ret)
+ ret = ov2659_set_format(ov2659);
+ if (!ret)
+ ov2659_set_streaming(ov2659, 1);
ov2659->streaming = on;
unlock:
--
2.17.1
next prev parent reply other threads:[~2019-09-24 16:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 16:44 [Patch v3 0/8] media: i2c: ov2659: maintenance series Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-24 16:44 ` [Patch v3 1/8] media: i2c: ov2659: Fix for image wrap-around in lower resolution Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-24 16:44 ` [Patch v3 2/8] media: i2c: ov2659: Fix sensor detection to actually fail when device is not present Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-24 16:44 ` [Patch v3 3/8] media: i2c: ov2659: Cleanup include file list Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot [this message]
2019-09-24 16:44 ` [Patch v3 4/8] media: i2c: ov2659: fix s_stream return value Benoit Parrot
2019-09-24 16:44 ` [Patch v3 5/8] media: dt-bindings: ov2659: add powerdown/reset-gpios optional property Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-27 18:40 ` Rob Herring
2019-09-27 18:40 ` Rob Herring
2019-09-24 16:44 ` [Patch v3 6/8] media: i2c: ov2659: Add powerdown/reset gpio handling Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-25 9:51 ` Sakari Ailus
2019-09-25 14:37 ` Benoit Parrot
2019-09-25 14:37 ` Benoit Parrot
2019-09-24 16:44 ` [Patch v3 7/8] media: i2c: ov2659: Fix missing 720p register config Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
2019-09-24 16:44 ` [Patch v3 8/8] media: i2c: ov2659: Switch to SPDX Licensing Benoit Parrot
2019-09-24 16:44 ` Benoit Parrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924164414.21897-5-bparrot@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.