From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anup Patel <anup@brainfault.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
Anup Patel <Anup.Patel@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Atish Patra <Atish.Patra@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alistair Francis <Alistair.Francis@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Roman Kiryanov <rkir@google.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
Date: Wed, 25 Sep 2019 07:06:53 +0200 [thread overview]
Message-ID: <20190925050653.GA1337454@kroah.com> (raw)
In-Reply-To: <CAAhSdy1Z09tpNtfS10gL5BXJ=1wydLy4nmtFyKQenAPDSyTLTQ@mail.gmail.com>
On Wed, Sep 25, 2019 at 10:30:00AM +0530, Anup Patel wrote:
> On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > > We will be using some of the Goldfish virtual platform devices (such
> > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > > kconfig option for RISC-V architecture.
> > >
> > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > > ---
> > > drivers/platform/goldfish/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > > index 77b35df3a801..0ba825030ffe 100644
> > > --- a/drivers/platform/goldfish/Kconfig
> > > +++ b/drivers/platform/goldfish/Kconfig
> > > @@ -1,7 +1,7 @@
> > > # SPDX-License-Identifier: GPL-2.0-only
> > > menuconfig GOLDFISH
> > > bool "Platform support for Goldfish virtual devices"
> > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
> >
> > Why does this depend on any of these? Can't we just have:
>
> May be Goldfish drivers were compile tested/tried on these architectures only.
True, but that does not mean a driver should only have a specific list
of arches. This should only be needed if you _know_ it doesn't work on
a specific arch, not the other way around.
> > > depends on HAS_IOMEM
> >
> > And that's it?
>
> I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
> VirtIO MMIO. Agree ??
No idea, but if that's what is needed for building, then sure :)
thanks,
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anup Patel <anup@brainfault.org>
Cc: Anup Patel <Anup.Patel@wdc.com>,
Palmer Dabbelt <palmer@sifive.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Roman Kiryanov <rkir@google.com>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
Date: Wed, 25 Sep 2019 07:06:53 +0200 [thread overview]
Message-ID: <20190925050653.GA1337454@kroah.com> (raw)
In-Reply-To: <CAAhSdy1Z09tpNtfS10gL5BXJ=1wydLy4nmtFyKQenAPDSyTLTQ@mail.gmail.com>
On Wed, Sep 25, 2019 at 10:30:00AM +0530, Anup Patel wrote:
> On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > > We will be using some of the Goldfish virtual platform devices (such
> > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > > kconfig option for RISC-V architecture.
> > >
> > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > > ---
> > > drivers/platform/goldfish/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > > index 77b35df3a801..0ba825030ffe 100644
> > > --- a/drivers/platform/goldfish/Kconfig
> > > +++ b/drivers/platform/goldfish/Kconfig
> > > @@ -1,7 +1,7 @@
> > > # SPDX-License-Identifier: GPL-2.0-only
> > > menuconfig GOLDFISH
> > > bool "Platform support for Goldfish virtual devices"
> > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
> >
> > Why does this depend on any of these? Can't we just have:
>
> May be Goldfish drivers were compile tested/tried on these architectures only.
True, but that does not mean a driver should only have a specific list
of arches. This should only be needed if you _know_ it doesn't work on
a specific arch, not the other way around.
> > > depends on HAS_IOMEM
> >
> > And that's it?
>
> I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
> VirtIO MMIO. Agree ??
No idea, but if that's what is needed for building, then sure :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-09-25 5:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 4:29 [PATCH 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 4:29 ` Anup Patel
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
2019-09-25 4:30 ` Anup Patel
2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 5:00 ` Anup Patel
2019-09-25 5:00 ` Anup Patel
2019-09-25 5:06 ` Greg Kroah-Hartman [this message]
2019-09-25 5:06 ` Greg Kroah-Hartman
2019-09-25 5:16 ` Anup Patel
2019-09-25 5:16 ` Anup Patel
2019-09-25 4:30 ` [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
2019-09-25 4:30 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925050653.GA1337454@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rkir@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.