From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
Matthew Garrett <mjg59@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [RFC PATCH] tpm: only set efi_tpm_final_log_size after successful event log parsing
Date: Wed, 25 Sep 2019 13:38:54 +0300 [thread overview]
Message-ID: <20190925103854.GC6256@linux.intel.com> (raw)
In-Reply-To: <20190918191626.5741-1-jsnitsel@redhat.com>
On Wed, Sep 18, 2019 at 12:16:26PM -0700, Jerry Snitselaar wrote:
> + if (tbl_size < 0) {
> + pr_err("Failed to parse event in TPM Final Event log\n");
FW_BUG?
> + goto calc_out;
> + }
> +
> memblock_reserve((unsigned long)final_tbl,
> tbl_size + sizeof(*final_tbl));
> - early_memunmap(final_tbl, sizeof(*final_tbl));
> efi_tpm_final_log_size = tbl_size;
>
> +calc_out:
> + early_memunmap(final_tbl, sizeof(*final_tbl));
out_calc
> out:
> early_memunmap(log_tbl, sizeof(*log_tbl));
> return ret;
> --
> 2.23.0
>
/Jarkko
prev parent reply other threads:[~2019-09-25 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 19:16 [RFC PATCH] tpm: only set efi_tpm_final_log_size after successful event log parsing Jerry Snitselaar
2019-09-18 19:23 ` Jerry Snitselaar
2019-09-23 14:52 ` Laura Abbott
2019-09-23 17:10 ` Jerry Snitselaar
2019-09-25 10:40 ` Jarkko Sakkinen
2019-09-25 10:38 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925103854.GC6256@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jsnitsel@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.