From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-integrity@vger.kernel.org,
Matthew Garrett <mjg59@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [RFC PATCH] tpm: only set efi_tpm_final_log_size after successful event log parsing
Date: Wed, 25 Sep 2019 13:40:50 +0300 [thread overview]
Message-ID: <20190925104050.GD6256@linux.intel.com> (raw)
In-Reply-To: <20190923171010.csz4js3xs2mixmpq@cantor>
On Mon, Sep 23, 2019 at 10:10:10AM -0700, Jerry Snitselaar wrote:
> Any thoughts on this? I know of at least 2 Lenovo models that are
> running into this problem.
>
> In the case of the one I have currently have access to the problem is
> that the hash algorithm id for an event isn't one that is currently in
> the TCG registry, and it fails to find a match when walking the
> digest_sizes array. That seems like an issue for the vendor to fix in the bios,
> but we should look at the return value of tpm2_calc_event_log_size and not
> stick a negative value in efi_tpm_final_log_size.
Please use then "pr_err(FW_BUG".
Also, since you know the context you could add a comment along the
lines what you wrote.
/Jarkko
next prev parent reply other threads:[~2019-09-25 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 19:16 [RFC PATCH] tpm: only set efi_tpm_final_log_size after successful event log parsing Jerry Snitselaar
2019-09-18 19:23 ` Jerry Snitselaar
2019-09-23 14:52 ` Laura Abbott
2019-09-23 17:10 ` Jerry Snitselaar
2019-09-25 10:40 ` Jarkko Sakkinen [this message]
2019-09-25 10:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925104050.GD6256@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.