* [PATCH net] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()
@ 2019-09-25 10:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-09-25 10:56 UTC (permalink / raw)
To: Florian Fainelli
Cc: David S. Miller, bcm-kernel-feedback-list, netdev,
kernel-janitors
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as unsigned so the error handling will never be
triggered.
Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 7df887e4024c..a977a459bd20 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2481,7 +2481,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->phy_interface = of_get_phy_mode(dn);
/* Default to GMII interface mode */
- if (priv->phy_interface < 0)
+ if ((int)priv->phy_interface < 0)
priv->phy_interface = PHY_INTERFACE_MODE_GMII;
/* In the case of a fixed PHY, the DT node associated
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH net] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()
@ 2019-09-25 10:56 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2019-09-25 10:56 UTC (permalink / raw)
To: Florian Fainelli
Cc: David S. Miller, bcm-kernel-feedback-list, netdev,
kernel-janitors
The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as unsigned so the error handling will never be
triggered.
Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 7df887e4024c..a977a459bd20 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2481,7 +2481,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->phy_interface = of_get_phy_mode(dn);
/* Default to GMII interface mode */
- if (priv->phy_interface < 0)
+ if ((int)priv->phy_interface < 0)
priv->phy_interface = PHY_INTERFACE_MODE_GMII;
/* In the case of a fixed PHY, the DT node associated
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()
2019-09-25 10:56 ` Dan Carpenter
@ 2019-09-26 3:18 ` Florian Fainelli
-1 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-09-26 3:18 UTC (permalink / raw)
To: Dan Carpenter, Florian Fainelli
Cc: David S. Miller, bcm-kernel-feedback-list, netdev,
kernel-janitors
On 9/25/2019 3:56 AM, Dan Carpenter wrote:
> The "priv->phy_interface" variable is an enum and in this context GCC
> will treat it as unsigned so the error handling will never be
> triggered.
>
> Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()
@ 2019-09-26 3:18 ` Florian Fainelli
0 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2019-09-26 3:18 UTC (permalink / raw)
To: Dan Carpenter, Florian Fainelli
Cc: David S. Miller, bcm-kernel-feedback-list, netdev,
kernel-janitors
On 9/25/2019 3:56 AM, Dan Carpenter wrote:
> The "priv->phy_interface" variable is an enum and in this context GCC
> will treat it as unsigned so the error handling will never be
> triggered.
>
> Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-26 3:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-25 10:56 [PATCH net] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() Dan Carpenter
2019-09-25 10:56 ` Dan Carpenter
2019-09-26 3:18 ` Florian Fainelli
2019-09-26 3:18 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.