From: Gao Xiang <gaoxiang25@huawei.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode
Date: Wed, 25 Sep 2019 21:47:06 +0800 [thread overview]
Message-ID: <20190925134706.GA157912@architecture4> (raw)
In-Reply-To: <20190925093050.118921-1-yuchao0@huawei.com>
Hi Chao,
On Wed, Sep 25, 2019 at 05:30:50PM +0800, Chao Yu wrote:
> evict() should be called once i_count is zero, rather than i_nlinke
> is zero.
>
> Reported-by: Gao Xiang <gaoxiang25@huawei.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index db4fec30c30d..8262f4a483d3 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -632,7 +632,7 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
> }
>
> /*
> - * Called at the last iput() if i_nlink is zero
> + * Called at the last iput() if i_count is zero
Yeah, I'd suggest taking some time to look at other
inconsistent comments, it makes other folks confused
and ask me with such-"strong" reason...
Thanks,
Gao Xiang
> */
> void f2fs_evict_inode(struct inode *inode)
> {
> --
> 2.18.0.rc1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Gao Xiang <gaoxiang25@huawei.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode
Date: Wed, 25 Sep 2019 21:47:06 +0800 [thread overview]
Message-ID: <20190925134706.GA157912@architecture4> (raw)
In-Reply-To: <20190925093050.118921-1-yuchao0@huawei.com>
Hi Chao,
On Wed, Sep 25, 2019 at 05:30:50PM +0800, Chao Yu wrote:
> evict() should be called once i_count is zero, rather than i_nlinke
> is zero.
>
> Reported-by: Gao Xiang <gaoxiang25@huawei.com>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index db4fec30c30d..8262f4a483d3 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -632,7 +632,7 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
> }
>
> /*
> - * Called at the last iput() if i_nlink is zero
> + * Called at the last iput() if i_count is zero
Yeah, I'd suggest taking some time to look at other
inconsistent comments, it makes other folks confused
and ask me with such-"strong" reason...
Thanks,
Gao Xiang
> */
> void f2fs_evict_inode(struct inode *inode)
> {
> --
> 2.18.0.rc1
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2019-09-25 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 9:30 [f2fs-dev] [PATCH] f2fs: fix comment of f2fs_evict_inode Chao Yu
2019-09-25 9:30 ` Chao Yu
2019-09-25 13:47 ` Gao Xiang [this message]
2019-09-25 13:47 ` [f2fs-dev] " Gao Xiang
2019-09-26 1:04 ` Chao Yu
2019-09-26 1:04 ` Chao Yu
2019-09-27 18:31 ` Jaegeuk Kim
2019-09-27 18:31 ` Jaegeuk Kim
2019-09-27 19:01 ` [f2fs-dev] " Gao Xiang via Linux-f2fs-devel
2019-09-27 19:01 ` Gao Xiang
2019-09-29 0:53 ` [f2fs-dev] " Chao Yu
2019-09-29 0:53 ` Chao Yu
2019-09-29 2:20 ` [f2fs-dev] " Gao Xiang
2019-09-29 2:20 ` Gao Xiang
2019-09-29 2:52 ` Chao Yu
2019-09-29 2:52 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925134706.GA157912@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.