All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Marc Orr <marcorr@google.com>,
	kvm@vger.kernel.org, jmattson@google.com, pshier@google.com,
	krish.sadhukhan@oracle.com, rkrcmar@redhat.com,
	dinechin@redhat.com
Subject: Re: [kvm-unit-tests PATCH v7 2/2] x86: nvmx: test max atomic switch MSRs
Date: Thu, 26 Sep 2019 07:32:01 -0700	[thread overview]
Message-ID: <20190926143201.GA4738@linux.intel.com> (raw)
In-Reply-To: <91eb40a0-c436-5737-aa8a-c657b7221be2@redhat.com>

On Thu, Sep 26, 2019 at 11:24:57AM +0200, Paolo Bonzini wrote:
> On 25/09/19 03:18, Marc Orr wrote:
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index 694ee3d42f3a..05122cf91ea1 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -227,7 +227,7 @@ extra_params = -cpu qemu64,+umip
> >  
> >  [vmx]
> >  file = vmx.flat
> > -extra_params = -cpu host,+vmx -append "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test"
> > +extra_params = -cpu host,+vmx -append "-exit_monitor_from_l2_test -ept_access* -vmx_smp* -vmx_vmcs_shadow_test -atomic_switch_overflow_msrs_test"
> >  arch = x86_64
> >  groups = vmx
> 
> I just noticed this, why is the test disabled by default?

The negative test triggers undefined behavior, e.g. on bare metal the
test would fail because VM-Enter would succeed due to lack of an explicit
check on the MSR count.

Since the test relies on somehwat arbitrary KVM behavior, we made it opt-in.

  reply	other threads:[~2019-09-26 14:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25  1:18 [kvm-unit-tests PATCH v7 1/2] x86: nvmx: fix bug in __enter_guest() Marc Orr
2019-09-25  1:18 ` [kvm-unit-tests PATCH v7 2/2] x86: nvmx: test max atomic switch MSRs Marc Orr
2019-09-25 19:13   ` Sean Christopherson
2019-09-26  9:24   ` Paolo Bonzini
2019-09-26 14:32     ` Sean Christopherson [this message]
2019-09-26 14:35       ` Liran Alon
2019-09-26 14:49         ` Paolo Bonzini
2019-09-30 23:25       ` Nadav Amit
2019-09-30 23:34         ` Marc Orr
2019-09-30 23:58           ` Nadav Amit
2019-10-01  0:03             ` Marc Orr
2019-10-01  0:08               ` Nadav Amit
2019-10-01  0:12                 ` Marc Orr
2019-10-01  0:37                   ` Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926143201.GA4738@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=dinechin@redhat.com \
    --cc=jmattson@google.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=marcorr@google.com \
    --cc=pbonzini@redhat.com \
    --cc=pshier@google.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.